From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68A22A00BE; Tue, 19 Apr 2022 14:28:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D0EE4068E; Tue, 19 Apr 2022 14:28:03 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 4D4F140687 for ; Tue, 19 Apr 2022 14:28:02 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23J7WQf7003298; Tue, 19 Apr 2022 05:27:58 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2107.outbound.protection.outlook.com [104.47.55.107]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fhemwu0sv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Apr 2022 05:27:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DZfrckPDF7qB9k6cbevLVs40NTVMK1To1XDns67cwSIbzOOLVxKsOeV+TwvCiLadzSsbV31ijon3znhGMNl3zK4o6l33EH3sPRa+/e59c2Iys3fFnDctcXqhDgyMFcNFmmg0Q1psqf+NiaKuTyEwPoRLADUvnKYG9IOOjyEEgqN9urAs7J2evnqnegP/jMW5/xXeoNyv1BAR8BauzeXAtR8QxvykJbDYmUMkPuc5+QFSfjPI8oLlCdooPOXY8gSK/wvncLw/0uVcFcSJg1NMex88XLiFew8zREIe9IBbkhqYdgMz5+vY7P+bV55SiB+WeWKCFr9+togSkxQhtqhl8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wTyo84DkHar6pfwrCOiJanJ4Ube/m9m/ezanZoQJYl4=; b=hp45dT3ssxWyYLMiipS6vLW8LbhwVxr3baC3HZtrRybmVszokBYJFo8nuAP9zYBU4llx4LrGcrhp9iCPPjJ/A9be+7D2XJRHUCpxLZ7YsiPO3rLeZufP72kBS6BABC+5e73bzdRw9NpRDMxrZiKZtiqUCVhuoURRa0tzoqnj/JGCDCn2mOloYj9+kBGrc0Dm7oFQVYhBAEDDMmhU4VIUxE8rT6MhcdGezv0+JxfdhWhhcyX53pL0Jf72l8DaAAOt1mUWcBGMxovw5VevavR084S7QwRHbeY7ALwHP6/BkZRD2bQYxI/URV0tJSI9hyU5qPxwC4FKv/d5xN5Ziib85Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wTyo84DkHar6pfwrCOiJanJ4Ube/m9m/ezanZoQJYl4=; b=Ib/Hw5DuIX/N9JAWxQCgM4HhX4Rjr1+yqzI1FXYAnvB3N3H+xYi8ppGcyQiow/0dsnGbjHYY/wlkE+/vntR42W27+cxBoVYeULBdXT6O3LRv+3JuxfuN5BKJa12yk/+V7TPHjyAwx3IWGKAUp023dozyK6NYBVVsPK7xtO5vNdQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MWHPR18MB1199.namprd18.prod.outlook.com (2603:10b6:320:2d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr 2022 12:27:54 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338%6]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022 12:27:54 +0000 From: Akhil Goyal To: Thomas Monjalon , "mdr@ashroe.eu" CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "konstantin.ananyev@intel.com" , "ciara.power@intel.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru Subject: RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Thread-Topic: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Thread-Index: AQHYU8uwM2cgSOHVbk6YmCEbondN/qz2/x5ggAAPHACAABsvcA== Date: Tue, 19 Apr 2022 12:27:54 +0000 Message-ID: References: <20220217172341.607360-1-gakhil@marvell.com> <11961195.O9o76ZdvQC@thomas> <4703969.GXAFRqVoOG@thomas> In-Reply-To: <4703969.GXAFRqVoOG@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4c8389ce-a14e-44cd-3099-08da2200071e x-ms-traffictypediagnostic: MWHPR18MB1199:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X3gC3EU7uYS1TBip6PBezdaX3KYGel8j9MkPo3a3SobkGldpZqtSUXz2c5cJiMcBRPnPd6IKTi62g2DBKAxmNc3rUvA7eyXW7a+beu4nPiR251kqTTDe5SDNxoKHfRBhgFcNaA4hotS57eYg1jAziv9q0zJHhE/H85y6i3Uk3db0Xvc71ZkTjRIiPbws0wHkNYr7mwAfVyUqHEolSRhJ11J/ECpep/CcUCVQkAh+IWwlu1N5o0qEfCIPn4zMYMqDrhdqgAqCuf3Sl96NWWJ8fp1imDjn6VKYZFEBhDtJIxtoI/8Sw54glfpDd/3tiDRmDWmlAfztrzfHbJUccxNgVe1zxn2VQr+di2aPZfZqiBS6IVkYsp63FbjbgJlwcmXV+bhIEQ2w1ttMqJswln4yko+GlqNDo/eB7IGmu53hG5/laNijlF2smt/Qy1a/e3GJr/R6IJ9nGUrFr7YnIIjMX3PNyhJ2X2PxBUvN6iZ57396DlG1EkJAiRsNRJZR5750TaF+4v7vq8wDp3jdhXH/2LDMo1lfIyyoQo4rrYRYb6EQuh15kHehurSjELAyYo2Qoh+TRaRoTQXml+S5OUbQ6kZcxyCvvfGWmRSgOtIHDkhDueX6j6Qkgh7pH23KUDB47T/8qkgP/I1KFzAmyu75aarvmrgZlzvtLeqgVOw7NocAZXAzT70gEUkGZ2vyW3uPfG3z2o8gC6/C3WQZz8ATDQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(2906002)(6506007)(64756008)(33656002)(186003)(66946007)(66556008)(8676002)(122000001)(66476007)(76116006)(38100700002)(66446008)(107886003)(38070700005)(26005)(71200400001)(83380400001)(9686003)(4326008)(86362001)(7696005)(508600001)(5660300002)(110136005)(8936002)(52536014)(54906003)(55236004)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Xv0FzOW9msZmGR9n6uDEWQWjqNKcasUFv+ns+ZVwsSXP4FVpMKfRZG637YPq?= =?us-ascii?Q?is7TMHo2x0/IhEyroW9JNG0HPJQa1IEK/fys44ONSZb+dXrllpZyVNVJDqe3?= =?us-ascii?Q?HJd+tvWo0gjqPtUTpaqRDu3m5ZSBSyIYvNRea1O+s7CA7Db4DRktLVlQC9r7?= =?us-ascii?Q?ppap+BGzv5PaIxU2MxKHjptif4YijXo/r3jN071t83CxgCu+RUs+ZJjyouL2?= =?us-ascii?Q?IA4XFLAXooGavI62mO119YO9vU0yTTk1CMb3zox5YMyjM/Q/TJnvxhrm4S3w?= =?us-ascii?Q?l4lsiH28fueIwV4EWgd9WolS4V6DwK06aujWC24x2AG+fvyFqBa1bFxNf0Ul?= =?us-ascii?Q?yLP9d4yBk9MOwXcsHtdswwKwL+79jTEfIOhO+EVdB8NKrta0yReAOnnHZUoq?= =?us-ascii?Q?gRyrdfhEQlru+E72pQ0XumAdgvrFS7gW52qnyigZyurHdDKAFkTMsq4+g1Zl?= =?us-ascii?Q?bYCVlCIulcUYoFJ9ahXf80JzyXLuWmYM8NuDemz9kXpvCPJxsaw3ZvKrwm7Q?= =?us-ascii?Q?EHU0r1R2SvgBINkjugY1uOQnTetH4k5+uV2s69dS0PTY1ecpT8lF/V+vFFqX?= =?us-ascii?Q?YmlKxQmkS1HBi5qx1Ym6NNGTZN1PDhtRYN7tjIIEUYPnV7C0D5sK7gzd1utU?= =?us-ascii?Q?zJY8PwpFbV9mLrlgEubf1/M6duaW7Aci4KjAHQa8aAlRnc+42oKwUZhdR3OL?= =?us-ascii?Q?1DQJxqBgcd9Rq2XTERnQnP/beFq/bYkxygqmJkPwS3Xtvt0N0RH7ynwpgO6e?= =?us-ascii?Q?UmEddqV71JdgphisqBmIfrJgSljM4eJfjQv4VQP4Gc4DqlwovKDYjE2izvfN?= =?us-ascii?Q?7PRKP+wELJRgsHkccEqkEgsYetxFcfznZVDnFNZbxzEh9z8cwWVsdg2SQBJs?= =?us-ascii?Q?X1d/4axMtIB1VtLCKt+UiCjkG6hVTHU+gDcPvN+WdExn8dkI5YbnmAdZGUgk?= =?us-ascii?Q?BT1OHmUpvbd/f/pfUXT965e6oioN/5PtQIn0Lg93Z5/9p2gaOPk5+ail/aVF?= =?us-ascii?Q?7jVdFc0g9NO7iCqePZ6fdSdgn7j3tXP78DYPRwl60j5+U3jd3q4ouwfahIOo?= =?us-ascii?Q?EGBuUPxJvcQBW3DIowPNs1EcE+6Ne683DNsQcwfN3WLadNzHBcF6zTLrA8pI?= =?us-ascii?Q?Cn7NnWfKoBHVZKKuH37elpjl3f11EFdZYJ26HbD6TPS+1cqpZirsveIWQPu0?= =?us-ascii?Q?nrspZCOpaanAqev1ORlNP89vFNPRAQve2dgHBKIqilZW7EgXE3FJFmkDu3QH?= =?us-ascii?Q?ECqJ3pVg5J0EAm4P136mOJd8C5DP1Nmm/Yeq1wNzW0jyxm9inWymsEN4p5US?= =?us-ascii?Q?qPXcNFcnLdTXoDYfkAq3QdU1iT7iGjcwqS8Y5IBsWXfBmxtCVIq9NZIgzan1?= =?us-ascii?Q?1QhLkmRoRps++IMMMwSPrzt7OTJxPXGNWD97I/BRHo8p5q91bLx8axm2kVeo?= =?us-ascii?Q?qXYuK3qiDUO6fSR30/3v0Eka4jAAPUyy4GGdughv4FY9xQQvi4rEJetjTEnJ?= =?us-ascii?Q?0pA4dSNYSU90xEVxR80ZGg/9kr86tKnUnkOMShHdJ+Q+Cpu44QfVQrQ8JFWW?= =?us-ascii?Q?V0s/VjXZZ59Z0NVxz0LeM0nVxa0h0ZAZseidjpgqyoG7WPhmw9T92zYGt5xy?= =?us-ascii?Q?Eudo3nk5htq0iHA04nOjHAkRriHrnjYyhPqdxWDMaMXkQoiNnZ8j4MOwr3LL?= =?us-ascii?Q?+v/Nig8IOndnslDhuXAl+mXv1UgBxh8iHUnB+FCihPI1ZLjT8l4fi4ln+HMO?= =?us-ascii?Q?1g9Dwq6nsA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c8389ce-a14e-44cd-3099-08da2200071e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 12:27:54.0484 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BA88veIPfK5OmfBEYxn7nCuoECC51C3fdHZw4WWQion4/KJu6Zhsm5sVfznBa9wbVenstz8+6tBdArNALBkIog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1199 X-Proofpoint-ORIG-GUID: TpA0t9fhVrEJiGpyQhRUVf7GAVyPLkyD X-Proofpoint-GUID: TpA0t9fhVrEJiGpyQhRUVf7GAVyPLkyD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-19_05,2022-04-15_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Time expiry means after x seconds SA will expire. > > Packet expiry means after x packets processing SA will expire. > > Byte expiry means after x bytes of packet processing SA will expire. >=20 > I think you should use the syntax @ref packets_soft_limit > so it is clear where the event come from. OK will update the comments. >=20 >=20 > > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > > > > + /** Hard byte expiry of SA */ > > > > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > > > > + /** Hard packet expiry of SA */ > > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, > > > > > > Same comment for the 3 events. > > > > > > > /** Max value of this enum */ > > > > RTE_ETH_EVENT_IPSEC_MAX > > > > }; > > > > > > What is the impact of this "MAX" value on ABI compatibility? > > > > I see no issues reported while running ABI check. > > There is no array being used inside library based on MAX. >=20 > No need of array inside the library, the events are exposed to the app. > I'm surprised libabigail is OK with changing an enum value. >=20 @Ray Can you please check if it is an issue to add more values in this enum= ?