From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90F9CA0545; Thu, 26 May 2022 13:56:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 423A040151; Thu, 26 May 2022 13:56:08 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 4BA6C40150 for ; Thu, 26 May 2022 13:56:06 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q9BMMr025529; Thu, 26 May 2022 04:56:05 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g93ty8jss-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 04:56:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UE5aE6x0FWaQNR/kPiJnojvoiRn0jQ2yhEUb7CAsbGp1I8GucSEoq77VRiPU7+ZPDrZrV4zpbzbQ/wGjky+GkcONOij5TTRCwx3Bg36aELja4szf74gTpRZFV4/t8+Evc8qV0MLBYxXycSrDffNvvtZ5COSAZroORVrEqAZp+KX86g0+IRe4REF5JA+cS53cUmJFHP2VtusW8aZ/hEk4VcxxdrB8ASWlhPiZtsrrnjvDNRMmxcpH6YUXb8NBfzPYiffiFqRp5wA0YG3dkMEfhZNLBgSItPU/+UEhou2jCZoAcmvwqnmKl038DzrLgr8sH3iNnOGQzdbkinskCoEtOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHm98T1OGHEFdTuf/FQyMGpVOZyU7uesqJKwQ7Kc7H0=; b=kaYISAQbICm5YA1gL2vTbteJdJpF57KEI701UzwT+QxHhsrDw1ROUVFhpsTxc2XphQOgfaJJFCV8ViAgWU+zhQYc/UPZXHoVZEhV/k6T7AlW2c55eExvGH/lw0gia6DRdnZYgt1NYg7weFFfi1o+WQDVn49ldNcrJ8Sa2KhGBOnLhcfqaMSqiP1NV9JJIJg0ibOzovvOqqk5O6hrjliuQ3YorwHgOoQAEU7kr9CB30oScxgpwDsgydTjEQf34IJrTsRk36CZHiWy7JCH3O3ZdQ1vw7mE4RKVVfaKbKLJaWfJBCRvlYQsLpYD/UXT9HUM1/IPszgapptYL2sLOEGjkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHm98T1OGHEFdTuf/FQyMGpVOZyU7uesqJKwQ7Kc7H0=; b=kgiI+uALin3tV30MU5FHhezFByJ1waqealR4kMyNM5+mPnE3eXScI1AfzMTcSIzeaV3tAaLFUdljVzAHspCBvht5RJPjt9lj92V5tl7TuGmS7yy9LC6a8xdZ2mVdQzZJPlK6yP/XoCiWpsVksFxC7dU4yIomdYjU/QvJGrDssAA= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB4526.namprd18.prod.outlook.com (2603:10b6:a03:302::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:56:03 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:56:03 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v2 10/14] cryptodev: clarify usage of rsa padding hash Thread-Topic: [EXT] [PATCH v2 10/14] cryptodev: clarify usage of rsa padding hash Thread-Index: AQHYcFmgvK4KxGf2Ukiur2A0ULeEE60xDUCQ Date: Thu, 26 May 2022 11:56:03 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-11-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-11-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fc16376-cb25-47c8-4986-08da3f0eb581 x-ms-traffictypediagnostic: SJ0PR18MB4526:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lIbSYey14uNQ6CRvPzIhGg6CYAiC9TPJzjldwHysx9SHZJhBKDMerkU1qG3xmpTziCzUA4J0crD3DT+l2LMf+q59oBrb1VIUgN/Qj7PHIUOiHZi2GeIphig+q+rIK12f0X6Mp3ufJlWjRuK2Mad7Kk5JerzEsgShjWQfB8ELMxrHIL/RvCuoHJoUbkLAM5R4HJLHwQi8kPjoQzq4DjBkKEE2oN4bHfp3VAmtiBM6IED6vmLV5Ff1sJ9Fw5UIqU+bV1z8q2o9chOs8XjzryKQIY0LCXW8eT+xj6r9DcMDRD40huJeOQP+QlE7x0eOzYitVupGC4mFFtIFwxgOwusxZtYQC6sFVRy4eQN0BdJZN2EmGtsDIZ0PqaWaJeY5Dbd7G+bnOFBw+4rpUq3P/YlZaLWS2mC0eISIwgpws7RuMGnkPkeEgRhXrw7iNgbzrjb7GGjf9e5nR/lAzU/Upk3HZxQYWVdos18ffJTDYtenMNKPWSZF0rXMsfRQxGin7stZHjBv8WVj+3v5Qw2OgjyNPfRVnUWXWlvqQcr/8it3bOSxKI63zlWWPGO9gAvfVUei1xkgOuaJ18SVHu1X1ktacNO01vaXMzfXGOZjZQpQIWNkssHDYevroMBRiHaf3A/nCg04dQ3k2xSM7jiBlvT2ZrRppqOmqnCVtpwWl77UgUHL13Yves37FlKRCTE9Taq0+qYOSwiksO6yI2/6PoR9IQgVD8Qh8fpe0UoEyWMFFvY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(122000001)(71200400001)(4326008)(52536014)(66446008)(8676002)(64756008)(7696005)(6506007)(55236004)(66476007)(76116006)(9686003)(66946007)(66556008)(38100700002)(38070700005)(8936002)(2906002)(5660300002)(86362001)(83380400001)(33656002)(316002)(508600001)(26005)(186003)(110136005)(55016003)(473944003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GwMvEGQi6ENdMKPWLcLl214aQNgqSrgnqVtIHO+YqNn8I5mPM5vjwoExnNCB?= =?us-ascii?Q?P0LBMJ9pKPf25oH1o6Dqj6xV3wYvNwghoczKscXXFpyYvbg/edi3ALet3Vaf?= =?us-ascii?Q?9LZAKBceRkQY9G/6JNvhx58aA4Zt1KhMhp4GsZGfKnq0LokN+JAeLvbXjhgI?= =?us-ascii?Q?cg8KUu72Vjg+TzKgCLg9Es+0JHs1Q98U0sGQSeT9yV0dkQtSE/qFvljaHiIl?= =?us-ascii?Q?zfib64IwN7mxJCmSM2Bjj4eTNrRBVYXkknvRpco9s5yPve7ADdUxWyeF3Xdt?= =?us-ascii?Q?fL/qFDZKMIMDrwQYOZTCbYUrNMZlWBIB/mBe5KGDmg8CXFzJQCLKpTWlLOIZ?= =?us-ascii?Q?+BxIC4xVwBGlW2KfLYsvUtgAupcLGENgtDiAj2ufOMaaxgY79rO76NfAIfYx?= =?us-ascii?Q?TqWIBJa5goOME40Nf4HiinAsRWls6o3MXHkInk6Th6+qFw/2JvW/T4KbBKq8?= =?us-ascii?Q?5zVeIaMXo5BirYV2iDuRPLecVzJ0qqQfQOKFYhXCTfjw1tI7yX2fSLRgMoOU?= =?us-ascii?Q?hA7wwXXK42KR77FASDMGLn2cEDfLCjngqjrb7stqkfXcL9Vz7Xq/Z5S0nPuo?= =?us-ascii?Q?egN5druGK8kvSezJR78eiJpb6zqp7OU8lAI2IXEKssLnxZECpaB8KP2zF4B8?= =?us-ascii?Q?YkNk1F1BUu+4kwK3c5NhIVbg2FN0+A7x5e1hfTNe0vTqWPn40SC6rDq7mAUf?= =?us-ascii?Q?PKBt2rig86E+QkCXqt/ZD1sCOC3ldiuCHl/l5Fa9X3OCD9MxexlXSOvUhcUg?= =?us-ascii?Q?w616gnzy5whtvOLy7XKwhkVl27iVr4+d4rO+6utxI90C4PcNqlwLyfl3RbXM?= =?us-ascii?Q?hCYVqExM1PZjiP59kvonCQzIrOtp5XgW1Wy+znD7Q89euphdkgnqeOoPO+eH?= =?us-ascii?Q?ZXQaO3haNj2LHTkCiJgTmRpS/0/yEVK0Bw4XyymLSsjwnpojQWbjMfbgefDN?= =?us-ascii?Q?UV5Xlj+Ryph6sO2Ok5Rk8ek2H+VgF3dYmsxH+b12ZwtMEmuepJ+NF9Vz7MHf?= =?us-ascii?Q?T3ejXI528xLlcuyacCtbpyklVL4wt8L+/XjgiupKUJAosqOa74+P9I5jpsvc?= =?us-ascii?Q?SuuYKNTxhy6KyoiR9cNClw2zuzDFY/+KdpakPHle1GZRwDoSFrZ1W2Le6O7R?= =?us-ascii?Q?tQka2nTetGCKKeY7UGA20ry8WLTrsksR/ACBPYowP5oYKYrjrtloKAL154rI?= =?us-ascii?Q?cL9cjOavJSq4L/3TWet6TCk+DxGzHg5hyO74aEFUY4rAXuh9IiFbAm0qPH1S?= =?us-ascii?Q?GQL6R43SWz0ivm4BPbsZcm/fat4oNyWl/woT1BZH379fUepzpyMnjOt4xIiu?= =?us-ascii?Q?193poT9EmbLq4dpnq3pVAYnHq365l5Pj0XKwp7oWH6iBqiH0LyxHd6ydL5aD?= =?us-ascii?Q?cUvxMXC+PfQMA+WZXkDtIj85yrNpbZgnRkDnzpDJWf6sdEfqMssLbBJIUEPO?= =?us-ascii?Q?/RC34J2EFu/GnBFv+bwRFnwFyjERAh5JxsdTpM9arj9Osurf8HNNzjxQeWUb?= =?us-ascii?Q?eQ2HRy7PiTvragNb2KRryOU4or+xuvZQq1f+FCS8bhMzEdU5GRFGyzonDF7u?= =?us-ascii?Q?OGinLluEy6DbLBWcZb1fo9b5qfVkM/LIGvQ90vRrglgBIyLNR4d4b0eKWjro?= =?us-ascii?Q?5LptAjkkuZO1tWvc8cU8xCu4zetcObeLY/6ODKrbi68Qd9sc8gQ/U5mqskAD?= =?us-ascii?Q?8g0u2yiwKdr7HI4x/2tCEYQQsv+WU/MoUvDk+LilOBHqir5d1cUSru42L8/G?= =?us-ascii?Q?H0PVo7le+A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc16376-cb25-47c8-4986-08da3f0eb581 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 11:56:03.2962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d4obxuG/2blhqXoUMHCCq7qK8+MPuFRXHX9evvqPjzrDOv83K5Zt3b51Hf1c49tFnuB/hcd+1J8xLSjEoq8KLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4526 X-Proofpoint-GUID: q4O6yBj6KRhWQRS03WlIx_o5Fbvmh7DQ X-Proofpoint-ORIG-GUID: q4O6yBj6KRhWQRS03WlIx_o5Fbvmh7DQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_07,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Clarified usage of RSA padding hash. > It was not specified how to use hash for PKCS1_5 > padding. This could lead to incorrect implementation. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 25 +++++++++++++++++++++---- > 1 file changed, 21 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 1a57c0c532..1758aaa875 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -371,10 +371,27 @@ struct rte_crypto_rsa_op_param { > /**< RSA padding scheme to be used for transform */ >=20 > enum rte_crypto_auth_algorithm md; > - /**< Hash algorithm to be used for data hash if padding > - * scheme is either OAEP or PSS. Valid hash algorithms > - * are: > - * MD5, SHA1, SHA224, SHA256, SHA384, SHA512 > + /**< > + * RSA padding hash function Function->algorithm > + * > + * When a specific padding type is selected, the following rule apply: > + * - RTE_CRYPTO_RSA_PADDING_NONE: > + * This field is ignored by the PMD > + * > + * - RTE_CRYPTO_RSA_PADDING_PKCS1_5: > + * When signing operation this field is used to determine value For sign operation, this field is used... > + * of the DigestInfo structure, therefore specifying which algorithm > + * was used to create the message digest. > + * When doing encryption/decryption this field is ignored for this > + * padding type. For encryption/decryption, this field is ignored. > + * > + * - RTE_CRYPTO_RSA_PADDING_OAEP > + * This field shall be set with the hash algorithm used > + * in the padding scheme > + * > + * - RTE_CRYPTO_RSA_PADDING_PSS > + * This field shall be set with the hash algorithm used > + * in the padding scheme (and to create the input message digest) > */ >=20 > enum rte_crypto_auth_algorithm mgf1md; > -- > 2.13.6