From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8788FA00BE; Mon, 16 May 2022 20:51:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 729ED40A7A; Mon, 16 May 2022 20:51:51 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 15AFD4068B for ; Mon, 16 May 2022 20:51:49 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24GEsZkv004341; Mon, 16 May 2022 11:51:49 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g3rsqry31-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 May 2022 11:51:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bXNLY3pfyWLahJB0Fy6Y3IcI6BmawBQcv1Y2uRUWhpzPNh5OBUFJVU9zyHyuapLQBRB++pmjt0x+AH1GWSPAXMNn3LbTE274PUccdhi4RCA4mTx6odp5tjA6ufQFCjkQEl8ZpOMQjlZ0RcJ2rkmp5JpP7cWTr9O0ryFDxuFpykOkWyXq1R1cTv8NIspK0XWPhZFqGD38UBqyq4DlNLCuBDNwMykEdspmI5neA5Do+nTBfzJVxMoquJ77xHWdv+Xn8T9yosF1ei8O4f3J4ccweIwfYTUJvAQFv8CmID1dap/eGnYH0/sVsmvjV1tj/SkSoxsWY87OHfz73JH3z52K6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H+qjCmcmYzkBL2vCQN0wQ1uHzmEnLpsdgOBa06RLtVw=; b=PigYrlhkDx2kra/a90uszOwc529uMFNLcPIJrDrqZVms+TL/XHfzoXaiHN/GgZcJzIT1yKpWA8iPjDa4EbQ3IYXckDmXrx8t6y5hawYe2NhEKBCqnYj6m75bgmMLbfG8lkpSd0p1r60YTG3k59YLZrKF78znib7DUw+zhXncDKfalFB1F5KN7bt7oZSZOZaDloXyW9yzr8/nrl3nOGu6FyLoJecADoiiCAYKvB1cCyRp/sS+Awg8l4UO4yhE3hVlBCpI4Cw2XZ5nTxz3OkKeCcHA83IwX1NdEyM+07zPh4iJqwwi4d2tRqReSaP0gi9t3D2jsS+16hlm6BxKiBfJFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+qjCmcmYzkBL2vCQN0wQ1uHzmEnLpsdgOBa06RLtVw=; b=qvw77cMxyWPyiWsqF5JppGrqGnvUx5FQQS4sV2bbS2WrlugnDY0vFIbXbvvxuFT9SC+WLTQoxDTZP52PL1mVvrkIFUKtezdw7xlZk86iUs/yHm7bY/UTZ9IqHzSLvdlYjB6W04aecq6kwlP6HVQtBVwJLnQFGkCC5kCsZVQiLMo= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BN8PR18MB2404.namprd18.prod.outlook.com (2603:10b6:408:6e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Mon, 16 May 2022 18:51:45 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9c76:3b01:eb04:db4d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9c76:3b01:eb04:db4d%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 18:51:45 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v2 2/2] cryptodev: add dh padding options Thread-Topic: [EXT] [PATCH v2 2/2] cryptodev: add dh padding options Thread-Index: AQHYT0JnX3ijRljfLkObO5h7TyvsJ60iDTpA Date: Mon, 16 May 2022 18:51:45 +0000 Message-ID: References: <20220413140327.12915-1-arkadiuszx.kusztal@intel.com> <20220413140327.12915-3-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220413140327.12915-3-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11caf4c6-4e46-4e7f-7753-08da376d203f x-ms-traffictypediagnostic: BN8PR18MB2404:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vkkWkC8R8q58Zwt0ofpWjiyz/vZj5tgUa6YWxaLAaeXcEE0qhPTvAalH4lC84rOLZuASOAOk3+y5kmJYx5xt0JHEXDpZoy+M+T/m1PxZCcWjY/UFENXbr4HqEfiQJjz8/L2Pd/Hg64mwjkeQtcfZrxmZGt+eDrcYHNKWS/MZzLeKtg4Ztlb5MTR96Ot5wK3BAHJm4k5/dUUTKNVJ3jpSzoHzpvdtydxA/EXZxuK7TnKujt89JqkTaQ99A5kgc6sSvIMTyYAvYxQIlMZztwqBN4V2UnsOyrO0gVbAaR4qraedR3B6r9k0TvwR4JsvtpK2EkaegMpUfYM1Os1uXxyC38k7MHyHv18jv4wDZ3jixHgA31dPdZdVaHsIfkbjw1X7u+8rV2Q8pDOPDdUeoiS5CrItsv1N3EEnk3i1zhMqAUHgHCeVZ+V/Ji6OOvosHDn3q6kcs4A2gLED17DpUc5RHumkBQNeKkNxfAECChtjMAlbiLMUGh6FKWcGD0iphb0S/4/YLT4SE99EpwuZ7h400+u+31Ar4jS1QIabWhDVMGX/8LnHZmJobjdrZ0c3uXUQxlYqJjDV+bf0nqybWhAhTNw16xp41NboC+Dw2AMK5kAXV+nXNpJ5FCBh4Igq6iQ4ko5LjIH05C2JnW9XynGywgFedfqZmKUkfGI4OhGzyIKaVH2pb8YuGi5GLAR83IWDMB8VHznBdtMxrPcZL7DfzQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(4326008)(55236004)(86362001)(76116006)(83380400001)(33656002)(38100700002)(66476007)(7696005)(2906002)(66446008)(66556008)(508600001)(55016003)(66946007)(38070700005)(71200400001)(64756008)(5660300002)(52536014)(8676002)(8936002)(110136005)(186003)(316002)(9686003)(6506007)(122000001)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pMCX1paTmsrlVIQm00Ut6Zh3wKf+XpPKaqL46Mbkdl2B4zjsiXFGD4YNyyP2?= =?us-ascii?Q?pFuu3cWDZK61DtFatin542BgSny5VxgLVkyovGi9BQNTdZ7lCniIOuBp0J/v?= =?us-ascii?Q?H4qgn/AtZhWdHz6coudqAsivam0bGTJ5HtDbZlwYFaAWn11nfItrbpb0XP8A?= =?us-ascii?Q?9wPUlTfQSGn8LthB1LjLZUsrJYtAH+I0PhBtPRq6TzHDDmCu49XOIjpkJQih?= =?us-ascii?Q?CTxcAi/psK2QwrJ581ZuVipOzUbpXXONiRNCq1xpbibDJlKHBvn5dE5G2s5d?= =?us-ascii?Q?2REWsmBKYJutWSGszElVyM5lDp/7xBQY2zlyjqUp27pSN97OC59vgkApIPfX?= =?us-ascii?Q?gcjW/8j2ppHlsE++eliaC0f1zv8Z8vOuPS/Xty7SezwQLKzkMKdkmh0SpM5Y?= =?us-ascii?Q?8z0QwIPDPcvxcKxlc+Nx6iIgA9wXMeJWcdXggM71yRU8m9haJKtNxmOBUD/q?= =?us-ascii?Q?JJvSOOSCmY0WLd8zE1cAR4jITJs8FvSrIeylz27lO6fWT3WNb5uNA+evDF5X?= =?us-ascii?Q?DYnH9GFqwiOZQ02XErAhRrJSKwGOUlwawsq0g+K4eQikjc004xub49Lck2/x?= =?us-ascii?Q?WVHPyobByMzciu6mq7k1H8A40Tk3HxrDyillgomSBUamCWMA8wA0EG/U1qxy?= =?us-ascii?Q?aM0ZKZpU+D4jpvzdUVI/6nWt8WAJVjpWshe9tynDVoV1rzt8cYdX7QnD14HW?= =?us-ascii?Q?V/Dfe1+7+fzeJVrQC72cxWNAWif/dicUuygPi70RwGxvGjtnqbBVi7SbIDUL?= =?us-ascii?Q?33ChbTRnVzAu5bRPoDLKXmaHyZYeylKeshsC7H+UxW7TMtTTvCFVT8PR0DXz?= =?us-ascii?Q?a5fduhLs/JwgFPcyuKlI6IZJq8dSOZxuWtQTONea2TtwTyhqe3+f4qNcfgh0?= =?us-ascii?Q?Aj84gRuemIeroOL9K1pMoBd5reXmJOjOH2XW3an+gcqMTfrQ1Gj04DvKZMHo?= =?us-ascii?Q?V0pHSDeM5NqaPSmJlVD8vP1tV5DPL5Ej70taN4ikxCDjwBIiBtTkwTrU/Npk?= =?us-ascii?Q?Peb8tgZx1dZpV4sTdDJ2PMv7Du6xhe2TuZTmZIfCcl4DmBweVIX+I152awmg?= =?us-ascii?Q?OhQkco6st7r/ad70SScMfpHVfz2OlU+yGm6E/DBfyFt1FStfgIje35Du376p?= =?us-ascii?Q?1tmYawj3Qo2j68V5m4mHplIykstk1bXtlsvNrE/g7iOs6lTkNCgfpTGjLwMr?= =?us-ascii?Q?qj3G7EWbPKbwTiMyjPjUrNpS0eAibGQIbYyTwv/sZdySx9Ps7Ot+dwKVcOr3?= =?us-ascii?Q?jKLn2+Ou6VNhU8QXtwj/HV1sXKZE15SxAu4AK/MmNuU36SdBrLZ8XRk+Lc4t?= =?us-ascii?Q?PYmvudWlGjlFKj0b1+ZQoAwL4nIdv455FHnN32JgorqamuRbdwOQYsCRgdAa?= =?us-ascii?Q?SEbQv5/LAyu27Ufz2dKyMsDX+QLpBSmPTe9WFi7m3D72l9zmBvBhyfbjJbUn?= =?us-ascii?Q?3lgWxTn8VFuFf2uh15PQyolkXz1pEea4QAAh9DoqVYNeGSt19Zwgksulfcfe?= =?us-ascii?Q?aOUvBLr7Z14n9hOa3yRN4SOe7IwIGG4E/ljXclMIT4MuYamEKjUbJG1PeSG2?= =?us-ascii?Q?9nivrVedSY+UJEa0+aHAjya7hBBSatvdQIuc+I+qwR0cHYZQODBW4CHMBty1?= =?us-ascii?Q?9B2bJ8RZ6T+jRZLHDDODWSvAOtvx/BlRGh6N/APF26xBHqzSwNNkJBp09rsU?= =?us-ascii?Q?FX+kILnZ87y3/uiMxWQtQJwUcJs7z0ajl1aqwAT+Jdoucgr8X1xkCyqwTGbv?= =?us-ascii?Q?yHgOrmA9pw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11caf4c6-4e46-4e7f-7753-08da376d203f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 18:51:45.7714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SqXA/fowz4dBybKCYo+Xc+A1zC4mFE+b7hZ3Ckggl+B9jpCTbgOc1pHafq1Jn/siUG9z+hUga471FgvtgZNPgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2404 X-Proofpoint-ORIG-GUID: -IZeWEGoCutM6rRL2IG6xxl-QuW_K_1Q X-Proofpoint-GUID: -IZeWEGoCutM6rRL2IG6xxl-QuW_K_1Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-16_15,2022-05-16_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Diffie-Hellman padding is used in certain protocols, > in others, leading zero bytes need to be stripped. > Even same protocol may use a different approach - most > glaring example is TLS1.2 - TLS1.3. > To make the user life easier, and to avoid additional copy > on certain occasions, driver should be able to return both. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index c4f4afa07f..e757663e8e 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -440,7 +440,15 @@ struct rte_crypto_dh_op_param { > * Full verification | 0 | steps of point verification (full v= alidation), > * | | otherwise three (partial validation= - default). > *--------------------------------------------------------------------= ------------ > - * Reserved | 1-15 | Reserved > + * | | If set to 1 - public key will be re= turned > + * Public key padding | 1 | without leading zero bytes, otherwi= se it > will be > + * | | padded to the left with zero bytes = (default) > + *--------------------------------------------------------------------= ------------ > + * | | If set to 1 - shared key will be re= turned > + * Shared key padding | 2 | without leading zero bytes, otherwi= se it > will be > + * | | padded to the left with zero bytes = (default) > + *--------------------------------------------------------------------= ------------ > + * Reserved | 3-15 | Reserved > */ Same comment here as patch 1 of the series. Define macros.