From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7995CA0C43; Fri, 15 Oct 2021 19:42:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DBCB40041; Fri, 15 Oct 2021 19:42:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id E20414003C for ; Fri, 15 Oct 2021 19:42:48 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19F8qFdt021015; Fri, 15 Oct 2021 10:42:43 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2174.outbound.protection.outlook.com [104.47.56.174]) by mx0b-0016f401.pphosted.com with ESMTP id 3bq6gt9xvg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Oct 2021 10:42:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jOqISHKvQbwbRX5w57matF3L7V53p2sluIBlV41UIs1wW05e0RcncrCl3SWHfqdAUJ5OyTAB+gimSXjQxCKytk7Mg7FQa4rbwANFfGymQROpasnLk7QwGnR3BG8eBH+KX8z2xxtDAu/c9aQQlNCxlXxmMglKjuRRJDqi0dMZJErdDQ3INcdL1eokFMssD/tCCJDMGS2+NhiR+IVOswOi5Ifdh5Wo+QN/ceF96zVfqyHyPP+F9Q7XSmjk32ydMnHXUabmyOsiSS5dYPtEidpUnkR/mmlVipMp98UzDL+NerCmpcMiy6FnaGUmKNExPRCpV+ZJkbiDJ72Ib96lA6aQWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k9Hep+7m3DvbkZ0WVlxQyw00ZrjXjjdpH7DFD7ZhNrM=; b=hWXCLUFuqd/tYrknABg4JUjaqIyzl0zWilIsK6DxJgT/Xs2OIkJGiU4rMXcNkNwtWSwjYjTTuRYfSDhJEJ2iH7KFyivecp4aq+QRpovD7zipbha9xj9xv27wJuBT7bQmHVo3UMW5PKwxPjRR2f492wTuYEqdEP12M4z7gVrGUI5fYDkuV9/pxnD5M2XM4Mdac4v1j+lQQo3DAuRT5MsxPcipd4O6Ue9bIY5tgRe3Rq3m3Ms6u2Inbh1xrsBiSXy8uWq60ZFDWoIu1JPFzNnnlI50JqUaD58IO9zAfKOkAlg4xK2fqXVWUEg4pKSRz/WMwRFtvlrN8tNS466PqChzyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k9Hep+7m3DvbkZ0WVlxQyw00ZrjXjjdpH7DFD7ZhNrM=; b=eBxYHzM4i7BQL6PLCSp+KbEUBuXa3n8rlxilQLjhc17RVKrW5lLIEzunVm4V+p/NqtAWtd5XFzB5E4YDBRamiy75KshSkmQ3B9lKzZi16kYx4tRzFnL5ApVThxDssiWlgLW7vths4T9S+U534MhiD8mTuYKaJ1IDPXXfUXXv1aE= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4604.namprd18.prod.outlook.com (2603:10b6:303:e3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct 2021 17:42:41 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 17:42:41 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" , "Wang, Haiyue" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" Thread-Topic: [PATCH v2 0/7] crypto/security session framework rework Thread-Index: AQHXwGetv1shlNanEkaGEWDxUt04X6vSX5xQgABbf4CAABT+AIAACUMggAFZ5oCAACF/cA== Date: Fri, 15 Oct 2021 17:42:41 +0000 Message-ID: References: <20210930145014.2476799-1-gakhil@marvell.com> <20211013192222.1582631-1-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da6bfdc4-c415-490d-8919-08d990032fff x-ms-traffictypediagnostic: CO1PR18MB4604: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 76/ze8zQzVubomD5Qzwb8T4ByYYzqT7ls1O1H78WqykgS8MJvk+9DOjuOSIkOL4zP0H70rBdEp4PQWf9t4OxrrxMyiVK/WvbofgIquD6h8B6vg1GAvr+8TKfKKugEZxQJbkWxrtWdJXIDycKf+XLh/TXOA9QAYCnzBVhLF2HBTHh0vzB9p8WTZLFikZ046NX4lRv2eM1/U5uiPLDPlhM6iMWWrznCbHz/tR+BBWqcaKZ2b5H7woqDpcmsq1jO2Rl3d1EC5yXga9PGur99ENGBjvt6CD6WsMR1+N9dWAtuvvX79r8wSYegnDdwpKCKBKsvn23veelNhnads5JScoGxTkrldDby1I71k0U0S10NZlFhiEQNzz5Rff5sNpNqXf5dYU+sMgJkCxxuhKmAENtju+lVJUAlDXxiQgU9cL6ERNw1TwhZSSSZCTld2ZFLsu8pUWROFFCKbb3dbG5tW9OtJ5ckTK+RpTn9aOsYIMla/vQOz+ec2GDUpD3+yZ7hcP/hxhG3utP6KW8MuOHYykfE65sDfKUZzX1U58KnOFSsuLy73gNm81Lnuk3kyi9aDLLGxlSUXExvxegmeM5kileTrHojPWH8U3oYjkyEyCHZ7jnAhXRLcb3ZICGYFSE8QctWwy4NIpfWVzsqhSj/BKoiG1fX6zWV4MfLYfZ8qQAlPjO2mo3O9LsHAKviz4GAaofDZtqU160OTy6+GKDEljVOw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(55236004)(8936002)(4326008)(7696005)(122000001)(66556008)(66946007)(6506007)(2906002)(5660300002)(64756008)(66446008)(9686003)(76116006)(66476007)(71200400001)(508600001)(26005)(86362001)(7416002)(316002)(38100700002)(110136005)(54906003)(33656002)(15650500001)(38070700005)(186003)(8676002)(52536014)(55016002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ggbD/MHNjQQTBSAKEzw1A1SOwLgCIA2LmE3P2up8GGoJKXMqBkhNxl87GXnE?= =?us-ascii?Q?PsKdMjOuMGNEE8mTr1NTOYzK5nE/o5rK1wFj7awiatFJspICN7+stbqINAzv?= =?us-ascii?Q?aK/nHbyuVSJMhgWJttVW2suUJphFAAFJOvKk77wp+j5Hf8xkUJeHBSp2VZsZ?= =?us-ascii?Q?BdMN/fqu2sGCfnHNwudlAjWSr8vfirnoz+JeUtrkW7z7/NUjcsUKbR/f/xAD?= =?us-ascii?Q?5Yf/3cDNVR06ptwxBKObb+U6SD8foqwwARFF9mzHeVBKJpVVHkuTyuZs6UhF?= =?us-ascii?Q?3rXJ9KBlDyu8k7bvrWqIaIeszaM3zJet8hvwG47GpCSkVkGaL2NLiXqS7vXf?= =?us-ascii?Q?ctdgYZOWye+D9miIr3FxnL2bwffQcviOLCeX0pjP+tiBnQ0py2eGo8HIgotO?= =?us-ascii?Q?nNGUBaJw4IrqJDXzQBAZQVEOFjS0L3/+olZTkTJD9muvRq9qChaSgmYLom3D?= =?us-ascii?Q?upel4IlF/SDyaBhAhZ8CDpsYMrhFKXz6LVHPnPyzwm67sPuAvBYkr6ORi7bD?= =?us-ascii?Q?14NtY6y3gFAKfVEw454vEXuMQ34yv/4SgJoLT0noQduct8BHURBM+AbdcTtX?= =?us-ascii?Q?3WH+CERd4fYH3WlAKRgZFt7H/Kxqbd+6W2aFtLSJvn68gt0TOL8B6eDgCy6p?= =?us-ascii?Q?3PIBAf0dslzmNh3WgxC3lF4X8/3kJ5mQqQKMbenOe6ZH0VCZ9duTLEoHsVmr?= =?us-ascii?Q?M2FF3QPP1cEpJvMswMKWPpXJ8fAnD7Ss5q5C2Xr3aq0fRyFBhhPb/KcTgrA1?= =?us-ascii?Q?UkVU9Q+fhcQuslBjauPrQVuG28imMVuYswDbHYznRR2PKKlEeSkdmjwVa1u6?= =?us-ascii?Q?Ea/qKs7Hs8GRUvOdE8y9h5CBQvfrec6dVwn2omvfTOONWXxB+nVmRSAI5Hz1?= =?us-ascii?Q?Ol4s35+4SBsgcQx53uqq9Eq4bls6TzGeHTeYjhzww65rmugjyqK7zR4khHhB?= =?us-ascii?Q?9smqRQcvYWhlsf0MBo0GDT9QPykg3Md7c//UKiS8HLVnJSIt4mnGB197sX6R?= =?us-ascii?Q?yIt4pVcFkaKrFHttg8KfXBQrJ04L7PxtxZdqTwydFWxknAfml3LXyToBeK5L?= =?us-ascii?Q?18sK/JanQRJxB1+Te1zjfLKXsKL9bFAUtTQ9Rwvvre1xTGr16/vb5tox6vWi?= =?us-ascii?Q?knaKLou263QmuiYp2zWnl1XtKo0+EvCXvNpvoMCcnGTB4p/Qn8Td/GlC9NFM?= =?us-ascii?Q?hc78ekSwjsaD0HUFLUbaLjy6UFAy2X1R7WMgqPMgIoC8q2XE8cqm2KQtwj8r?= =?us-ascii?Q?hNtfYJiW3r17bTWxaeczax9UKQtEo0sTpLggPQZuh3ct9bhOPIvljm8M8T0r?= =?us-ascii?Q?4ApJRFSw3nteABSUiRhIXpoQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da6bfdc4-c415-490d-8919-08d990032fff X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 17:42:41.1784 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bPlspoDloCowaBoUPfN/fDaORRXmaQvktIhMeKNPbDgB3kNhccvFcZoMHE5kWqXidLUES3bi86I5rBfpjE9qvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4604 X-Proofpoint-GUID: QbBOSmfUp4IfupPLd9xTaYu8QPeZzPaU X-Proofpoint-ORIG-GUID: QbBOSmfUp4IfupPLd9xTaYu8QPeZzPaU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-15_06,2021-10-14_02,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Hi Akhil, >=20 > I tried to fix the problems of seg faults. > The seg-faults are gone now but all asym tests are failing too. > The reason is the rte_cryptodev_queue_pair_setup() checks the session > mempool same for sym and asym. > Since we don't have a rte_cryptodev_asym_session_pool_create() the > session mempool created by > test_cryptodev_asym.c with rte_mempool_create() will fail the mempool > check when setting up the queue pair. >=20 > If you think my fix may be useful (although not resolving asym issue) I c= an > send it. >=20 Is it a different fix than what I proposed below? If yes, you can send the = diff. I already made the below changes for all the PMDs. I will try to fix the asym issue, but I suppose it can be dealt in the app Which can be fixed separately in RC2. Also, found the root cause of multi process issue, working on making the pa= tches. Will send v3 soon with all 3 issues(docsis/mp/sessless) fixed atleast. For Asym, may send a separate patch. > > Hi Fan, > > Check for below QAT fix also > > > > > > > > Unfortunately the patches still cause seg-fault at QAT and SW PMDs. > > > > > > > > - for qat it fails at rte_security_ops->session_size_get not implem= ented. > > And for this one > > diff --git a/drivers/crypto/qat/qat_sym_pmd.c > > b/drivers/crypto/qat/qat_sym_pmd.c > > index efda921c05..96cd9d2eee 100644 > > --- a/drivers/crypto/qat/qat_sym_pmd.c > > +++ b/drivers/crypto/qat/qat_sym_pmd.c > > @@ -306,6 +306,7 @@ static struct rte_security_ops security_qat_ops =3D= { > > > > .session_create =3D qat_security_session_create, > > .session_update =3D NULL, > > + .session_get_size =3D qat_security_session_get_size, > > .session_stats_get =3D NULL, > > .session_destroy =3D qat_security_session_destroy, > > .set_pkt_metadata =3D NULL, > > diff --git a/drivers/crypto/qat/qat_sym_session.c > > b/drivers/crypto/qat/qat_sym_session.c > > index ef92f22c1a..41b5542343 100644 > > --- a/drivers/crypto/qat/qat_sym_session.c > > +++ b/drivers/crypto/qat/qat_sym_session.c > > @@ -2297,4 +2297,10 @@ qat_security_session_destroy(void *dev > > __rte_unused, void *sess_priv) > > } > > return 0; > > } > > + > > +static unsigned int > > +qat_security_session_get_size(void *device __rte_unused) > > +{ > > + return sizeof(struct qat_sym_session); > > +} > > #endif > > > > > > - for sw pmds the queue pair's session private mempools are not set= . > > > > > > > Can you check if below change works for Kasumi. I will replicate for > others. > > > > > > diff --git a/drivers/crypto/kasumi/kasumi_pmd_private.h > > > b/drivers/crypto/kasumi/kasumi_pmd_private.h > > > index abedcd616d..fe0e78e516 100644 > > > --- a/drivers/crypto/kasumi/kasumi_pmd_private.h > > > +++ b/drivers/crypto/kasumi/kasumi_pmd_private.h > > > @@ -38,8 +38,6 @@ struct kasumi_qp { > > > /**< Ring for placing processed ops */ > > > struct rte_mempool *sess_mp; > > > /**< Session Mempool */ > > > - struct rte_mempool *sess_mp_priv; > > > - /**< Session Private Data Mempool */ > > > struct rte_cryptodev_stats qp_stats; > > > /**< Queue pair statistics */ > > > uint8_t temp_digest[KASUMI_DIGEST_LENGTH]; > > > diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c > > > b/drivers/crypto/kasumi/rte_kasumi_pmd.c > > > index d6f927417a..1fc59c8b8a 100644 > > > --- a/drivers/crypto/kasumi/rte_kasumi_pmd.c > > > +++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c > > > @@ -139,27 +139,24 @@ kasumi_get_session(struct kasumi_qp *qp, > struct > > > rte_crypto_op *op) > > > op->sym->session, > > > cryptodev_driver_id); > > > } else { > > > - void *_sess =3D NULL; > > > - void *_sess_private_data =3D NULL; > > > + struct rte_cryptodev_sym_session *_sess =3D NULL; > > > > > > - if (rte_mempool_get(qp->sess_mp, (void **)&_sess)) > > > + /* Create temporary session */ > > > + _sess =3D rte_cryptodev_sym_session_create(qp->sess_m= p); > > > + if (_sess =3D=3D NULL) > > > return NULL; > > > > > > - if (rte_mempool_get(qp->sess_mp_priv, > > > - (void **)&_sess_private_data)) > > > - return NULL; > > > - > > > - sess =3D (struct kasumi_session *)_sess_private_data; > > > - > > > + _sess->sess_data[cryptodev_driver_id].data =3D > > > + (void *)((uint8_t *)_sess + > > > + rte_cryptodev_sym_get_header_session_= size() + > > > + (cryptodev_driver_id * _sess->priv_sz= )); > > > + sess =3D _sess->sess_data[cryptodev_driver_id].data; > > > if (unlikely(kasumi_set_session_parameters(qp->mgr, s= ess, > > > op->sym->xform) !=3D 0)) { > > > rte_mempool_put(qp->sess_mp, _sess); > > > - rte_mempool_put(qp->sess_mp_priv, _sess_priva= te_data); > > > sess =3D NULL; > > > } > > > op->sym->session =3D (struct rte_cryptodev_sym_sessio= n *)_sess; > > > - set_sym_session_private_data(op->sym->session, > > > - cryptodev_driver_id, _sess_private_da= ta); > > > } > > > > > > if (unlikely(sess =3D=3D NULL)) > > > @@ -327,7 +324,6 @@ process_ops(struct rte_crypto_op **ops, struct > > > kasumi_session *session, > > > memset(ops[i]->sym->session, 0, > > > rte_cryptodev_sym_get_existing_header_session= _size( > > > ops[i]->sym->session)); > > > - rte_mempool_put(qp->sess_mp_priv, session); > > > rte_mempool_put(qp->sess_mp, ops[i]->sym->ses= sion); > > > ops[i]->sym->session =3D NULL; > > > }