From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B011A0C4B; Thu, 14 Oct 2021 20:24:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB8DC40041; Thu, 14 Oct 2021 20:24:00 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id E59904003C for ; Thu, 14 Oct 2021 20:23:58 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19ECiC7p030229; Thu, 14 Oct 2021 11:23:53 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2109.outbound.protection.outlook.com [104.47.55.109]) by mx0b-0016f401.pphosted.com with ESMTP id 3bpjk1a87t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Oct 2021 11:23:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DV7AORgN2zs2mqqcsQvIZq153mGYeSMwnSKW9ot7Ch35r2az8qtOz38UD5xUfwkSi/3fcuSLSncDDN+TCBP0Pzd1gTEAZQFzHthqRmqTGH6I4M9NOqNM2gmgqappWaLh9FaizhQyHMaBJy6hoJFBm8w1dMLJYdefT+Cb1++NwQSM/ubz9sCf4i93nNrBpQ9mc20jiDaFZF9sNvAJEH7fIwTo78jDK7HORtI078ptfnCos1GWnPJxS/JVZRxbin4yoVayhvXIX49NOHHdR6NGbeKzCM0pDokwySDoUJHPtC+xVUkIWuYBd4ozhXsbsNteRmq99J5tNJCzjV9j3LiSuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r+zj7y0PSt7appYrVqcMKPRVIvmiPQ63iYKinytsdFE=; b=mFJ/Wz5PqYoxnuM9FcSHPkLg10LYmG+vSCc58UaTgJd9Sdl3Gexev1+CBpsjdJNfNQ4WE6M1zHOa4CvuJAZ82tua8BdKc2/5TxYOyjLMVipzqlCuCaS5/fhG7ElMO+VQOaTQYTuQOAMK9ljDRyf7u/Ue/PZHliXwDqIw7wQFwsMuR9KGdUVKfulekxd5ObsKy/T5qGSpi9fcWEhKdwBxCLCTcNGN9rfidaCxz39BajSdz4hW9GjIW3d1QfqoLF+58T4IDM1MmIfW9WDV73TgxB/LQZ6/gXLXm+D5HukxbS8LULDjLbHK4aQwUItfGsCEmdhRAsMzWb9SwiMoybhIVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r+zj7y0PSt7appYrVqcMKPRVIvmiPQ63iYKinytsdFE=; b=KC+JKsTcD84M9agnZbYzioRUjsl6aQVgtm57nKa+yT1Sz4av/XC3dY9y5zVLXU3dKjltck39CWtHMqEPnwGabgULCyMr0bYW38HFh403vHNGlNLOWt0ZXfJW62wVIANKnhRlTSL88TeD+B+URWK8YwM6a+t8uT2b+KLxaUZSSXM= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4569.namprd18.prod.outlook.com (2603:10b6:303:fc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 18:23:51 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 18:23:50 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" , "Wang, Haiyue" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" Thread-Topic: [PATCH v2 0/7] crypto/security session framework rework Thread-Index: AQHXwGetv1shlNanEkaGEWDxUt04X6vSX5xQgABbf4CAABT+AA== Date: Thu, 14 Oct 2021 18:23:50 +0000 Message-ID: References: <20210930145014.2476799-1-gakhil@marvell.com> <20211013192222.1582631-1-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4c53a799-43bb-4a79-dd94-08d98f3fc592 x-ms-traffictypediagnostic: CO1PR18MB4569: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FkLOFEgQRglRlNnGAjxfwmwea+52Sd1Ncgjetj9IKvQ679tLG0bxbaEpWo98oTtEVwaXXTdyvbdoJ0EwtgvPTkabKtG966JyUeApNzeVZrcLacO0wdjjgEjZrvIjIOQDsGZbHFzhvU80oLMgauNBkITQTu30PwsUuCVFm2Sceov/g4fKYNghN3D1fUj3H+KLGwE3AHV7EeaD4NRshfJoFAsGcZAGwCOo+ipWniHs1iD3EVxRCxvaQgy/n6as5EqfnlXyDsJ+b+VTWo16L6GoyMNGc2dG05Wd/rcjMDn2dS7g0HO5xVISE5nh8jPeOcfJT9eD2H2cvrtSmxkYIU62C2igoAvRlqKX+cp8T1b3P1frv9EMEC7cFnQWaUMcFiZgFwnzwt2FswByVmfUHENoq4hIWp8kP2DwLprFjzGurLpv4TXzog/0eHun8iTuLb8oyXri8ilNSoWYbAqdgERBP3LMz9BRBKkIwyzHaLEbQ6hVFkKUNxSFURTYERo2J9RE+Hx2aU1YzGUdSwg+zZyEfElNJt/a0jYgfJDDb1OQafGxsK99kuCBF13TEoqnuXW1nYtEcDMijNUlmz/AGkhmtLi0foBW7AhBV86+b5ojtep0JRy9LVXLZp+Xgq8iLCBgsc+4T7mOL5NN68u2tE0kfQvjs9EzXOywVYIJoj0071L/6+sBH42ffWeliMUNWs+F3oAD3S+CbMwTV7ZqZmpfwg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(86362001)(55236004)(9686003)(38070700005)(38100700002)(83380400001)(6506007)(76116006)(66946007)(110136005)(71200400001)(122000001)(7696005)(508600001)(66476007)(8936002)(64756008)(66556008)(55016002)(316002)(2906002)(52536014)(186003)(5660300002)(7416002)(33656002)(66446008)(4326008)(54906003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vIb0OokYu4TCK/XiwxNi9By9KPDttxTZV9QDlouqEnfcf2211h+eWMkyMqr0?= =?us-ascii?Q?al+lqxsTc2yzHtl1WU/iPkpJwqPyN5qgsexCGetZAzL0srBz6jO9fWohxZlx?= =?us-ascii?Q?pmPSxBLIyCtkHDcvDtkyME1IuYM9D/IatLFaoDQAs6MHgw3JqDARED/mWcPq?= =?us-ascii?Q?IJvU9dbA7hH/aFIe8VLWBu4EvnNDlikkdaMCx1XCRJhjdQHKrzCbBHcfZdG1?= =?us-ascii?Q?/ol0UAGckdTDAU4ebKdScGOEVPY93dM6sz2NlS9DpG5aEFJtyLVDTpYsL12J?= =?us-ascii?Q?0g1spVUitQFAWXAqkUaqzWFh6GBIzeIh/GNYAOkOlSzU43hcpKjJL3ucjLp0?= =?us-ascii?Q?Uzr74sktcZmGmWwhs7umZuZbpATkTtdomC35pSlngGshjqvNA0/fUuwb2spc?= =?us-ascii?Q?BXMdzUeq5se27RyuFD0YQZipmf3wAQQWPuGd27T3AXqsql6hIu3aoqOpO/eB?= =?us-ascii?Q?wyKten9r10kOT20lmPxbefkTRrVD6e4Qp+iyeiw8RW+udzI/3ovJ9v3cWRK6?= =?us-ascii?Q?4CdQEcs1lJfgyley501FdDOSPwekCap1Xaqbl7hKhwAmesilwVuPk7u71FwB?= =?us-ascii?Q?BTOIlaP9ID8U1KwG1MKTXdDV/La3zO8FAU7xGg7bJxcjjVjDKrYJE3ikCDcA?= =?us-ascii?Q?7GX/hg5VSh681MUxRKW9+6vH08ZFuBfUZa+KCV3ErjF2VlbTVnqR/GdM5Dhk?= =?us-ascii?Q?+bGbRPEdJYZmytWlM1fT22KjL2xvG16Za2Kj5rzMaYOEJBEKAF0tfyz2jnYN?= =?us-ascii?Q?8gezIbUBW1kr5NsMyM1AmmHsrYxqftN4Ju5/L9TR98nJ0CYzswhgC0/UaZZE?= =?us-ascii?Q?Hb+Agjv2IypEmdQcZJBalNV3BLpuXzU94OrNvIJTCPJVqwSgcQQdqhOoCpw4?= =?us-ascii?Q?x9dPYqRq3QlZqrzZtlSeOxB4PAtsLKkbekNPvoOnQAUc0j/0fZMpsxvYI8KK?= =?us-ascii?Q?43C1G5kd1WBDqdwhBEB0XgAD7ifiuNY0fLVaOkhih2mg+5mQTnxaoxIlh0Jr?= =?us-ascii?Q?PhScTj6vxdwxx0BRLedzj379zA1TwyWX5UPeLlq7xUnCP0ryWvWE3Ejj00Wy?= =?us-ascii?Q?lLAQZ7BHcSPYwqLv8oRhmVhHORDEcXEQRxt1n9hovf5ASnwpcOcuJKdl7J8g?= =?us-ascii?Q?U6KoXERkibZYUIzQ74MGSvlCRINkXxM2n8n3g/xSpL8are3NTIM9+5LJMLWW?= =?us-ascii?Q?zxh9AeraTWzHfhfxw+tViclh/uXlQafeOfcvcRxkn0kKqXVB9CiRpZHz6fpL?= =?us-ascii?Q?RhGmL4WZyVfEYjSoXB8/AOzGfxQj8BGregKJBoQVtXPabyAdg3L3IUc//B2b?= =?us-ascii?Q?Gi4oW+HCUeskh1LiF1PdQpyf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c53a799-43bb-4a79-dd94-08d98f3fc592 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 18:23:50.6768 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uAyQAfzebglK6uJwUKUdiBugF+cAlD3aGOwg7gZsh0fRRS8WhUNQp++JmnDs04v9CACTFE0byxBOG39HOSHQlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4569 X-Proofpoint-ORIG-GUID: tbfwEoYJ-X0U_Ln3dcH86NBJwZ4UnOr3 X-Proofpoint-GUID: tbfwEoYJ-X0U_Ln3dcH86NBJwZ4UnOr3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-14_10,2021-10-14_02,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fan, >=20 > Unfortunately the patches still cause seg-fault at QAT and SW PMDs. >=20 > - for qat it fails at rte_security_ops->session_size_get not implemented. > - for sw pmds the queue pair's session private mempools are not set. >=20 Can you check if below change works for Kasumi. I will replicate for others= . diff --git a/drivers/crypto/kasumi/kasumi_pmd_private.h b/drivers/crypto/ka= sumi/kasumi_pmd_private.h index abedcd616d..fe0e78e516 100644 --- a/drivers/crypto/kasumi/kasumi_pmd_private.h +++ b/drivers/crypto/kasumi/kasumi_pmd_private.h @@ -38,8 +38,6 @@ struct kasumi_qp { /**< Ring for placing processed ops */ struct rte_mempool *sess_mp; /**< Session Mempool */ - struct rte_mempool *sess_mp_priv; - /**< Session Private Data Mempool */ struct rte_cryptodev_stats qp_stats; /**< Queue pair statistics */ uint8_t temp_digest[KASUMI_DIGEST_LENGTH]; diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c b/drivers/crypto/kasumi= /rte_kasumi_pmd.c index d6f927417a..1fc59c8b8a 100644 --- a/drivers/crypto/kasumi/rte_kasumi_pmd.c +++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c @@ -139,27 +139,24 @@ kasumi_get_session(struct kasumi_qp *qp, struct rte_c= rypto_op *op) op->sym->session, cryptodev_driver_id); } else { - void *_sess =3D NULL; - void *_sess_private_data =3D NULL; + struct rte_cryptodev_sym_session *_sess =3D NULL; - if (rte_mempool_get(qp->sess_mp, (void **)&_sess)) + /* Create temporary session */ + _sess =3D rte_cryptodev_sym_session_create(qp->sess_mp); + if (_sess =3D=3D NULL) return NULL; - if (rte_mempool_get(qp->sess_mp_priv, - (void **)&_sess_private_data)) - return NULL; - - sess =3D (struct kasumi_session *)_sess_private_data; - + _sess->sess_data[cryptodev_driver_id].data =3D + (void *)((uint8_t *)_sess + + rte_cryptodev_sym_get_header_session_size()= + + (cryptodev_driver_id * _sess->priv_sz)); + sess =3D _sess->sess_data[cryptodev_driver_id].data; if (unlikely(kasumi_set_session_parameters(qp->mgr, sess, op->sym->xform) !=3D 0)) { rte_mempool_put(qp->sess_mp, _sess); - rte_mempool_put(qp->sess_mp_priv, _sess_private_dat= a); sess =3D NULL; } op->sym->session =3D (struct rte_cryptodev_sym_session *)_s= ess; - set_sym_session_private_data(op->sym->session, - cryptodev_driver_id, _sess_private_data); } if (unlikely(sess =3D=3D NULL)) @@ -327,7 +324,6 @@ process_ops(struct rte_crypto_op **ops, struct kasumi_s= ession *session, memset(ops[i]->sym->session, 0, rte_cryptodev_sym_get_existing_header_session_size( ops[i]->sym->session)); - rte_mempool_put(qp->sess_mp_priv, session); rte_mempool_put(qp->sess_mp, ops[i]->sym->session); ops[i]->sym->session =3D NULL; }