From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73509A00C4; Mon, 14 Nov 2022 13:46:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54A3340150; Mon, 14 Nov 2022 13:46:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0A1D34014F for ; Mon, 14 Nov 2022 13:46:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668429983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mv6zSTxjQDNGazDu5kVQvopw3zMPS0L/18J+OXpi51A=; b=TmO/iZSnRuAO9XmoQVUDYFCuyzemxVNb5ZDPI3sthvXZ77PloPVeNRZAZjJYpBNDzTSBq7 rsV8xBD+Z7b5OSQ6yqs9MFwJ0W1nUbf9n6pitjvZVcV2fvPcvBlXPM+evzNKJ2CymDCIf3 JvuQuC6CGyN7sjcwFJHT0Jpw9OAAONU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-259-QIFvuiBNPt-i-rI1dMWArg-1; Mon, 14 Nov 2022 07:46:22 -0500 X-MC-Unique: QIFvuiBNPt-i-rI1dMWArg-1 Received: by mail-wm1-f72.google.com with SMTP id ay40-20020a05600c1e2800b003cf8aa16377so6710622wmb.7 for ; Mon, 14 Nov 2022 04:46:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Mv6zSTxjQDNGazDu5kVQvopw3zMPS0L/18J+OXpi51A=; b=1wBhdJUK2PikSjVwkx5JFThC1su7vLTfG3s9e6iJnb2ki5yq37HAJ4sm8dnQyLOKb+ XsjZaCEDNZQQQS0raoZEgL5vvhGfXQOOGOJ71iQ/d58SGL8ztVYMtdQfFy5BFbFHaVuU wBdBd6knitjZACKv+GkPF40LdJfiXcvromq9+/OfWFMFTfP6AAu5yZ8T3DuzvdB0ALaI 0CUJo2exkAGGZZhU0nZ8exEjRX+A8+WxjkzZviDsoksbY3qKB/RWUZuT2cPPH+3P9GML pGT1zeUeEgWO18B49jAX9QTw5aqsRyfONXtgcbQ0oLN8E4QITHDZfqCJS/r24CA5pBlF G5Vw== X-Gm-Message-State: ANoB5pku7X4cXG9uaHGIa0SaerArsuvWPHgQvTc5vEJ/6nUIgJUv/K2s 3D82iw0m8C9cGHTmrZIvt4S6U8juOCCUPh2nv46b7BQhRBDGEeTrivBTszMUjoQ772GEiHav0RP hyzo= X-Received: by 2002:adf:e5c2:0:b0:236:6b05:a8be with SMTP id a2-20020adfe5c2000000b002366b05a8bemr7143897wrn.346.1668429981137; Mon, 14 Nov 2022 04:46:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf50tblGcald/XYnT67hxk/DzaoSCHz/kqt6bLN+tvxoxrrM2U8x+KAoOOvcwkIruxXQW7Gu+A== X-Received: by 2002:adf:e5c2:0:b0:236:6b05:a8be with SMTP id a2-20020adfe5c2000000b002366b05a8bemr7143885wrn.346.1668429980882; Mon, 14 Nov 2022 04:46:20 -0800 (PST) Received: from localhost (2a01cb000f483e0055ae3800781b5cbc.ipv6.abo.wanadoo.fr. [2a01:cb00:f48:3e00:55ae:3800:781b:5cbc]) by smtp.gmail.com with ESMTPSA id h5-20020a1ccc05000000b003cf7292c553sm12044310wmb.13.2022.11.14.04.46.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 04:46:19 -0800 (PST) Mime-Version: 1.0 Date: Mon, 14 Nov 2022 13:46:18 +0100 Message-Id: Subject: Re: [PATCH v3] netdev-dpdk: add control plane protection support From: "Robin Jarry" To: "Kevin Traynor" Cc: "Christophe Fontaine" , , "Ori Kam" , X-Mailer: aerc/0.13.0-69-g27efd0890616 References: <20221021145308.141933-1-rjarry@redhat.com> <10a1224e-40f2-b9e1-b522-a271ec122cbe@redhat.com> In-Reply-To: <10a1224e-40f2-b9e1-b522-a271ec122cbe@redhat.com> X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Kevin, Kevin Traynor, Nov 11, 2022 at 19:15: > > + reta_conf_size =3D (dev->reta_size / RTE_ETH_RETA_GROUP_SIZE) > > + * sizeof(struct rte_eth_rss_reta_entry64); > > In dpdk_eth_dev_init, we get reta_size from driver, > > mlx5_ethdev.c > > 333=E2=94=9C> info->reta_size =3D priv->reta_idx_n ? > 334=E2=94=82 priv->reta_idx_n : config->ind_table_max_siz= e; > > (gdb) p priv->reta_idx_n > $5 =3D 1 > (gdb) p config->ind_table_max_size > $6 =3D 512 > > and store: > dev->reta_size =3D info.reta_size; > > Now we use it, > dev->reta_size =3D 1 / RTE_ETH_RETA_GROUP_SIZE (64) > but it results in reta_conf_size =3D 0 > > > + reta_conf =3D xmalloc(reta_conf_size); > > xmalloc only allocates 1 byte (void *p =3D malloc(size ? size : 1);) Hmm indeed this is bad :) Since reworking the RSS fallback I may not have re-tested with CX-5, only with Intel NICs. I am quite surprised of this return value. Could it be an issue with the mlx5 dpdk driver? Thanks for testing!