From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09B54A0093; Tue, 29 Nov 2022 09:19:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A08DE40691; Tue, 29 Nov 2022 09:19:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 69E894067E for ; Tue, 29 Nov 2022 09:19:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669709991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yI3pecodogozFU7IZijdHnOuXq+n3ZGRrCH1hlxVAcY=; b=E0BSpsivXyWTrRt5PtZIKub5ea56Q+rjecFPoBDCfDxSmtAVQjp7vTbfVM6AyqmossDi/9 EQZHezmYyALnCRNyur2vL1As7VccZSAP1sXgs3huhG0btUHbTOkAj+PfBkv02NYSFrF0uw 2C9pKbFUkw98hgL5W0x6iE+YEfMdLPM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-615-7ID6Jt95MA6tm_pNRboVzA-1; Tue, 29 Nov 2022 03:19:50 -0500 X-MC-Unique: 7ID6Jt95MA6tm_pNRboVzA-1 Received: by mail-wr1-f70.google.com with SMTP id d8-20020adf9b88000000b0024207f09827so1998791wrc.20 for ; Tue, 29 Nov 2022 00:19:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yI3pecodogozFU7IZijdHnOuXq+n3ZGRrCH1hlxVAcY=; b=niq37Vl8AtYgc7cLsGPGOt/8fmGeeb9FANFXoGbpyIyStTg3JbKj00j5aak/qE5FNH TQBfrcehEAZ0AVf88h6XNT2m+w6BTHJSs7T0hr05shsVSlfgDi9FirKhhSEqDTykpvw4 kjTwFsv0Z7IhSKYLEbaGTs7Aioe5kMXBzmSqw5Lt2FV6qznwPoScGSEMkcptZPEHHfPn TaG/rW/RnveH7NXRHNbzdDAdUdaY6NDO3Rqa4GXP9Tgke6mkZ8Z6N8iJnxPFtXtlEb6u 1ZUoyr8ChZICiAu1svA2EPF63sDxJ1UiBeUUsgVPyyxjfzBfnj6TxOGKM5PsWpdJAhdU FYCg== X-Gm-Message-State: ANoB5pk1nw8K/UjMzRt5/LMx9PVTYYxNLEuFwMe/xZkR9YLT0M+3nVpg hwsuCnC35+p6kOIhu68T/j0ACOXkMKlk3/8mEqQX0jbmC+ZN/Zu4Wk1dtzYCoE1UuEwT6IZM/rv dh7U= X-Received: by 2002:adf:e609:0:b0:242:ee:fd1 with SMTP id p9-20020adfe609000000b0024200ee0fd1mr14520920wrm.286.1669709989132; Tue, 29 Nov 2022 00:19:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf5dQFia1g5UiopYd8PaabDRe4vggnuY5KlvK9IW34lr3+otAr8CA6IuwxCx6TmYPHfsMXTF/g== X-Received: by 2002:adf:e609:0:b0:242:ee:fd1 with SMTP id p9-20020adfe609000000b0024200ee0fd1mr14520912wrm.286.1669709988969; Tue, 29 Nov 2022 00:19:48 -0800 (PST) Received: from localhost (2a01cb000f483e0055ae3800781b5cbc.ipv6.abo.wanadoo.fr. [2a01:cb00:f48:3e00:55ae:3800:781b:5cbc]) by smtp.gmail.com with ESMTPSA id g6-20020a5d5406000000b00241d2df4960sm12907254wrv.17.2022.11.29.00.19.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 00:19:48 -0800 (PST) Mime-Version: 1.0 Date: Tue, 29 Nov 2022 09:19:47 +0100 Message-Id: Cc: "Bruce Richardson" , "Jerin Jacob" , "Kevin Laatz" , "Konstantin Ananyev" , =?utf-8?q?Mattias_R=C3=B6nnblom?= Subject: Re: [PATCH v2 2/4] eal: allow applications to report their cpu cycles utilization From: "Robin Jarry" To: =?utf-8?q?Morten_Br=C3=B8rup?= , X-Mailer: aerc/0.13.0-98-g2bd46ede9e75 References: <20221123102612.1688865-1-rjarry@redhat.com> <20221128085935.161671-1-rjarry@redhat.com> <20221128085935.161671-3-rjarry@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D87519@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87519@smartserver.smartshare.dk> X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Morten Br=C3=B8rup, Nov 28, 2022 at 11:52: > Consider adding the percentage here, for easy human consumption: > > ", busy cycles %"PRIu64"/%"PRIu64" (%.02f%%)", > busy_cycles, total_cycles, > busy_cycles ? (float)busy_cycles / (float)total_cycles * (float)100); > > On the other hand, it is the average over the total uptime, so the > percentage might only be useful for very few cases. I had thought adding the percentage. But as you said, I'm not sure how this can be of interest. I can add it in v3 if needed. > Same comment about coding convention: > if (lcore_usage_cb !=3D NULL && lcore_usage_cb(... Will fix that in v3. > Looks good to me. > > And we could probably discuss naming forever... "Usage" and > "utilization" are synonyms, but usage is shorter, so let's stick with > that. > > Acked-by: Morten Br=C3=B8rup Thanks. I'll do s/utilization/usage/g for v3.