From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 218144240D; Wed, 18 Jan 2023 15:45:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13602400D6; Wed, 18 Jan 2023 15:45:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4B1224003F for ; Wed, 18 Jan 2023 15:45:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674053122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j7F94Bdt4oZpWSWVyxKhlS0qJODBWyBvfK0Ak+m6Wns=; b=U8diA6UPEUgDiNqaDT/7LuXCPN66LcWDYH9hnkhomid2wnnB0kn46XUU3OqbOdbOqQIGoH DYIxgnksMIl2UcC6mEitDxY0Og1yBL57XGDsEgq7nq72YpSSQS/hv2NGjNVWYN1Hhyn3/B po1YSEMat1X6AqhZHx9ZtsVJvgwGgaU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-146-MhU7jlhLNBGNv2qc2D56rw-1; Wed, 18 Jan 2023 09:45:20 -0500 X-MC-Unique: MhU7jlhLNBGNv2qc2D56rw-1 Received: by mail-wm1-f72.google.com with SMTP id z22-20020a05600c0a1600b003db00dc4b69so1314835wmp.5 for ; Wed, 18 Jan 2023 06:45:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j7F94Bdt4oZpWSWVyxKhlS0qJODBWyBvfK0Ak+m6Wns=; b=J7Afx222hvnyPGwwbq5jErk3gGWxcyLuYm+hP43dAAtmF4wLqAZtrRyX7Z8IIuHokV 0CAoLytUV7ZE7c8uNEdRe6wAivymHGYRkE6JvY0MK5WIPwLSO1/qYbwR3knOaVpUblgS fTJnUIYpygDSSx/aZp5UAwIeVDWHnrNKyMixYS/ktEhXM992+IN7+K47g0GtcEygzRye WbCfcRnm+8i1UU7VNop+XrJmeAcA3UrSdU8+lQ/GE7v3gbx02o6Cex3vOGGMe37o6cV7 HeiV4tGzzRzvK1beDRQzPwiQJmWtZ7tFLvC9PXN0MFa5PxMADxL4azX5f8ZhjocYCToU 68pg== X-Gm-Message-State: AFqh2kozti64Xra1fxpZPVQ8IIiWo+ZpmdVwSxWYIqojQwZSfvi9JuS/ KwfdMRoKrXrxtXDGIDqhBs6PdMCgTknYO3ny9Nxk/lMy3FfD/ZGkSblobxd/ltSMmuLFKSqdcmB 7Cyc= X-Received: by 2002:a05:600c:a4e:b0:3db:14d0:65be with SMTP id c14-20020a05600c0a4e00b003db14d065bemr2168184wmq.34.1674053118712; Wed, 18 Jan 2023 06:45:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXs8hJug2f9eFnL1rrZHyZjpkuaPk6SF6Zuf820kK/cit5+5rkDUA9QFI/RdTTL4cALGTjyeJQ== X-Received: by 2002:a05:600c:a4e:b0:3db:14d0:65be with SMTP id c14-20020a05600c0a4e00b003db14d065bemr2168175wmq.34.1674053118496; Wed, 18 Jan 2023 06:45:18 -0800 (PST) Received: from localhost (2a01cb000f483e0055ae3800781b5cbc.ipv6.abo.wanadoo.fr. [2a01:cb00:f48:3e00:55ae:3800:781b:5cbc]) by smtp.gmail.com with ESMTPSA id d3-20020a05600c34c300b003dab77aa911sm2091150wmq.23.2023.01.18.06.45.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 06:45:17 -0800 (PST) Mime-Version: 1.0 Date: Wed, 18 Jan 2023 15:45:17 +0100 Message-Id: Subject: Re: [PATCH v5 1/4] eal: add lcore info in telemetry From: "Robin Jarry" To: "Kevin Laatz" , Cc: "Tyler Retzlaff" , =?utf-8?q?Morten_Br=C3=B8rup?= X-Mailer: aerc/0.14.0-31-g01280214150a-dirty References: <20221123102612.1688865-1-rjarry@redhat.com> <20221216102109.64142-1-rjarry@redhat.com> <20221216102109.64142-2-rjarry@redhat.com> <50d3c808-c227-2915-3d07-74e8c3c7fab8@intel.com> In-Reply-To: <50d3c808-c227-2915-3d07-74e8c3c7fab8@intel.com> X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Kevin Laatz, Jan 18, 2023 at 10:42: > Hi Robin, > > Thanks for taking the time to work on this. It is a good implementation= =20 > for debug use-cases. > > I have 2 suggestions which would improve the usability of the data: > 1. Could we make the lcore_id paramater on /eal/lcore/info optional?=20 > This would allow users to read info for all lcores in the application at= =20 > once. I don't think it would be a good thing since it would require returning a different data format depending the parameter is specifier or not. Probably adding another endpoint /eal/lcore/info_all that returns a list of /eal/lcore/info (one for every lcore) would be better. > 2. Could we add 2 additional telemetry endpoints? One which returns an=20 > array of busy_cycles values and the other returns an array of=20 > total_cycles values. These arrays could be used in conjunction with the= =20 > /eal/lcore/list endpoint to quickly read the usage related metrics. I've= =20 > included an example diff below [1]. > > We have a use-case beyond debugging in which we read telemetry every few= =20 > milliseconds. From a performance point of view, adding the 2 additional= =20 > endpoints would be very beneficial. If we add /eal/lcore/info_all you would have all this without two additional endpoints. I don't think that calling it every few milliseconds and extracting the {busy,total}_cycles values would be a problem. I can add another patch in the series but I would prefer not changing the format at the last minute. Would that be ok?