From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 544B74241A; Thu, 19 Jan 2023 17:38:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9F8B40223; Thu, 19 Jan 2023 17:38:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 226EA400D5 for ; Thu, 19 Jan 2023 17:38:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674146289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ei8dwpFylN48wb2qjfK6pMua7qdHfy+4K6DIvZ2D0Us=; b=bA5MID4Pxa+tPGqDx1vwLptZTQs7A0kWnl73feLSX6OuZtyhtkN0jyuK/GR2n5gs7e5VtP pf31DY1KhVWz303WlNqN+WRSuNyUylkcrUsGbcTMO/5lR6RInItlncEEcZ/esHGxZnxAoj aQ8pZZ161oDA5PwRNjZrVArkBYY1l+Y= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-410-aO2gUaGmMaeteQHRFGZoAQ-1; Thu, 19 Jan 2023 11:34:43 -0500 X-MC-Unique: aO2gUaGmMaeteQHRFGZoAQ-1 Received: by mail-wr1-f72.google.com with SMTP id h21-20020adfaa95000000b002be47d1d79cso433698wrc.5 for ; Thu, 19 Jan 2023 08:34:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ei8dwpFylN48wb2qjfK6pMua7qdHfy+4K6DIvZ2D0Us=; b=oYvULls5wq4LvX68+iwq5eeuNTvJ8+QWmjnzfntPOYAQ4/Eyo0G0I8UiuHklwdX8XK jP83VVgzG+4jG+nuB8fCqDhG9QQ2WnkwS6YvwSnPxKLiyZ/x8SopaMeogeZESezkwNof p8LwJYm8UqF9WaKX9hxx2kvvIj/UVNSkKp/zkds7bWEtWNshbJYzZWN+Mgr63Iell+cz XWFrnID56HuUXdwqLG7tF6TcobmFv39u6tvW79wcyBPh+vSDZsBi9SSJULcnEzD/c6O1 aH3MEGYWqK//tptr/haWVOu19tdtPV+2A13mrcOz8bwPQ4wx+AcHgRoPrXADpjOkLefj 7tNw== X-Gm-Message-State: AFqh2kpC8lYFcT6eLrptYEoEOy9TfckSko45IZRSeqmBApdzmZJ0GmDF szM3ozwL6T/x9rdQuDjTjVhcKOS3ouxvdGYeaYTaWpP45oW51BoWjHOhsRNElGCLjvifFNCKFY1 ZXms= X-Received: by 2002:a05:600c:3582:b0:3d3:5c21:dd94 with SMTP id p2-20020a05600c358200b003d35c21dd94mr7045852wmq.9.1674146081977; Thu, 19 Jan 2023 08:34:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXvfcRq+AafjtRjk+xiVCGFnDjuEhOghIHvJACqM5PNBkLqia6X9edEqNYm2Qx4fZ8Fwyw2mIQ== X-Received: by 2002:a05:600c:3582:b0:3d3:5c21:dd94 with SMTP id p2-20020a05600c358200b003d35c21dd94mr7045842wmq.9.1674146081776; Thu, 19 Jan 2023 08:34:41 -0800 (PST) Received: from localhost (2a01cb000f483e0055ae3800781b5cbc.ipv6.abo.wanadoo.fr. [2a01:cb00:f48:3e00:55ae:3800:781b:5cbc]) by smtp.gmail.com with ESMTPSA id z4-20020a1cf404000000b003da2932bde0sm6027431wma.23.2023.01.19.08.34.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 08:34:40 -0800 (PST) Mime-Version: 1.0 Date: Thu, 19 Jan 2023 17:34:39 +0100 Message-Id: Cc: "Tyler Retzlaff" , "Kevin Laatz" Subject: Re: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint From: "Robin Jarry" To: =?utf-8?q?Morten_Br=C3=B8rup?= , X-Mailer: aerc/0.14.0-30-g6a278ab48b1c References: <20221123102612.1688865-1-rjarry@redhat.com> <20230119150656.418404-1-rjarry@redhat.com> <20230119150656.418404-6-rjarry@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D87692@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87692@smartserver.smartshare.dk> X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Morten Br=C3=B8rup, Jan 19, 2023 at 17:21: > In the future, the rte_lcore_usage structure may contain more fields, > and some may not be related to the TSC. So consider removing "cycles" > from the description of the telemetry path. > > Don't waste time changing it unless you are providing a new patch > version anyway! Ok, I assume the "cycles" word can be removed later if people add more fields that are not related to cycles in the rte_lcore_usage structure. For now, we only are talking about cycles :)