From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by dpdk.org (Postfix) with ESMTP id 8AAFD4CC0 for ; Fri, 2 Mar 2018 04:18:55 +0100 (CET) Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id 1BBDD4F; Fri, 2 Mar 2018 03:18:54 +0000 (UTC) Received: from G4W9331.americas.hpqcorp.net (16.208.32.117) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 2 Mar 2018 03:18:53 +0000 Received: from G1W8106.americas.hpqcorp.net (16.193.72.61) by G4W9331.americas.hpqcorp.net (16.208.32.117) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 2 Mar 2018 03:18:53 +0000 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (15.241.52.13) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Fri, 2 Mar 2018 03:18:53 +0000 Received: from CS1PR8401MB0949.NAMPRD84.PROD.OUTLOOK.COM (10.169.24.139) by CS1PR8401MB1015.NAMPRD84.PROD.OUTLOOK.COM (10.169.96.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Fri, 2 Mar 2018 03:18:51 +0000 Received: from CS1PR8401MB0949.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c15:8795:23c5:b032]) by CS1PR8401MB0949.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c15:8795:23c5:b032%15]) with mapi id 15.20.0527.022; Fri, 2 Mar 2018 03:18:51 +0000 From: "Roberts, Lee A." To: Stephen Hemminger CC: "ferruh.yigit@intel.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5 Thread-Index: AQHTsbPtCQTITw1rMEmFk2Bdw/VEq6O8FIGAgAAvmcA= Date: Fri, 2 Mar 2018 03:18:51 +0000 Message-ID: References: <1519946435-3574-1-git-send-email-lee.roberts@hpe.com> <20180301161815.6c7771a6@xeon-e3> In-Reply-To: <20180301161815.6c7771a6@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=lee.roberts@hpe.com; x-originating-ip: [209.169.205.175] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CS1PR8401MB1015; 6:b3E69y0kP43vpIztnHVr5F3OxYATEq98c0viRWpp1VGyRC71wrCCiBJeeUSkYSM/Ti9au6ezNUxM6lCmTMNXz2JxuiKqMSQmgdNhYV48CvpBiRtJ5vVnAGw+JmHHbe2JPrpHbkKzFNaX1HeLZRv6JGRWW3bXsgxd2f/8jfKgLJdnvNpLGYGHRTFdfaMpk9sEAVhNkChZ98LEs4ezEOcWaEtzqgkc1nNjLJ1JVVw4KkGliqIVi27yviq9vjfyDayJCGJX5WUfM7bT6iVU5GWv019ZFofisHTwtc8MwWhjQnDyUxXmrDij5QbxTJApZDTT1ZDbpLinqYQZLuJES8ew8oiSANBh/grjmwJ/MZ+MN/ar9WsfdvnpGZ9YLraJDtUX; 5:03SgbEAgATFesm2aZSJh1vPUIubVQXVtygsRY2PThfqbUT5WpKRMzP9pqMidDhPI2YBfHUx26QP9xGfK/6Tvh28ebGDn9exejYKeRpgrzgJslPZSOz1azUFsVCaM26A6d05113Ci6tCZjiwrodEGRNuXwwmGCJ6rMf8cwqpTAwY=; 24:kLoyZAUm5CF8RHHpe8MmiBzdNH0BviG8AvX+HCWBzJKiAO/lhxMfbVR87/LQus3uxMWU4Ij7YnpTqAlx+CIu32BOUuGFIne475HVgl7yhFk=; 7:lFFpCp8tZ36+d2vOHYStiH9UzzjEP0kabJmxU8oiUob82pbDs28pLQDYg74aAHW62M5s+4IfsVymf3pol2IsHdM+z5zakzkjDnKXkbDWHVWwp/suPdd9Pv1pLgOWos+s/3hGcvzfd8HzX4+UggKA7HgEY9x06lSZAL+fxZsNPX9hw8E4NRX4pt/QpDa71GGb6IGYBQjPnda2PA5zk1OGsHIK8c1dKIZUsAWgknUci7JwO2vXkb3TYdx4NUNlNAvP x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d8d9c6c7-6f5d-4a5c-df90-08d57fec5258 x-microsoft-antispam: UriScan:(222181515654134); BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989060)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(8990040)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:CS1PR8401MB1015; x-ms-traffictypediagnostic: CS1PR8401MB1015: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(222181515654134)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231220)(944501161)(52105095)(10201501046)(3002001)(6055026)(6041288)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CS1PR8401MB1015; BCL:0; PCL:0; RULEID:; SRVR:CS1PR8401MB1015; x-forefront-prvs: 05991796DF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39380400002)(376002)(39860400002)(346002)(396003)(366004)(189003)(199004)(13464003)(81156014)(81166006)(478600001)(66066001)(3660700001)(99286004)(97736004)(7736002)(74316002)(4326008)(5660300001)(575784001)(305945005)(54906003)(316002)(53546011)(53936002)(6506007)(105586002)(76176011)(3280700002)(86362001)(55016002)(6246003)(7696005)(6436002)(106356001)(25786009)(14454004)(9686003)(6116002)(5250100002)(8676002)(3846002)(8936002)(2906002)(68736007)(2900100001)(229853002)(186003)(6916009)(2950100002)(102836004)(33656002)(26005); DIR:OUT; SFP:1102; SCL:1; SRVR:CS1PR8401MB1015; H:CS1PR8401MB0949.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: MPAMOQZEEATxgbeG5iObZW4re1Uh0ZBY1AoZ9aPz1GKhNgO3EH2oysHTOk+uvFv7Zs6m8Sx34WhrPT11jLpDNVjdsuVFaJIKE4pZB7VSIVHF+F4MlufK4v3oSyjbwgH3J4cFZtNg9H/9zX+ZGjLv/uKQOOic/p7+0E3Z3ZRNhOQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d8d9c6c7-6f5d-4a5c-df90-08d57fec5258 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2018 03:18:51.1796 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1015 X-OriginatorOrg: hpe.com Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 03:18:55 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, March 01, 2018 5:18 PM > To: Roberts, Lee A. > Cc: ferruh.yigit@intel.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5 >=20 > On Thu, 1 Mar 2018 16:20:35 -0700 > Lee Roberts wrote: >=20 > > Fix kni compilation under RHEL 7.5. > > > > Signed-off-by: Lee Roberts > > --- > > lib/librte_eal/linuxapp/kni/compat.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linu= xapp/kni/compat.h > > index 3f8c0bc..6a6968d 100644 > > --- a/lib/librte_eal/linuxapp/kni/compat.h > > +++ b/lib/librte_eal/linuxapp/kni/compat.h > > @@ -101,6 +101,11 @@ > > #undef NET_NAME_UNKNOWN > > #endif > > > > +#if (defined(RHEL_RELEASE_CODE) && \ > > + (RHEL_RELEASE_CODE >=3D RHEL_RELEASE_VERSION(7, 5))) > > +#define ndo_change_mtu ndo_change_mtu_rh74 > > +#endif > > + > > #if LINUX_VERSION_CODE >=3D KERNEL_VERSION(4, 11, 0) > > #define HAVE_SIGNAL_FUNCTIONS_OWN_HEADER > > #endif >=20 > Do we really want upstream DPDK trying to track every vendor kernel compa= tibility wart? > Should Redhat be owning this in their own DPDK package? If I look at the first few lines of ../lib/librte_eal/linuxapp/kni/compat.h= , it appears that tracking changes in RHEL and SLES is certainly part of the purpose of this file: 1 /* 2 * Minimal wrappers to allow compiling kni on older kernels. 3 */ 4=20 5 #include 6=20 7 #ifndef RHEL_RELEASE_VERSION 8 #define RHEL_RELEASE_VERSION(a, b) (((a) << 8) + (b)) 9 #endif 10=20 11 /* SuSE version macro is the same as Linux kernel version */ 12 #ifndef SLE_VERSION 13 #define SLE_VERSION(a, b, c) KERNEL_VERSION(a, b, c) 14 #endif 15 #ifdef CONFIG_SUSE_KERNEL If you want to remove the vendor dependency, I'd suggest the following acti= ons: 1) Submit a patch to remove the RHEL- and SLES-specific code. 2) Disable KNI by default in the build system. - Lee