From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8AC843198; Wed, 18 Oct 2023 11:18:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D10374068A; Wed, 18 Oct 2023 11:18:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4DBCE40151 for ; Wed, 18 Oct 2023 11:18:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697620699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lJq7es5hV3GX/hlyUMwWo4A3BFG3ATcFMGfE2/buj7g=; b=c9TR6FZmFNAf2Adv9Ss2jJW9xo5LLRVr0CXmc96v9D6EofDobdcby/QMdf6bFYu4K3lwNG JHkt0ppZExRfySHu9qdfMuROdPSttSwidckpexcmNwkzumVYZimojW9+p1xNL8U8LyTn49 wXAkIhT7AdmmrhDoedR8xg1QGjhQpnY= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-vQhq3PN9OuKTC87JmLd1hw-1; Wed, 18 Oct 2023 05:18:18 -0400 X-MC-Unique: vQhq3PN9OuKTC87JmLd1hw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5079641031aso5902215e87.1 for ; Wed, 18 Oct 2023 02:18:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697620697; x=1698225497; h=in-reply-to:references:to:from:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lJq7es5hV3GX/hlyUMwWo4A3BFG3ATcFMGfE2/buj7g=; b=mXqr3ApYVG+DS+GtOj3wI044wAEGl2OeE4gh8YkzDl/Y2NKLC9LwmWeGqkt63CozXL hjk9q1NRQSyRaAK5bu5Yx9Cc/pJlRzmlPAVDOjPPeKfdsfkoVcJiRnKrxQxyRLPbK7a9 towZaGfCt9+XHRNCPTcUx5kMt1P7dVnzHkchPld47bNmwu51hAqj+e1EojZ4rfaNb3Nv 2BSoK8FEldNmo96PXhiQUZE6O7pe8bDQSH7F7ceNmKNgsw+FiWlzAEL/S10O1O+/bep/ L2dUyFwkjRdQD+VYzJb/n3ETl00qzr5Oo9+IYeiqE5dkm7e/OBax8eTKhm3Jqe5IAZ6M 5btg== X-Gm-Message-State: AOJu0YyBkaN54sumdaTOR72ZXj8GifAAhKCRiLosaa873d69wJxWElzx wIO8PDhgr0S8vz4/ulmV0Un2v8gYB6f8yeLFKN0T5BfUdyO9/3SnKgQXlgvIScaT7WM7Ha9WJLz ooU4= X-Received: by 2002:a05:6512:b95:b0:503:19d8:8dc3 with SMTP id b21-20020a0565120b9500b0050319d88dc3mr4329764lfv.31.1697620697168; Wed, 18 Oct 2023 02:18:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcA1TQdcmdc4PhyE3cfLKIRQIVpmOwr33iLFJayl3SgWoIVISF5EP20FsYVDSd/PmIkSDZoA== X-Received: by 2002:a05:6512:b95:b0:503:19d8:8dc3 with SMTP id b21-20020a0565120b9500b0050319d88dc3mr4329739lfv.31.1697620696772; Wed, 18 Oct 2023 02:18:16 -0700 (PDT) Received: from localhost (2a01cb000f8b9700598da2e1679e8383.ipv6.abo.wanadoo.fr. [2a01:cb00:f8b:9700:598d:a2e1:679e:8383]) by smtp.gmail.com with ESMTPSA id d1-20020adff841000000b003253523d767sm1648070wrq.109.2023.10.18.02.18.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 02:18:16 -0700 (PDT) Mime-Version: 1.0 Date: Wed, 18 Oct 2023 11:18:15 +0200 Message-Id: Subject: Re: [EXT] Re: [PATCH v2 1/1] usertools/rss: add CNXK RSS key Cc: "dev@dpdk.org" , "Jerin Jacob" From: "Robin Jarry" To: "Thomas Monjalon" , "Sunil Kumar Kori" X-Mailer: aerc/0.16.0-34-gdce5c101b12b References: <20231009163033.1095213-1-skori@marvell.com> <1741122.jNaZZp9DzI@thomas> In-Reply-To: <1741122.jNaZZp9DzI@thomas> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thomas Monjalon, Oct 18, 2023 at 11:14: > 18/10/2023 09:26, Sunil Kumar Kori: > > From: Robin Jarry > > > From: Sunil Kumar Kori > > > > > > > > This patch adds RSS key for CNXK platforms. CNXK platform uses > > > > 48 bytes long key for hash calculations. > > > > > > > > For the same patch also updates help mesaages to provide range > > > > information for supporting NICs/platforms. > > > > > > > > Also CNXK uses reta size as 64 so to get correct offset to retrieve > > > > queue index, user must pass reta_size option as 64 i.e. -t 64. > > >=20 > > > I think we should add some driver abstraction that contains the requi= red key > > > length and default reta size. Instead of requiring the user to guess = the correct > > > values. Is that something you could do? > > >=20 > > Okay but in either case i.e. -t option or driver abstraction, user must= know the reta size and key size before configuring. > > So I am not sure that how adding driver abstraction will help to solve= this issue unless/until its documented somewhere. > > You can start with an option to get the size printed, depending on driver= name. > > > So for current release, I am planning to go this version as it is becau= se we are close. > > Later on we can think of it and add required support.=20 > > Please provide input on it. > > Please provide a more user friendly experience in this release. I could have a shot at it since it may involve some refactoring. Also,=20 existing supported drivers will benefit from it. This does not seem like=20 it is directly related to CNXK.