From: "Robin Jarry" <rjarry@redhat.com>
To: "Ruifeng Wang" <ruifeng.wang@arm.com>,
"Kevin Laatz" <kevin.laatz@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Cc: <dev@dpdk.org>, <honnappa.nagarahalli@arm.com>, <nd@arm.com>,
<stable@dpdk.org>
Subject: Re: [PATCH] eal: stop iteration after lcore info is processed
Date: Thu, 02 Nov 2023 10:57:12 +0100 [thread overview]
Message-ID: <CWO8J9034SRG.D48SA1OBXPCO@redhat.com> (raw)
In-Reply-To: <20231101072053.1319697-1-ruifeng.wang@arm.com>
Ruifeng Wang, Nov 01, 2023 at 08:20:
> Telemetry iterates on lcore ID to collect info of a specific lcore.
> Since only one lcore is processed at a time, the iteration can stop
> when a matching lcore is found.
>
> Fixes: f2b852d909f9 ("eal: add lcore info in telemetry")
> Cc: rjarry@redhat.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> lib/eal/common/eal_common_lcore.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c
> index ceda714ca5..0d6812ec75 100644
> --- a/lib/eal/common/eal_common_lcore.c
> +++ b/lib/eal/common/eal_common_lcore.c
> @@ -546,7 +546,8 @@ lcore_telemetry_info_cb(unsigned int lcore_id, void *arg)
> rte_tel_data_add_dict_uint(info->d, "busy_cycles", usage.busy_cycles);
> }
>
> - return 0;
> + /* Return non-zero positive value to stop iterating over lcore_id. */
> + return 1;
> }
Hi Ruifeng, Nice catch.
Reviewed-by: Robin Jarry <rjarry@redhat.com>
prev parent reply other threads:[~2023-11-02 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 7:20 Ruifeng Wang
2023-11-01 18:13 ` Stephen Hemminger
2023-11-06 17:04 ` Thomas Monjalon
2023-11-02 9:57 ` Robin Jarry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CWO8J9034SRG.D48SA1OBXPCO@redhat.com \
--to=rjarry@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=kevin.laatz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).