From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0057.outbound.protection.outlook.com [104.47.41.57]) by dpdk.org (Postfix) with ESMTP id B6D4E106A for ; Fri, 16 Sep 2016 17:21:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PUH3ezz2Yck/aJfG4J8H+2MKymeKPY28ZDw/RUWDNvo=; b=MLQkAt30jwaHSrCDb4yhkU32wRbO1PQQqy9tXpItKy1HOkeZoJ06+GlCuQbYpqlTdypCBuKFI1RJUEC9qo3Ntyz6dNgPEkW0UHU9C/SRGXzL9ds9QQIgwfxfcZC8GW1bWu2Q68PVyLW+AzgYU7rBWNjtVdnHdaJOqwOBQFiKvPI= Received: from CY1PR03MB1440.namprd03.prod.outlook.com (10.163.17.15) by CY1PR03MB1438.namprd03.prod.outlook.com (10.163.17.148) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.629.8; Fri, 16 Sep 2016 15:21:06 +0000 Received: from CY1PR03MB1440.namprd03.prod.outlook.com ([10.163.17.15]) by CY1PR03MB1440.namprd03.prod.outlook.com ([10.163.17.15]) with mapi id 15.01.0619.012; Fri, 16 Sep 2016 15:21:06 +0000 From: Karmarkar Suyash To: "Pattan, Reshma" CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "rsanford@akamai.com" Thread-Topic: [PATCH v1]:rte_timer:timer lag issue correction Thread-Index: AQHR/52bfWjFfLhSjESL+N9O2PTYl6BgiYkAgBkQb3CAAM2hgIAB8gZQ Date: Fri, 16 Sep 2016 15:21:05 +0000 Message-ID: References: <20160826132701.18428-1-skarmarkar@sonusnet.com> <3AEA2BF9852C6F48A459DA490692831F01098625@IRSMSX109.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F01098625@IRSMSX109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=skarmarkar@sonusnet.com; x-originating-ip: [208.45.178.4] x-ms-office365-filtering-correlation-id: 963d6ec6-4bda-4e2c-69c3-08d3de451413 x-microsoft-exchange-diagnostics: 1; CY1PR03MB1438; 6:SqpukJFwdxvCnHtlST/LRtPM0hh5xSHw1U8KMkZ+Rv7iorQGv7SsNYGyK387rtxj4PGC+IIgX1DeKC5E/A265RNclXEqybX6fWIJ5Qce1OGrfudpa2wJJ7n8M6qMCi5ydLnOvmQ3k0sdx3OBJFzSHOEi1vo+hgabYr6/nvM+0wWRcz4FzZCxJJVyHTfbJoKsK1C2fGgzW+Fjpdd9Yie8C+9Fus1xTh7kZFX3Pfv2ec2BE7pOxdavgB2qxy4MuTqEw3wXn/E7WY+7o7Kg/fXmncL7asAxfxn4aYkcleSaKdE=; 5:9SR+Zg40d0+HdMqR7lVoJg6VDiDXoRaIhip45x7wcJVmJh9P6BjQIe/4lYClI87J82113WGWH1wUlipRUaRuRKNMISSFzPmDBFdPzl5uTPnZeKU3QaZZKRe628+81/1QCQuP0clJwIBInlMf1Bm0ww==; 24:jz8j7skHRSeShkO36xsuq7MCG2O5xIkstSluOqLNWPE1jnaovnr3wxfjbGxirxwOOVLuzc6mSOdyQfe+AdJyJ/4Jy9Qne6B5DKM0mEc9m2g=; 7:e4LpgzDeZXXl36fLAopb0Gsw3d9vUb4eEo0kdeJJSot1u6ziPW+zIBnuW9aOcWojNhpxybFuTpLIHA2zhS8nlmiUy9zHonVLg7YtRw00w+cndRO97iUFzpePPlKiKdkB4P/q9rJ4HKQgqDbyIVZDPfkVVvzlNDm/oRzkW6g4m8HVcSYkyShnuK+YCavA5aEGFgvEYJkVDjkr2uUjrmaGKIAK8ggizRqhTDVsb6PYnCESNG6RJdV2XrIdSIptaMJm x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1438; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:CY1PR03MB1438; BCL:0; PCL:0; RULEID:; SRVR:CY1PR03MB1438; x-forefront-prvs: 0067A8BA2A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(189002)(199003)(13464003)(377454003)(5002640100001)(33656002)(5660300001)(11100500001)(7696004)(2900100001)(77096005)(122556002)(3280700002)(54356999)(8676002)(50986999)(76176999)(92566002)(74316002)(3660700001)(106116001)(9686002)(81156014)(105586002)(10400500002)(76576001)(305945005)(81166006)(99286002)(7846002)(97736004)(7736002)(8936002)(87936001)(19580395003)(19580405001)(102836003)(189998001)(3846002)(586003)(4326007)(66066001)(2906002)(68736007)(101416001)(6116002)(86362001)(106356001)(110136003)(2950100001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB1438; H:CY1PR03MB1440.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2016 15:21:05.8076 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1438 Subject: Re: [dpdk-dev] [PATCH v1]:rte_timer:timer lag issue correction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 15:21:08 -0000 Thanks Reshma for the comments, the issue is a day one bug. I will correct= the fixes line and submit v2 of the patch.=20 -----Original Message----- From: Pattan, Reshma [mailto:reshma.pattan@intel.com]=20 Sent: Thursday, September 15, 2016 5:28 AM To: Karmarkar Suyash Cc: dev@dpdk.org; thomas.monjalon@6wind.com; rsanford@akamai.com Subject: RE: [PATCH v1]:rte_timer:timer lag issue correction Hi, >=20 > For Periodic timers ,if the lag gets introduced, the current code=20 > added additional delay when the next peridoc timer was initialized by=20 > not taking into account the delay added, with this fix the code would=20 > start the next occurrence of timer keeping in account the lag added.Corre= cted the behavior. >=20 > Fixes:rte_timer: timer lag issue Fixes line format is not corerct. Fixes line should contain commit hash th= at introduced the bug and its subject line. For your case below should be a= dded. Fixes: 9b15ba89 ("timer: use a skip list") Thanks, Reshma