From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0048.outbound.protection.outlook.com [104.47.41.48]) by dpdk.org (Postfix) with ESMTP id B35019E3 for ; Fri, 28 Apr 2017 08:03:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7F7NNxnfVIQ4999KArC+zH+LZi+7QRDXokVSfzL80aA=; b=iw4M2SqN+cydoPhonAKnK+u4uiD88LaNMib0cxVMzLz1eOHzTw62HsZSwjWwcjIG94LC0lQn0AuQcD+Wc+a2xTsJkgv/BM+toKpV2nZlbZvLAoFx8hJvqOfjwBmCX5ig+EXXjI05GvapEDLS1Pn201QPKzMYaeUr41v1oNzn46s= Received: from CY1PR07MB2428.namprd07.prod.outlook.com (10.166.195.17) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Fri, 28 Apr 2017 06:03:49 +0000 Received: from CY1PR07MB2428.namprd07.prod.outlook.com ([10.166.195.17]) by CY1PR07MB2428.namprd07.prod.outlook.com ([10.166.195.17]) with mapi id 15.01.1047.021; Fri, 28 Apr 2017 06:03:47 +0000 From: "Sekhar, Ashwin" To: Jianbo Liu CC: "thomas@monjalon.net" , "cristian.dumitrescu@intel.com" , "Jacob, Jerin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] sched: enable neon optimizations Thread-Index: AQHSv1ZGFYt9DbzSq0y2Iu/YvIyzwQ== Date: Fri, 28 Apr 2017 06:03:47 +0000 Message-ID: References: <20170427130007.33210-1-ashwin.sekhar@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=cavium.com; x-originating-ip: [111.93.218.67] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1716; 7:WDIdUNcZJfD8PSYC3dAZPgLNiocGTUBePM0VJ6z4OG42VhxlesXIznHOujLFILchrhKl7bwL2QzwXAMt+P09GWof8bEop/9yDb6iayt6MoM8A1fLdjr4kE+wHKWrRbi+OLbcY2oCSOS0OvSF+JnbG18bPxUv6B/Vp4wRqIlr0SgBoAHulGDbjfI4iRIhssAyEnJDgF/0gjauiydBeU9Hty1MmFW1t9ciLn3E7luWlabJjEjhsg5LadVtfoXBmOKOdYDcg7TB2lhWfYoU90nGvcDb2w0U1NkTSUiRsEv6dh5cHgasrqquFRSaCvHh+TWRrxjIMYFRiOWL24uK1ySXBw== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39410400002)(39450400003)(39840400002)(24454002)(377454003)(2900100001)(66066001)(81166006)(8676002)(8936002)(305945005)(7736002)(74316002)(76176999)(54356999)(102836003)(3846002)(93886004)(122556002)(33656002)(50986999)(6116002)(86362001)(53936002)(2906002)(55016002)(54906002)(99286003)(110136004)(5660300001)(38730400002)(9686003)(6436002)(6506006)(6246003)(6916009)(53546009)(189998001)(229853002)(77096006)(7696004)(3660700001)(3280700002)(4326008)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:CY1PR07MB2428.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; x-ms-office365-filtering-correlation-id: 699c7f70-7a35-4be9-cc23-08d48dfc55aa x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BLUPR0701MB1716; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123562025)(20161123564025)(6072148); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; x-forefront-prvs: 029174C036 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2017 06:03:47.1511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Subject: Re: [dpdk-dev] [PATCH] sched: enable neon optimizations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 06:03:52 -0000 On Friday 28 April 2017 11:07 AM, Jianbo Liu wrote:=0A= > On 28 April 2017 at 13:27, Sekhar, Ashwin wrot= e:=0A= >> On Friday 28 April 2017 09:20 AM, Jianbo Liu wrote:=0A= >>> On 27 April 2017 at 21:00, Ashwin Sekhar T K=0A= >>> wrote:=0A= >>>> * Enabled CONFIG_RTE_SCHED_VECTOR for arm64=0A= >>>> * Verified the changes with sched_autotest unit test case=0A= >>>>=0A= >>>> Signed-off-by: Ashwin Sekhar T K =0A= >>>> ---=0A= >>>> config/defconfig_arm64-armv8a-linuxapp-gcc | 2 +-=0A= >>>> lib/librte_sched/rte_sched.c | 22 +++++++++++++++++++++= +=0A= >>>> 2 files changed, 23 insertions(+), 1 deletion(-)=0A= >>>>=0A= >>>> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defco= nfig_arm64-armv8a-linuxapp-gcc=0A= >>>> index 65888ce..021044a 100644=0A= >>>> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc=0A= >>>> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc=0A= >>>> @@ -48,4 +48,4 @@ CONFIG_RTE_LIBRTE_FM10K_PMD=3Dn=0A= >>>> CONFIG_RTE_LIBRTE_SFC_EFX_PMD=3Dn=0A= >>>> CONFIG_RTE_LIBRTE_AVP_PMD=3Dn=0A= >>>>=0A= >>>> -CONFIG_RTE_SCHED_VECTOR=3Dn=0A= >>>> +CONFIG_RTE_SCHED_VECTOR=3Dy=0A= >>>=0A= >>> It's enough to remove this line only, I don't think you must enable it= =0A= >>> explicitly in the armv8a common config.=0A= >>>=0A= >> Tried removing this line from armv8a config. But in that case=0A= >> RTE_SCHED_VECTOR doesn't get defined.=0A= >> ./config/common_base has "CONFIG_RTE_SCHED_VECTOR=3Dn" as the default=0A= >> setting. So enabling explicitly is required.=0A= >>=0A= >=0A= > I know it must be enabled to use your enhancement. But I meant to keep=0A= > the same as common_base (or other default configs) if there is no=0A= > other strange reason to enable it.=0A= >=0A= > Thanks!=0A= > Jianbo=0A= >=0A= Got it. Will update the patch removing CONFIG_RTE_SCHED_VECTOR=3Dn from =0A= defconfig_arm64-armv8a-linuxapp-gcc and resend.=0A= Thanks=0A= Ashwin=0A= =0A=