From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0066.outbound.protection.outlook.com [104.47.37.66]) by dpdk.org (Postfix) with ESMTP id CAF3D1B45F for ; Wed, 20 Jun 2018 08:32:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EAYOZpgLB60m2OFrmLssV1SymtnOgWWlTU1SzK/gVIk=; b=gcoR6v4ZHCg2CDx+xCoOWDnHZm++OmQbBVVg4dLgjVyxoH3mr+3ffXhBaahhO0HFfY7GU//vHWkNp0ZcoakYXebS7wz/eLT/OdrPk82658Aa4mXcNriTDjQJYQrVO09fw01owMWgqHkzA4HkAcoZeEz8meas1MAGlr60Ajz0doM= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3667.namprd07.prod.outlook.com (52.132.102.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Wed, 20 Jun 2018 06:32:32 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%2]) with mapi id 15.20.0863.016; Wed, 20 Jun 2018 06:32:31 +0000 From: "Verma, Shally" To: "Jacob, Jerin" CC: "pablo.de.lara.guarch@intel.com" , "fiona.trahe@intel.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" Thread-Topic: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support Thread-Index: AQHUAKc+QWxyxLR4F0OsLduANEdL6qRovcPw Date: Wed, 20 Jun 2018 06:32:31 +0000 Message-ID: References: <1528194913-25893-1-git-send-email-shally.verma@caviumnetworks.com> <1528194913-25893-2-git-send-email-shally.verma@caviumnetworks.com> <20180610103838.GA5152@jerin> In-Reply-To: <20180610103838.GA5152@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3667; 7:fcMAnr40tMGzs3h6QCtw8bVqw7KzXEz9F4swFjFTiyV8khYtgjrOKdyB27CHTBLORIJBowrCdXvetKu2MRKHVJpJ4QJicZ7+jgMwNE8TfvwGVyhYzBoh7Bk4H52EmEql+lCkxR/nfSLlm7pquT3Xm1Mo1D7BGa3aGSp0D1cdtCGSX6iH8tQfDXQ1QTNCF+BdWpstVjqycCEcnlRbYIx90ePisAnvoxFoRls66m9msx0sbUFeuSCZdubtmSKztbm5 x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(979002)(39860400002)(39380400002)(376002)(396003)(346002)(366004)(189003)(199004)(13464003)(6246003)(6116002)(3846002)(229853002)(54906003)(5660300001)(316002)(2906002)(99286004)(6862004)(53936002)(106356001)(107886003)(4326008)(105586002)(66066001)(68736007)(97736004)(2900100001)(486006)(476003)(72206003)(25786009)(6636002)(14454004)(8936002)(55016002)(8676002)(59450400001)(6506007)(478600001)(3280700002)(33656002)(5250100002)(11346002)(74316002)(305945005)(3660700001)(7736002)(446003)(6436002)(81156014)(102836004)(9686003)(81166006)(86362001)(575784001)(76176011)(7696005)(26005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3667; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: ddcc524d-8762-4d5e-42c4-08d5d67799f3 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3667; x-ms-traffictypediagnostic: CY4PR0701MB3667: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3667; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3667; x-forefront-prvs: 070912876F received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: EM4YSmfTU0yOs7uqe2HNdhgznj+jqj+WS3RCaveU4RZ1WiOvQJnRtkPZfN/+mT+8u7V/pzXTHv7QunW1QjF1zsK6wjST0OkdFIaGMPfLiAV3L2jkleitXGXUD152hWWfT/+E5ZCXK4XkGeroJkGnxvUNwzZZit0ZXqNwFr1JW8xCvlP/tvUg1fDRRqYvIWC+Lw9Ju8C++SuTZJgq86tny8y3EJyuGyYDqnzLiUfJerQ+i35DoqtTUU62tf2ixnUEHyUBq3055rMJ4YhNJK699JtFJAZcar1tX99yKV95mVluXPFBMPh60lmdmXiLqk1h3t27sqkfK7qJjQ1Q3vsdzw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddcc524d-8762-4d5e-42c4-08d5d67799f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2018 06:32:31.2289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3667 Subject: Re: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 06:32:34 -0000 Hi Jerin >-----Original Message----- >From: Jacob, Jerin >Sent: 10 June 2018 16:09 >To: Verma, Shally >Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com; dev@dpdk.org; A= threya, Narayana Prasad >; Challa, Mahipal ; Gupta, Ashish >; Sahu, Sunila >Subject: Re: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip= PMD support > >-----Original Message----- >> Date: Tue, 5 Jun 2018 16:05:07 +0530 >> From: Shally Verma >> To: pablo.de.lara.guarch@intel.com >> CC: fiona.trahe@intel.com, dev@dpdk.org, pathreya@caviumnetworks.com, >> mchalla@caviumnetworks.com, Ashish Gupta >> , Sunila Sahu >> >> Subject: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip P= MD >> support >> X-Mailer: git-send-email 1.9.1 >> >> Add octeontx zip pmd support in compressdev driver. >> Add device probe and remove support. >> Update makefile to build octeontx zip pmd >> >> Signed-off-by: Ashish Gupta >> Signed-off-by: Shally Verma >> Signed-off-by: Sunila Sahu >> --- >> config/common_base | 6 + >> drivers/compress/Makefile | 2 +- >> drivers/compress/octeontx/Makefile | 33 ++++++ >> drivers/compress/octeontx/meson.build | 10 ++ >> .../octeontx/rte_pmd_octeontx_compress_version.map | 3 + >> drivers/compress/octeontx/zip_pmd.c | 129 ++++++++++++++= +++++++ >> drivers/compress/octeontx/zipvf.c | 48 ++++++++ >> drivers/compress/octeontx/zipvf.h | 47 ++++++++ >> usertools/dpdk-devbind.py | 9 ++ >> 9 files changed, 286 insertions(+), 1 deletion(-) >> >> diff --git a/config/common_base b/config/common_base >> index 6b0d1cbbb..e56d14b7f 100644 >> --- a/config/common_base >> +++ b/config/common_base >> @@ -584,6 +584,12 @@ CONFIG_RTE_COMPRESS_MAX_DEVS=3D64 >> # >> CONFIG_RTE_COMPRESSDEV_TEST=3Dn >> >> +# >> +# Compile PMD for Octeontx ZIPVF compression device >> +# >> +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF=3Dn > >Please enable this option by default, If there are arm64 specific >usage then please stub it out so that it can compile on >all architectures. It will help to verify the API changes >across the architecture by author.(i.e author should not depend arm64 >box to verify the compilation changes) > [Shally] Ok. Will propose this change in next patch >> +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF_DEBUG=3Dn > >This config option is not required when we are using >dynamic debugging. [Shally] Ack > >> + >> # >> # Compile PMD for ISA-L compression device >> # >> diff --git a/drivers/compress/Makefile b/drivers/compress/Makefile >> index 592497f51..62b4e5abe 100644 >> --- a/drivers/compress/Makefile >> +++ b/drivers/compress/Makefile >> @@ -4,5 +4,5 @@ >> include $(RTE_SDK)/mk/rte.vars.mk >> >> DIRS-$(CONFIG_RTE_LIBRTE_PMD_ISAL) +=3D isal >> - >> +DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF) +=3D octeontx >> include $(RTE_SDK)/mk/rte.subdir.mk >> diff --git a/drivers/compress/octeontx/Makefile b/drivers/compress/octeo= ntx/Makefile >> new file mode 100644 >> index 000000000..89078f085 >> --- /dev/null >> +++ b/drivers/compress/octeontx/Makefile >> @@ -0,0 +1,33 @@ >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright(c) 2017-2018 Cavium Network > >We are using the following copyright header across DPDK, >Please use the same schematics new. > >example: >Copyright(c) 2017 Cavium, Inc > > //snip > >Use alphabetical order. > >> +#include "zipvf.h" >> + >> +/* global structure to keep driver info */ >> +struct zip_pmd_private zip_pmd_priv; > >Remove global memory. Use name based memzone infrastructure to >allocate the memory. [Shally] Ok. Will look into this. > //snip >> + >> + >> +#endif /* _RTE_ZIP_VF_H_ */ >> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > >Addition to usertools/dpdk-devbind.py, please send it as separate patch as >it is an common code change [Shally] Ok. Thanks for review. Shally