From: "Verma, Shally" <Shally.Verma@cavium.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Vangati, Narender" <narender.vangati@intel.com>,
"Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [dpdk-dev] [v2, 2/3] cryptodev: support session private data setting
Date: Fri, 20 Apr 2018 12:23:17 +0000 [thread overview]
Message-ID: <CY4PR0701MB36343A7B6721341DDDDFE4F1F0B40@CY4PR0701MB3634.namprd07.prod.outlook.com> (raw)
In-Reply-To: <5612CB344B05EE4F95FC5B729939F780706F0302@PGSMSX106.gar.corp.intel.com>
//snip
>> >+int __rte_experimental
>> >+rte_cryptodev_sym_session_set_private_data(
>> >+ struct rte_cryptodev_sym_session
>> *sess,
>> >+ void *data,
>> >+ uint16_t size)
>> >+{
>> >+ uint16_t off_set = sizeof(void *) * nb_drivers;
>> >+ uint8_t *private_data_present = (uint8_t *)sess + off_set;
>>
>> [Shally] I was going through this in context of crypto event adapter and realize
>> probably it is safer to set priv_data_size after (sess == NULL) check.
>> Same is applicable in get_private_data().
>[Abhinandan] I guess you are pointing *private_data_present* which is calculated prior, it will not be used if the sess is NULL.
>
Oh. Ya . sorry I missed that.
//snip
Thanks
Shally
next prev parent reply other threads:[~2018-04-20 12:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 6:54 [dpdk-dev] [v2, 1/3] cryptodev: set private data for session-less mode Abhinandan Gujjar
2018-04-16 6:54 ` [dpdk-dev] [v2, 2/3] cryptodev: support session private data setting Abhinandan Gujjar
2018-04-19 12:16 ` Verma, Shally
2018-04-20 12:20 ` Gujjar, Abhinandan S
2018-04-20 12:23 ` Verma, Shally [this message]
2018-04-16 6:54 ` [dpdk-dev] [v3,3/3] doc: add private data info in crypto guide Abhinandan Gujjar
2018-04-16 9:16 ` Akhil Goyal
2018-04-16 9:36 ` Gujjar, Abhinandan S
2018-04-17 13:49 ` De Lara Guarch, Pablo
2018-04-17 13:57 ` [dpdk-dev] [v2, 1/3] cryptodev: set private data for session-less mode De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR0701MB36343A7B6721341DDDDFE4F1F0B40@CY4PR0701MB3634.namprd07.prod.outlook.com \
--to=shally.verma@cavium.com \
--cc=Jerin.JacobKollanukkaran@cavium.com \
--cc=abhinandan.gujjar@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=narender.vangati@intel.com \
--cc=nikhil.rao@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).