From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0045.outbound.protection.outlook.com [104.47.40.45]) by dpdk.org (Postfix) with ESMTP id 2E90E1B457 for ; Wed, 20 Jun 2018 09:36:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fdR0SqhU8rXlNcz3IFdohDM22siP8V5ClF8aSNmhfSQ=; b=PrvfynDwKW8X1CFi5E8zjMC0VgULzlAyMtYYYXDWk81AIz62wIubwXdh/ELZrwlK2b83z9NJCeHVg728bvDh2GHMDAOCrI/aeoPBW9V1z3+33lASz8n8FNqGZZryyMngihq2XygqRs6r0s73KGnf1w5oA1YpRt8dGkMNc5XYavs= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3651.namprd07.prod.outlook.com (52.132.102.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.17; Wed, 20 Jun 2018 07:36:22 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%2]) with mapi id 15.20.0863.016; Wed, 20 Jun 2018 07:36:22 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "Trahe, Fiona" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" Thread-Topic: [PATCH v1 7/7] drivers/compress: add meson.build support Thread-Index: AQHUCB0VbhD6lH6SwU6Q6OGF4FKRoaRonU2AgAAiVgCAAAK7gA== Date: Wed, 20 Jun 2018 07:36:21 +0000 Message-ID: References: <1528194913-25893-1-git-send-email-shally.verma@caviumnetworks.com> <1528194913-25893-8-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3651; 7:fpLq6BU3CXyk+N4Lx08YX1G9krKCLVSq8pbpjcinHeNbbLahE55VxjaEEB70MA7psaqmL/4Vwiyj5tmxe7qvDB3ejbhLwade3NX6kuFWCEfHwQleBmnic2ovq9TXRgdKHAVInFpQop3D2foQyCYMNygK0rPNFM11wJjjBC2KrjFMtqezF/R8UO/Qck45Zm/u5kGbNrDt5ZPfAj59rokZK3nB9u+7Q8We+QajFYu7UuSzyqhEtSOWt54E1TEn0Fbr x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(366004)(346002)(39860400002)(39380400002)(376002)(199004)(189003)(13464003)(97736004)(476003)(11346002)(486006)(53936002)(107886003)(54906003)(86362001)(5250100002)(25786009)(6246003)(446003)(9686003)(99286004)(2900100001)(93886005)(6436002)(6506007)(55016002)(53546011)(81166006)(106356001)(3846002)(8936002)(316002)(8676002)(4326008)(2906002)(81156014)(478600001)(55236004)(66066001)(6916009)(33656002)(74316002)(7696005)(76176011)(186003)(72206003)(105586002)(3660700001)(26005)(6116002)(7736002)(102836004)(14454004)(3280700002)(229853002)(305945005)(5660300001)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3651; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: 83408087-8d76-40eb-f3d5-08d5d680852a x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3651; x-ms-traffictypediagnostic: CY4PR0701MB3651: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3651; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3651; x-forefront-prvs: 070912876F received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: FZafBOlNpkdvZ0YCV3HvyX8wlKmDx+KxeXx2BUaGMKNVQUzqDaMXAU+cPfhGmP/Brbg6on6dcD3tH7pnCa9zBTfGs8H3eJdjBCJy/aP/WD7VsQvttccQE02P5OiAZT7JW4t+lxjq13VXwzHa8boya7Fe6DCWbMzZ/uxwqKTjDNuqA5XKAddnlsk//1Ntz3gvrVxaqVg7+WyUk1EQBf0YwFBqYz1QQ2PeHvv5rlRahbQ9X6qtszpYuSZY4EenX3PAlRJGoHDprz8osTItszYtogl8uhHRN2orr2T52aA8UW5eIXzaeoR9Sf/FtmYp5VPFb5Lmw3P3rtMZ5UZA+ijYRw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83408087-8d76-40eb-f3d5-08d5d680852a X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2018 07:36:21.9729 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3651 Subject: Re: [dpdk-dev] [PATCH v1 7/7] drivers/compress: add meson.build support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 07:36:24 -0000 >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 20 June 2018 12:56 >To: Verma, Shally >Cc: Trahe, Fiona ; dev@dpdk.org; Athreya, Narayana = Prasad ; >Challa, Mahipal ; Gupta, Ashish ; Sahu, Sunila > >Subject: RE: [PATCH v1 7/7] drivers/compress: add meson.build support > >External Email > >Hi Shally, > >> -----Original Message----- >> From: Verma, Shally [mailto:Shally.Verma@cavium.com] >> Sent: Wednesday, June 20, 2018 7:02 AM >> To: De Lara Guarch, Pablo >> Cc: Trahe, Fiona ; dev@dpdk.org; Athreya, Narayan= a >> Prasad ; Challa, Mahipal >> ; Gupta, Ashish ; >> Sahu, Sunila >> Subject: RE: [PATCH v1 7/7] drivers/compress: add meson.build support >> >> >> // snip >> >> Also change the config and drv format flags to append _compress to >> >> use compression specific format for global filenames. This also >> >> require change in compression PMDs to rename their version.map files >> >> as rte_pmd_> >> name>_compress.map ex. Isal should rename as >> >> rte_pmd_isal_compress_version.map. >> >> >> >> Currently the drivers/compress/meson.build use the generic config >> >> names with no compress specific specifier. This breaks meson build >> >> when vendor uses same name for different PMDs, where all belongs to s= ame >> platform. >> >> Ex. drivers/net/octeontx, drivers/event/octeontx, >> >> drivers/compress/octeontx where, net, event and compress carry PMD >> >> for eth, event and compression devices for Octeontx platform. Thus, >> >> differentiate globally used files using module specific specifier ex. >> >> rte_pmd_octeontx_compress_version.map >> >> and rte_pmd_octeontx_event_version.map >> > >> >I think instead of forcing all the PMDs to use that suffix, if there >> >are drivers with the same PMD, they can add the "compres" suffix, witho= ut >> imposing it to others. >> > >> [Shally] Meson build force us to use then directory name as octeontx_com= press >> where as we want to keep it as compress/octeontx (on the similar lines o= f >> net/octeontx, event/octeontx). Also its already under compress, so havin= g it as >> compress/octeontx_compress looks unnecessary, > >For null crypto, the directory is called crypto/null and it is built with = meson (and there is also a net/null). >Maybe doing something like that will work? > >If it doesn't, then you can add this, but make sure that you fix >the isal export map name in the Makefile too. > [Shally] fine. I will check for this and if required, will send patch for I= SAL as well. >Thanks, >Pablo > >> >> Thanks >> Shally