From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680083.outbound.protection.outlook.com [40.107.68.83]) by dpdk.org (Postfix) with ESMTP id 4D001235 for ; Mon, 23 Jul 2018 14:52:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rZrT6iCTj5YMV3Gl+d8V7WaPKSyjUPq4aELDZVSku14=; b=PjfHsZt7TM3po/burRqpJId0uCq3sJNk4MjBeVFfxRFaCD2B6oFFkZC18K2S5tLIhuVRsgv78ig72JFPr+3ZGHOdNkcpHfqsFhf52uvfzUxwVHAbrDfcf9JYILowju4jkCL0IasTbPU5O/TPaI4RKes+sNq7vPKhh6GHrecJPd0= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3716.namprd07.prod.outlook.com (52.132.102.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Mon, 23 Jul 2018 12:52:37 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0973.022; Mon, 23 Jul 2018 12:52:36 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" , "Sahu, Sunila" Thread-Topic: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue Thread-Index: AQHUIoHQXjw7aCYx9EinsJeb/E1C4KScwTqQ Date: Mon, 23 Jul 2018 12:52:36 +0000 Message-ID: References: <1532197069-24224-1-git-send-email-shally.verma@caviumnetworks.com> <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [114.143.185.87] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3716; 6:NZ58qHpezWEpNxdifk9NzXuyuNUCP/UQQvuqA4KcenJGC0Ik4Xd9cdNUqgfnmJUOgrp1w1LVC+Dr1cawuaoMCG1oaxCTHRkIam2CiBnQ1MewMHGHpf1KXRgOECfLoYRNl+ReAcIalOHPjqYCjqg/hFMDRF22E1GfRASY5VJBIqrGXCeOHF5/A9kPJFwkexAYeWyi11w4vFd+h0hQD2e8z4yx2+g9G3Cij1acjH9n2z5ZQTUGECN9yWG0MBa4k2+U10qloS9NxVU8YmDIjSxjYTfR4EEwV+B+0sxwhvbbKseo9XiuKHq0oQ9eun54qJHCHUGKpy4DSSiwFSE9FFMK17kIlaS1ZTjCBCqybGxSDmZHrV1h4YQjY2bNgwTwK+qIG7LwkHMQ9j/+xj/V8w2exY1LCsuqDgSpYVe/1Qvyq9SwPBBJfEFxqL8FxgL+biC5kFUzH7oC/ZTxK6N4iz8MHg==; 5:CUDbMHCy78aCJbfLLLHdzreLEsQ1XclJTwZssBNoRefwNSnn05+ijcQHRvBBZY/rV9HnduR9cq26YJk8znYGhtPdg2XbRr7G5oHU/BlIgVW8Xcjka72TF01+TVHfpBawNrunQbsYQUZLVuoCvxr3/GNjaWlyoUD0ovb1CmLjCMU=; 7:5vpgaAHBssKGEluqaWhAAH/hVaR7207Em0qdNqvq075ul6zOGHBEjf/aIUhblruhfCqNKKUUmuV7o1C2j1J8PQFbdorcHc9QGh/XdO1+vF9WuC71OQHW7QwZOH0n09E1npllqLjwnwGulsnFeLB9tKW3idZ8zJs1vaOXcJOpVbuM677FoMcxiSWyZrAX3yehhcElEiZXeEGCQUYp7KV+YCKCynR/83mOJmLLDAYzGT3yWau1IfGwyI5yDan55eTK x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(366004)(346002)(396003)(376002)(136003)(39860400002)(199004)(189003)(13464003)(97736004)(6916009)(486006)(14444005)(5660300001)(8936002)(3846002)(6116002)(256004)(476003)(229853002)(186003)(6246003)(107886003)(99286004)(81156014)(26005)(478600001)(81166006)(4326008)(8676002)(7696005)(72206003)(102836004)(76176011)(86362001)(6436002)(33656002)(316002)(9686003)(6506007)(25786009)(68736007)(53546011)(53936002)(305945005)(14454004)(11346002)(446003)(66066001)(106356001)(5250100002)(2900100001)(74316002)(7736002)(105586002)(54906003)(55016002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3716; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: d4948bce-c9bd-436b-3678-08d5f09b2a83 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3716; x-ms-traffictypediagnostic: CY4PR0701MB3716: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3716; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3716; x-forefront-prvs: 0742443479 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 9H/n6GBagEUE21pH+S72EVlCDXUWnY4KKFKCjhykB5CfO09d2gZmyhDUiItHN/y9xquUaw/FDD7HtPV9RDRql4qluRvwwA9TE+zUkBZoTNPq1J8DGox0Hu8c22wf9Hds/VdBCGL5dEIK+sIra2X1WJERWXfJrVCFKA2LKslbqihhiXk80185+qz+xRWl87uCIGATCw0Pkrsed/DA0G75rTnYgXN89fyUFvmShLVtmeHy6NhzgQKpmP23x4oaEgpAYf7YDhevaAqnker43ELywQqGOfRw0+9AbovLetQKP5ZIqE2WW+1mUEHZW63oF232fbnriOuhv9tBemYDLiX7YwFILgm+ETSe3NrhtrdhaoM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4948bce-c9bd-436b-3678-08d5f09b2a83 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2018 12:52:36.5271 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3716 Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 12:52:39 -0000 Hi Pablo >-----Original Message----- >From: De Lara Guarch, Pablo >Sent: 23 July 2018 18:07 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Challa, Mahipal >; Gupta, Ashish ; Sahu= , Sunila ; Sahu, Sunila > >Subject: RE: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue > >External Email > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Saturday, July 21, 2018 7:18 PM >> To: De Lara Guarch, Pablo >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; >> mchalla@caviumnetworks.com; ashish.gupta@caviumnetworks.com; >> sunila.sahu@caviumnetworks.com; Sunila Sahu >> Subject: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue >> >> From: Sunila Sahu >> >> Signed-off-by: Sunila Sahu >> Signed-off-by: Shally Verma >> Signed-off-by: Ashish Gupta >> --- >> drivers/compress/zlib/zlib_pmd.c | 254 > >... > >> +def_end: >> + /* Update op stats */ >> + switch (op->status) { >> + case RTE_COMP_OP_STATUS_SUCCESS: >> + op->consumed +=3D strm->total_in; > >Compilation issue here: > >drivers/compress/zlib/zlib_pmd.c:94:16: error: this statement may fall thr= ough [-Werror=3Dimplicit-fallthrough=3D] > op->consumed +=3D strm->total_in; > ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ > >I think you are missing a "/* Fall-through */" comment here. OK. I will send next patch immediately with this fix. But which compiler ve= rsion you following, since this isn't seen during our build (which we did o= n multiple platforms) so want to understand what is the environment we need= to have to avoid such regressions. Thanks Shally > >Thanks, >Pablo > >> + case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED: >> + op->produced +=3D strm->total_out; >> + break;