From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0044.outbound.protection.outlook.com [104.47.38.44]) by dpdk.org (Postfix) with ESMTP id 2CD1498 for ; Tue, 24 Jul 2018 09:27:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KQFhKl8Ib51eIBh9S28QqqC5/AarUA5fFR1pBdWyutg=; b=cnn9PLxKr6UmvBhcjb4V+LOy+kpfl6pyYhrzTP58LUdDU/AX7/pxA2QTKBPBO+/XTIP8k91gXSsiWO8ps/sLie4YzDwix+K772LwiDxaHzX96gplnmgElB1jZCM6eZ5NsfIOsLJCsUTbbwhGOXiPHbvGpGiceJdEUFzEdabFstg= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3682.namprd07.prod.outlook.com (52.132.102.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Tue, 24 Jul 2018 07:27:26 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0973.022; Tue, 24 Jul 2018 07:27:25 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" Thread-Topic: [PATCH v4 2/5] compress/zlib: add device PMD ops Thread-Index: AQHUItDn8yz4vxeCEUW20HdqodCg/aSd9+Xw Date: Tue, 24 Jul 2018 07:27:25 +0000 Message-ID: References: <1532357474-9544-1-git-send-email-shally.verma@caviumnetworks.com> <1532357474-9544-3-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [114.143.185.87] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3682; 6:r5w9mRgrUI62JRgLtAq8vAsaHbQh/Xv0MZJ/49uqC3K45qHbUgR1lEigNwxtFeCEPJcD55xSxGUa7sbeU5GEXxQ/DWbWvanbD2KsxMFnHbBYN24JsdWUhFqwA/n9ElfWVzMfY15sOq06xtgK2wC8n7s0Tp0RviQV3cHA891ZfqsOxhbMaG3hXeC+dgd0KP5GeV7/KdzY6yVwzXDuCgpXz9HxpSegBe+QRTaEO0K4t16EUOBVe9pVBquEq86fpJcUIPtYEuIVMbH0e0rQ0052+s/TmEnl7YX2OhUakvuWGuoRTExiWNLcjZZM++xMUe/cE/WPj5YvOhVi5iAyagfPrUwpkCZxoaA2+BO4aNruI19WXv98Pp7n2bTQ2tohBr6e3jICCzFWCzTcztKAPMfULMjcN7vNrVdsecdpEkio0O3xYI0C/RImH6sxymWm4ZkukcOEwJuYdcv2hOkljhPzcQ==; 5:73CmdLVCWky9y2lyNpwSC3ovQyYH3LC1E5YH8VzusghbpV+VhiPtekn/wT86VLGvq0ILbyUl7HMDAKW7lhq588GPPzkEjSco+GljK54vMz3AwfPlB/Na2cy6cuNjOPSLrlz5xxEq3jMxngV90i/jvFmg1ba9qxGdOxWPFlEJPQw=; 7:FeOMzo/VUniMET4uCq66AQqJmDS7HjwsOUwlCdmAoQbtb9jdYd1ZjUK41YVKyLY9ri3UjruS/X4Dwc6NcXWeiuLa0zaASsq5SRBWNfQkyZ74S5W3xExDdHYwk94UayMyijSGcILOl68xM9J7wxx2BOOvVQFQq2Ht0m5Djhgfc7XG1l3PaxzNMXxvEDqMGJFoGzy8rRSsoW76rUJYLKZVph9/W/a7ndGEdkdfJexriinR5fwdo1FsvFkFdDoPJzYy x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(366004)(39850400004)(396003)(199004)(189003)(13464003)(53546011)(102836004)(99286004)(97736004)(305945005)(6246003)(81166006)(9686003)(74316002)(7736002)(486006)(11346002)(476003)(446003)(25786009)(81156014)(26005)(6506007)(316002)(14454004)(54906003)(55016002)(6916009)(2900100001)(186003)(8676002)(7696005)(86362001)(229853002)(76176011)(105586002)(5250100002)(106356001)(72206003)(3846002)(478600001)(5660300001)(33656002)(2906002)(6116002)(4326008)(53936002)(256004)(107886003)(68736007)(8936002)(6436002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3682; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: 0055fedc-caac-4671-a5f3-08d5f136e752 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3682; x-ms-traffictypediagnostic: CY4PR0701MB3682: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3682; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3682; x-forefront-prvs: 0743E8D0A6 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: sPRX8PfFRaYddN02L0amJm2dV1F9bdpkeHT6j24f2Fjj6WT/s3IbDeRB9Oi7KDkt7cuDgbzQPYODXCxHOIgJ5QrvvBDfYpSq+ifRN7pRubdJuqyl9zzjXKnJMULSsogBm783eWIQVXHaqBzoWoUPew/UNWoGBxD5S2j8NFs/XmzExYiM9pTMJ5K4fDiG+HDbZC6wpizlIbGMMU1aJCIehVcv71NDG7DrcwAU5w7nTprCWIYyV8eQ5asoWQAgCeSoKBNBPt70rFnIVnXRM11nQon63/VIPNnBnV2GT9a9DwoELvTshWEug26+ve6nkGypZmhAaANyiP/NBLx1v6qsCBVM9PRFQzSLFxUCldsqjAQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0055fedc-caac-4671-a5f3-08d5f136e752 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2018 07:27:25.2032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3682 Subject: Re: [dpdk-dev] [PATCH v4 2/5] compress/zlib: add device PMD ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 07:27:28 -0000 >-----Original Message----- >From: De Lara Guarch, Pablo >Sent: 24 July 2018 03:33 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Challa, Mahipal >; Gupta, Ashish ; Sahu= , Sunila >Subject: RE: [PATCH v4 2/5] compress/zlib: add device PMD ops > >External Email > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Monday, July 23, 2018 3:51 PM >> To: De Lara Guarch, Pablo >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; >> mchalla@caviumnetworks.com; Ashish Gupta >> ; Sunila Sahu >> >> Subject: [PATCH v4 2/5] compress/zlib: add device PMD ops >> >> From: Ashish Gupta >> >> Implement device configure and queue pair setup PMD ops >> >> Signed-off-by: Sunila Sahu >> Signed-off-by: Shally Verma >> Signed-off-by: Ashish Gupta > >... > >> --- /dev/null >> +++ b/drivers/compress/zlib/zlib_pmd_ops.c >> @@ -0,0 +1,238 @@ >> +/* SPDX-License-Identifier: BSD-3-Clause >> + * Copyright(c) 2018 Cavium Networks >> + */ >> + >> +#include >> + >> +#include >> +#include >> + >> +#include "zlib_pmd_private.h" >> + >> +static const struct rte_compressdev_capabilities zlib_pmd_capabilities[= ] =3D { >> + { /* Deflate */ >> + .algo =3D RTE_COMP_ALGO_DEFLATE, >> + .comp_feature_flags =3D >> (RTE_COMP_FF_NONCOMPRESSED_BLOCKS | >> + RTE_COMP_FF_HUFFMAN_FIXED | >> + RTE_COMP_FF_HUFFMAN_DYNAMIC | >> + >> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT), > >As said in the document patch, I think you should add the other two SGL ca= ses here. Would give thought to it however, prefer to hold back on their support unti= l we evaluate them with proper testcases. Thanks Shally