From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0088.outbound.protection.outlook.com [104.47.40.88]) by dpdk.org (Postfix) with ESMTP id ACC4A374 for ; Mon, 5 Mar 2018 15:32:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2MA2imJppzscOvuK+cSLGuoiccKReiDqlclu7l0P5q0=; b=h1k1qJTRXWUzwZd2FrH6WcB6ELhLmFScy+tX7mKlqLtuc86sP67A96zhEDb7F2hkwBsNSjFvxwg/D7QmNu+HtEiv4xLJtUDfNvZm6NO7AVe1FJtsXrcI01Lzs233UcGbruWjtzZYmGtt201rHtaC+p4uzf171zOZJOE3WsmHdrM= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3761.namprd07.prod.outlook.com (52.132.102.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.548.13; Mon, 5 Mar 2018 14:32:40 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::e842:2eb2:2ff5:5dd6]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::e842:2eb2:2ff5:5dd6%13]) with mapi id 15.20.0548.016; Mon, 5 Mar 2018 14:32:38 +0000 From: "Verma, Shally" To: Ahmed Mansour , "Trahe, Fiona" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "Athreya, Narayana Prasad" , "Gupta, Ashish" , "Sahu, Sunila" , "Challa, Mahipal" , "Jain, Deepak K" , Hemant Agrawal , Roy Pledge , Youri Querry Thread-Topic: [dpdk-dev] [PATCH] compressdev: implement API Thread-Index: AQHTnFM4Vpm7OG1Ltk6wDJVFHhqAyaPB4Pig Date: Mon, 5 Mar 2018 14:32:38 +0000 Message-ID: References: <1517595924-25963-1-git-send-email-fiona.trahe@intel.com> <12544144.czVLKRyaz4@xps> <348A99DA5F5B7549AA880327E580B43589325187@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B4358932983C@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B43589329F78@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B4358932A333@IRSMSX101.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [117.98.192.112] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3761; 7:CuUnIJbYppCUwLFsIqbWKZMZrro3FIK953QMOjcQs5SwyuDnajwNxzpXup8w2WBTDCip9lTdqayDCcLx7JfjxCp5WzVVw+oR6lScY/Stn2E+xkb8gns/G0f9/i5AXB5CubIjfYAMRBF56D83rmkAoQCzWntecOQYQ7xz0ROCsLNiBSi+GO4aV4zu7nAhZsgOF1XuGzAbMpIsbuMn0KkQ6C37HYZwUn7nMarrkGcWkhbJt64ZCGF242si3SzkhUEU x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(346002)(39380400002)(376002)(366004)(39840400004)(13464003)(189003)(199004)(72206003)(8936002)(3280700002)(478600001)(6506007)(2906002)(53546011)(3846002)(6436002)(110136005)(97736004)(54906003)(14454004)(5660300001)(7696005)(26005)(25786009)(81166006)(81156014)(102836004)(8676002)(186003)(6116002)(3660700001)(76176011)(68736007)(66066001)(99286004)(4326008)(229853002)(305945005)(7736002)(105586002)(74316002)(33656002)(9686003)(2950100002)(86362001)(6246003)(55016002)(106356001)(2501003)(316002)(8656006)(53936002)(2900100001)(5890100001)(5250100002)(93886005); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3761; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: ab8994ce-e9de-4578-eacb-08d582a5f225 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:CY4PR0701MB3761; x-ms-traffictypediagnostic: CY4PR0701MB3761: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231220)(944501244)(52105095)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR0701MB3761; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3761; x-forefront-prvs: 06022AA85F received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: XQjigDTUmSpq2ZDXyFG/M0c40FjHkSygisDKKrzZdchSMF/eeX5tmQjI8LKii1DN1CcmQgDCQhttEFjrQmJX8BmriEhKuXbIGIGjtYrT8eVA0wTPRoGJ8w9Q4nze82KS1LfospnBlhBH/Dl6ZL/gJrzs8O2mFGLMUfe+igFwdoSfxvSOy+t8P9jtYIAPb1GF5mZBLnLmJjMhjGqxoNKt4ruOw2UqIJnRwwNHBrAKJYYJVMD037ctl32XroScKd5hTdiQNPgzX6yhxxFp7kfrAx80WUr8CGV8JcH0jDZHlq8H0gFOEz1tE8vh7fpTbugTDcK+r85s28nbiCwEcRz/fg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab8994ce-e9de-4578-eacb-08d582a5f225 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2018 14:32:38.6110 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3761 Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 14:32:43 -0000 >-----Original Message----- >From: Ahmed Mansour [mailto:ahmed.mansour@nxp.com] >Sent: 03 March 2018 01:19 >To: Trahe, Fiona ; Verma, Shally ; dev@dpdk.org >Cc: De Lara Guarch, Pablo ; Athreya, Naray= ana Prasad ; >Gupta, Ashish ; Sahu, Sunila ; Challa, Mahipal >; Jain, Deepak K ; Hem= ant Agrawal ; Roy >Pledge ; Youri Querry >Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API > >On 3/2/2018 4:53 AM, Trahe, Fiona wrote: >> >>> On 3/1/2018 9:41 AM, Trahe, Fiona wrote: >>>> Hi Shally >>>> >>>> //snip// >>>>> [Shally] This looks better to me. So it mean app would always call xf= orm_init() for stateless and attach >>> an >>>>> updated priv_xform to ops (depending upon if there's shareable or not= ). So it does not need to have >>>>> NULL pointer on priv_xform. right? >>>>> >>>> [Fiona] yes. The PMD must return a valid priv_xform pointer. >>> [Ahmed] What I understood is that the xform_init will be called once >>> initially. if the @flag returned is NONE_SHAREABLE then the application >>> must not attach two inflight ops to the same @priv_xform? Otherwise the >>> application can attach many ops in flight to the @priv_xform? >> [Fiona Yes. App calls the xform_init() once on a device where it plans t= o send stateless ops. >> If PMD returns shareable, then it doesn't need to call again and can att= ach this to every stateless op going to that device. >> If PMD returns SINGLE_OP then it must call xform_init() before every oth= er >> stateless op it wants to have inflight simultaneously. This does not mea= n it must be called before every op, >> but probably will set up a batch of priv_xforms - it can reuse each pri= v_xform once the op finishes with it. >[Ahmed] @Shally Can this complexity of managing the NONE_SHAREABLE mode >be pushed into the PMD? A flexible stockpile can be kept and maintained >by the PMD and it can be increased or decreased based on >low-water/high-water thresholds [Shally] It is doable to manage within PMD but need to do hands on to evalu= ate effectiveness. So far, we have never exercised this way and left it to = application to attach different session (or stream) to op for maximum perfo= rmance gain. So, I would say, may it be ok to have flag feature in first pl= ace and deprecate later, if it not required?! Or just have API without any = flag option and add a feature flag to indicate PMD support for SHAREABLE/NO= N-SHAREABLE xform_priv handle?!