From: "Verma, Shally" <Shally.Verma@cavium.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Athreya, Narayana Prasad" <NarayanaPrasad.Athreya@cavium.com>,
"Challa, Mahipal" <Mahipal.Challa@cavium.com>,
"Gupta, Ashish" <Ashish.Gupta@cavium.com>,
"Sahu, Sunila" <Sunila.Sahu@cavium.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/5] compress/zlib: add ZLIB PMD
Date: Tue, 24 Jul 2018 07:20:02 +0000 [thread overview]
Message-ID: <CY4PR0701MB3634AA65FC8342247E754FA0F0550@CY4PR0701MB3634.namprd07.prod.outlook.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F8FFC6E@IRSMSX107.ger.corp.intel.com>
>-----Original Message-----
>From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>Sent: 24 July 2018 03:29
>To: Verma, Shally <Shally.Verma@cavium.com>
>Cc: dev@dpdk.org; Athreya, Narayana Prasad <NarayanaPrasad.Athreya@cavium.com>; Challa, Mahipal
><Mahipal.Challa@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>
>Subject: RE: [PATCH v4 1/5] compress/zlib: add ZLIB PMD
>
...
>
>> +++ b/drivers/compress/zlib/zlib_pmd.c
>
>...
>
>> +static int
>> +zlib_probe(struct rte_vdev_device *vdev) {
>> + struct rte_compressdev_pmd_init_params init_params = {
>> + "",
>> + rte_socket_id()
>> + };
>> + const char *name;
>> + const char *input_args;
>> +
>> + name = rte_vdev_device_name(vdev);
>> +
>> + if (name == NULL)
>> + return -EINVAL;
>> + input_args = rte_vdev_device_args(vdev);
>> + rte_compressdev_pmd_parse_input_args(&init_params, input_args);
>
>Need to check the return value of this function.
Ack.
Thanks
Shally
next prev parent reply other threads:[~2018-07-24 7:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 14:51 [dpdk-dev] [PATCH v4 0/5] compress: add ZLIB compression PMD Shally Verma
2018-07-23 14:51 ` [dpdk-dev] [PATCH v4 1/5] compress/zlib: add ZLIB PMD Shally Verma
2018-07-23 21:58 ` De Lara Guarch, Pablo
2018-07-24 7:20 ` Verma, Shally [this message]
2018-07-23 14:51 ` [dpdk-dev] [PATCH v4 2/5] compress/zlib: add device PMD ops Shally Verma
2018-07-23 22:02 ` De Lara Guarch, Pablo
2018-07-24 7:27 ` Verma, Shally
2018-07-23 14:51 ` [dpdk-dev] [PATCH v4 3/5] compress/zlib: create private xform Shally Verma
2018-07-23 14:51 ` [dpdk-dev] [PATCH v4 4/5] compress/zlib: support burst enqueue/dequeue Shally Verma
2018-07-23 22:25 ` De Lara Guarch, Pablo
2018-07-24 7:44 ` Verma, Shally
2018-07-24 7:53 ` De Lara Guarch, Pablo
2018-07-24 8:14 ` Verma, Shally
2018-07-24 8:19 ` Verma, Shally
2018-07-23 14:51 ` [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide Shally Verma
2018-07-23 17:58 ` De Lara Guarch, Pablo
2018-07-23 18:00 ` Verma, Shally
2018-07-23 21:18 ` De Lara Guarch, Pablo
2018-07-24 5:32 ` Verma, Shally
2018-07-24 7:47 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR0701MB3634AA65FC8342247E754FA0F0550@CY4PR0701MB3634.namprd07.prod.outlook.com \
--to=shally.verma@cavium.com \
--cc=Ashish.Gupta@cavium.com \
--cc=Mahipal.Challa@cavium.com \
--cc=NarayanaPrasad.Athreya@cavium.com \
--cc=Sunila.Sahu@cavium.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).