From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Shally.Verma@cavium.com> Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0062.outbound.protection.outlook.com [104.47.37.62]) by dpdk.org (Postfix) with ESMTP id B9A351B457 for <dev@dpdk.org>; Wed, 20 Jun 2018 08:02:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IKNL0Z6VXtdzA+/Yw9IXxV/pEMka+WD5kkg7c5qRKEI=; b=TLp+78zh8EhODIBvpLETV8Wo2w07xVtXGl0BjhjpCeKOv+a/UmZWGgCdCz/T2ZaRwGC/ZPxMcYjpGXMyhAP+RDGKcggJ+V6ZdUxsAjdvg2siasZTJ3xFyUieYujXIIamnB3vw4+fdEGmS+yHlQCXdRYtksL4RM/GzGemgRguwOw= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3761.namprd07.prod.outlook.com (52.132.102.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.17; Wed, 20 Jun 2018 06:02:18 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%2]) with mapi id 15.20.0863.016; Wed, 20 Jun 2018 06:02:16 +0000 From: "Verma, Shally" <Shally.Verma@cavium.com> To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> CC: "Trahe, Fiona" <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Athreya, Narayana Prasad" <NarayanaPrasad.Athreya@cavium.com>, "Challa, Mahipal" <Mahipal.Challa@cavium.com>, "Gupta, Ashish" <Ashish.Gupta@cavium.com>, "Sahu, Sunila" <Sunila.Sahu@cavium.com> Thread-Topic: [PATCH v1 7/7] drivers/compress: add meson.build support Thread-Index: AQHUCB0VbhD6lH6SwU6Q6OGF4FKRoaRonU2A Date: Wed, 20 Jun 2018 06:02:16 +0000 Message-ID: <CY4PR0701MB3634C000D4E0902DB121BA76F0770@CY4PR0701MB3634.namprd07.prod.outlook.com> References: <1528194913-25893-1-git-send-email-shally.verma@caviumnetworks.com> <1528194913-25893-8-git-send-email-shally.verma@caviumnetworks.com> <E115CCD9D858EF4F90C690B0DCB4D8977F8D85CA@IRSMSX108.ger.corp.intel.com> In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F8D85CA@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3761; 7:7wBr1OzVMsi6z1jNTwTf3+aiE7lg0KkSRZK2GMmAXUrGxVA9JzPg1QpT4Z2Hez0+1zgmzYo1PAtIs1Jg+KWtNUIIDbR8/UdzoEoDT0KkBarMpqF+gL/VJtKeISnPthx24iflov/2BT2MaAGG+gk6ms8bKvv2HD0tO4FawUs0bBXeTC7r1xwhHieunGq3zgwpYZIvkGIjt3/19Bojc1uXgV+32AhO0fhrQVXeajIqkO/H+11JJgFNaVjooLfslXXt x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(39380400002)(39860400002)(366004)(189003)(199004)(13464003)(229853002)(486006)(11346002)(6916009)(33656002)(97736004)(186003)(476003)(6116002)(9686003)(4326008)(2900100001)(53546011)(53936002)(55236004)(72206003)(76176011)(6506007)(26005)(446003)(478600001)(102836004)(7696005)(107886003)(6246003)(99286004)(25786009)(3846002)(14454004)(5250100002)(54906003)(81166006)(81156014)(2906002)(8936002)(6436002)(66066001)(316002)(106356001)(68736007)(305945005)(105586002)(74316002)(86362001)(5660300001)(55016002)(3660700001)(3280700002)(7736002)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3761; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: 7f32fbd2-5889-4dfa-ba83-08d5d6736059 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3761; x-ms-traffictypediagnostic: CY4PR0701MB3761: x-microsoft-antispam-prvs: <CY4PR0701MB3761E81952A935621604BA55F0770@CY4PR0701MB3761.namprd07.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3761; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3761; x-forefront-prvs: 070912876F received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: VL8/kmfxjqMXZji/shUM3awKxcDomco6xIfpojY7i6TsowGhv26XndP+GvV+udVfUdYvAzW981yFkta20JoTbOAIIbqZIbnUZEkpmlD9aOJBhrQLq2+YEOllpT9D1dDkASveHTyg5XiL/gYL0L37KMGUwJrlxaZ37e7og1b15FtaXN2X/nLy5bc6TIq3ukDol607PsAy6edqN5/tv/zNhnWup2Imow2TbSCUCk+p2RAFllB9EZpXKFCu2pvTCFeFgTPDXOswHH8bVk0jiOgQRPtFOnDkuta21XfekbbeV/O77F/Rd8/jDUesAW5Kd8eXidCJaxDUg1/5YKQuYkhirA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f32fbd2-5889-4dfa-ba83-08d5d6736059 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2018 06:02:16.7619 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3761 Subject: Re: [dpdk-dev] [PATCH v1 7/7] drivers/compress: add meson.build support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 20 Jun 2018 06:02:20 -0000 >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 20 June 2018 04:00 >To: Verma, Shally <Shally.Verma@cavium.com> >Cc: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org; Athreya, Narayana = Prasad <NarayanaPrasad.Athreya@cavium.com>; >Challa, Mahipal <Mahipal.Challa@cavium.com>; Gupta, Ashish <Ashish.Gupta@c= avium.com>; Sahu, Sunila ><Sunila.Sahu@cavium.com> >Subject: RE: [PATCH v1 7/7] drivers/compress: add meson.build support > >External Email > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Tuesday, June 5, 2018 11:35 AM >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> >> Cc: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org; >> pathreya@caviumnetworks.com; mchalla@caviumnetworks.com; Ashish Gupta >> <ashish.gupta@caviumnetworks.com>; Sunila Sahu >> <sunila.sahu@caviumnetworks.com> >> Subject: [PATCH v1 7/7] drivers/compress: add meson.build support >> >> Add octeontx in drivers/compress/meson.build. > >This should be added in patch 1. > >> >> Also change the config and drv format flags to append _compress to use >> compression specific format for global filenames. This also require chan= ge in >> compression PMDs to rename their version.map files as rte_pmd_<pmd >> name>_compress.map ex. Isal should rename as >> rte_pmd_isal_compress_version.map. >> >> Currently the drivers/compress/meson.build use the generic config names = with >> no compress specific specifier. This breaks meson build when vendor uses= same >> name for different PMDs, where all belongs to same platform. >> Ex. drivers/net/octeontx, drivers/event/octeontx, drivers/compress/octeo= ntx >> where, net, event and compress carry PMD for eth, event and compression >> devices for Octeontx platform. Thus, differentiate globally used files u= sing >> module specific specifier ex. rte_pmd_octeontx_compress_version.map >> and rte_pmd_octeontx_event_version.map > >I think instead of forcing all the PMDs to use that suffix, if there are d= rivers with the same PMD, >they can add the "compres" suffix, without imposing it to others. > [Shally] Meson build force us to use then directory name as octeontx_compre= ss where as we want to keep it as compress/octeontx (on the similar lines o= f net/octeontx, event/octeontx). Also its already under compress, so having= it as compress/octeontx_compress looks unnecessary, Thanks Shally