From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690070.outbound.protection.outlook.com [40.107.69.70]) by dpdk.org (Postfix) with ESMTP id 6FF9F1B3A9 for ; Fri, 29 Jun 2018 09:42:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uxBfpFI2xdBHEJv3OThoS8MuYmYrEfCUsazpVBlf6C4=; b=cAh/UWplKJJxuZh2ZWQSRyvRYchBw5SPZbDtj0AOPcTQINbl2R1CbHEGdNOOvy7mwzD5yi0gap+p19fTren66KlfosPtyXpVbMjXaowkiuwb9ojQShguayFCUqOc+Ibo1tmf2715y3QxzvrYd1Ixh7+gakZz9LUTtmje53+hlzQ= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3682.namprd07.prod.outlook.com (52.132.102.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.24; Fri, 29 Jun 2018 07:42:03 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%4]) with mapi id 15.20.0884.025; Fri, 29 Jun 2018 07:42:01 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "Trahe, Fiona" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" Thread-Topic: [PATCH v1 4/7] compress/octeontx: add ops enq deq apis Thread-Index: AQHUCBtx7Z2eKZ+RDUOwBaLZxu/MvaR26UtA Date: Fri, 29 Jun 2018 07:42:01 +0000 Message-ID: References: <1528194913-25893-1-git-send-email-shally.verma@caviumnetworks.com> <1528194913-25893-5-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3682; 7:azj/N4ka0/uDfn5apZGubosctrozm2x7Yqyg6vsT+A/r4bajtNpjiWBG2Gvldp3yErdOvX0J0OsKBJ1ghDsP34/ei9QqZ7f2sG0QWb99RSarQuSo7rCZlCHWRIMfnXHo/3nav5ImQXVp2OcEc7gStWzUJmJYhFwJH+mJs7LBXpMGAdoeq+LvJ1z7Vbs+SR7iNNFMBSPE3lYtrDdzDlgkAovtHGyc5yGWvmxizR5Wd2ueFc7+3m3u40WvNIHoYBcp x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(979002)(346002)(366004)(376002)(39860400002)(396003)(136003)(189003)(199004)(13464003)(55016002)(6436002)(2906002)(26005)(186003)(229853002)(76176011)(9686003)(478600001)(256004)(6246003)(53936002)(107886003)(14454004)(25786009)(4326008)(55236004)(102836004)(106356001)(72206003)(99286004)(6916009)(105586002)(6506007)(53546011)(81166006)(54906003)(81156014)(2900100001)(8676002)(11346002)(316002)(74316002)(305945005)(97736004)(7736002)(446003)(8936002)(7696005)(86362001)(3846002)(66066001)(486006)(476003)(6116002)(33656002)(68736007)(5660300001)(5250100002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3682; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: 5121363c-8ce3-4876-3619-08d5dd93cd60 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3682; x-ms-traffictypediagnostic: CY4PR0701MB3682: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3682; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3682; x-forefront-prvs: 0718908305 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: IIVae5KWUwppx6CjoBRSrTqIvD0UphoGfIzFU1GpJRgmakHyaZ4bjr/y0pLWyQ5HPmCSfwjHCvbJbz0raMf7MbefwtjmPzVgYgJSEQnj4M0mu+p/Gll8hXdMmouYumi8QOEYjAk4CeVRF+wXsJIYJLpIUdT+WKj/CTdTJFF+LDonNlKbpBSwAnfken0iV+mnXT6uM2WMUGkmG1USA18/xgAvwaNNFk52d0r85HNSfdtPzPhAYFG8VSriASFD3l3h/KHPZWXZ+/64VepxOgNS5Nuwyqxk+AZK72CnyWdv9cehY+1ustz/q7HrWvefAI8cVhzhGjAeYvZQvKg8IDH2kMe8aSXVXYYlZ1cUtQ0ZKJU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5121363c-8ce3-4876-3619-08d5dd93cd60 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2018 07:42:01.7037 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3682 Subject: Re: [dpdk-dev] [PATCH v1 4/7] compress/octeontx: add ops enq deq apis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 07:42:05 -0000 HI Pablo >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 20 June 2018 03:48 >To: Verma, Shally >Cc: Trahe, Fiona ; dev@dpdk.org; Athreya, Narayana = Prasad ; >Challa, Mahipal ; Gupta, Ashish ; Sahu, Sunila > >Subject: RE: [PATCH v1 4/7] compress/octeontx: add ops enq deq apis > >External Email > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Tuesday, June 5, 2018 11:35 AM >> To: De Lara Guarch, Pablo >> Cc: Trahe, Fiona ; dev@dpdk.org; >> pathreya@caviumnetworks.com; mchalla@caviumnetworks.com; Ashish Gupta >> ; Sunila Sahu >> >> Subject: [PATCH v1 4/7] compress/octeontx: add ops enq deq apis >> >> implement enqueue and dequeue apis >> >> Signed-off-by: Ashish Gupta >> Signed-off-by: Shally Verma >> Signed-off-by: Sunila Sahu > >... > >> --- a/drivers/compress/octeontx/zipvf.h >> +++ b/drivers/compress/octeontx/zipvf.h > >... > >> +static inline int >> +zipvf_prepare_out_buf(struct zip_stream *zstrm, struct rte_comp_op *op) >> +{ >> + uint32_t offset; >> + union zip_zptr_s *sg_list =3D NULL; >> + struct rte_mbuf *m_dst; >> + union zip_inst_s *inst =3D zstrm->inst; >> + rte_iova_t iova; >> + >> + offset =3D op->src.offset; >> + m_dst =3D op->m_dst; >> + >> + if (m_dst->nb_segs =3D=3D 1) { >> + /* Prepare direct input data pointer */ >> + inst->s.ds =3D 0; >> + inst->s.out_ptr_addr.s.addr =3D >> + rte_pktmbuf_iova_offset(m_dst, offset); >> + inst->s.totaloutputlength =3D rte_pktmbuf_data_len(m_dst) = - >> + op->dst.offset; >> + inst->s.out_ptr_ctl.s.length =3D inst->s.totaloutputlength= ; >> + return 0; >> + } >> + >> + ZIP_PMD_ERR("output packet is segmented\n"); >> + >> + /* Packet is segmented, create gather buffer */ >> + inst->s.ds =3D 1; >> + iova =3D rte_mempool_virt2iova(zstrm->bufs[OUT_DATA_BUF]); >> + if (iova & 0xF) { >> + /* Align it to 16 Byte address */ >> + iova =3D ZIP_ALIGN_ROUNDUP(iova, ZIP_SGPTR_ALIGN); >> + } >> + >> + inst->s.out_ptr_addr.s.addr =3D iova; >> + inst->s.inp_ptr_ctl.s.length =3D (m_dst->nb_segs < MAX_SG_LEN) ? >> + (m_dst->nb_segs) : MAX_SG_LEN; >> + >> + sg_list =3D (union zip_zptr_s *)iova; > >There is a compilation issue on gcc 32 bits: > >drivers/compress/octeontx/zipvf.h:260:12: error: >cast to pointer from integer of different size [-Werror=3Dint-to-pointer-c= ast] > sg_list =3D (union zip_zptr_s *)iova; > [Shally] Shouldn't rte_iova_t should be defined to 32-bit size for 32-bit m= achine? Thanks Shally