From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0057.outbound.protection.outlook.com [104.47.36.57]) by dpdk.org (Postfix) with ESMTP id 0CEC4201; Thu, 2 Nov 2017 09:03:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9JsBTkWMoH85cKkl3kyJhkHUq+c0nFmozIn7E6gP1bI=; b=SP1+HpIKlodn6etjmDF1ikOKwgHATT1pGOvqHx1Jjs0Jz+P8F2dcpnUqm1MYbAF5sz//pIg6gxtzCvMfOTZ/9JAw3QC67DVKZl5giZxlVvZwgxMVQmKpB/kNu4m7fi+cTMdHNacjYhuesBFWh7wq7uGH6/IT7PMkXullyIHZ4eY= Received: from CY4PR0701MB3827.namprd07.prod.outlook.com (52.132.102.161) by BN6PR07MB3057.namprd07.prod.outlook.com (10.172.106.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Thu, 2 Nov 2017 08:03:22 +0000 Received: from CY4PR0701MB3827.namprd07.prod.outlook.com ([fe80::1d1f:9065:5662:5e61]) by CY4PR0701MB3827.namprd07.prod.outlook.com ([fe80::1d1f:9065:5662:5e61%13]) with mapi id 15.20.0178.015; Thu, 2 Nov 2017 08:03:21 +0000 From: "Mody, Rasesh" To: Stephen Hemminger CC: Ferruh Yigit , "Tan, Jianfeng" , Jingjing Wu , "Thotton, Shijith" , Gregory Etelson , "Patil, Harish" , Thomas Monjalon , "dev@dpdk.org" , "stable@dpdk.org" , George Prekas , Sergio Gonzalez Monroy Thread-Topic: [dpdk-dev] [PATCH] igb_uio: remove device reset in open Thread-Index: AQHTScQ4G7zZOecjD0CHym69NdlJ/KLs9YgAgAhJTCCAAKcjgIABAXgAgAg3QSCAAISjAIAATNDg Date: Thu, 2 Nov 2017 08:03:21 +0000 Message-ID: References: <20171020165511.47899-1-ferruh.yigit@intel.com> <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> <5108b90a-5617-ea1a-ad41-c2eb83b8c1a1@intel.com> <02e895a8-e1fa-7159-f0e9-b8b8f883ae27@intel.com> <20171101151220.0f3f811b@shemminger-XPS-13-9360> In-Reply-To: <20171101151220.0f3f811b@shemminger-XPS-13-9360> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [2601:646:8180:be50:a86f:ea6f:d502:e05] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BN6PR07MB3057; 6:kzdCQ427+0iAfNl5F8mEm7AXRBLS80/56HV5Gx4XIBN+VseTB5YbszvJDVmT6bj4aMVPORnx7oo9KzueyhvmP8YV+cnvbGnRQAvCD4dn2PHi1T43ZcyPifzl0lOo1n1srnRafbC83+T/spffA4FcIaASVeo93F5mtlcWj5vXbDJx+Yu9WW2LA9qkyIGP4ZxKQw1ySLyf8yh7a9OXdcoINYa5NtTZLqg9OjgbS19BD8biO4uyDhDIDQGbJ4fN2M3qqPLp8zIdOnCUHhMAFHQPOOLKD5HjQ49hbUrzNXcDOcjrvCa1G779jNgvBzC3xgRYoArpcAvCyPRdAS29uNKBheZrl7ManbFCa2F7Z6h6niU=; 5:Kw6Xcr10jWG86P4++UU00ZrJjn3X05jeTIwiFVrL8CvgsVGSoOv0uIZdmn9MJ2jz2eO8zN7iK+1wnHeOMa+611/DKL+bsCQ1pi8RMoTtsXXVsWjJvWJLNXgLmxd9tSKbaFNuP6lLBNLXSxBy5kDoDwwq6ZtPsNiBNddFD0dVoW0=; 24:4vFu3ChG5OTHXSAeHeA+Gnw4IJ5L2jbpFtR1QQuIwS9JJ8O3Vb+MH8Dt+6eTvg8tn0chgHzRxUr61bQNhre0AS9YKMFRWQqhUjNINDZHsLI=; 7:gfb4S3BCd3No/VAo3P9xuOe6izr/usxhLm0NZcKQRKyrYEJb+F/WyEgJnBE3qseFmSyWuL1DkP/ODBY4iM16wpw9B4lebsIijU2V8a2TuMzVrRaV9uz56sWP2EHAa9KGNQUx/Da3/jXbKmOJRr0+S4qsmJ1he21K2R8IoE4YZ/SQ/4KQlZsDNroiZAvJlKnUqzM5s7CqsaqPtYcslhNEqRY9in+kwQw7daxcn7UiTizsSg9jSggIVDXRct+ZMwEM x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(24454002)(43544003)(189002)(199003)(101416001)(93886005)(53936002)(8676002)(81156014)(81166006)(105586002)(189998001)(106356001)(55016002)(7736002)(316002)(97736004)(25786009)(5660300001)(7416002)(9686003)(6506006)(305945005)(5250100002)(6436002)(478600001)(72206003)(53546010)(33656002)(14454004)(50986999)(68736007)(54906003)(3280700002)(3660700001)(102836003)(7696004)(6116002)(54356999)(86362001)(4326008)(2906002)(76176999)(6246003)(229853002)(8936002)(2900100001)(74316002)(2950100002)(6916009)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3057; H:CY4PR0701MB3827.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: 32e2ec95-e0c2-4505-682a-08d521c82f4c x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:BN6PR07MB3057; x-ms-traffictypediagnostic: BN6PR07MB3057: x-exchange-antispam-report-test: UriScan:(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3231020)(3002001)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3057; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3057; x-forefront-prvs: 047999FF16 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32e2ec95-e0c2-4505-682a-08d521c82f4c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2017 08:03:21.3036 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3057 Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 08:03:26 -0000 > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, November 01, 2017 7:12 AM >=20 > On Wed, 1 Nov 2017 06:58:53 +0000 > "Mody, Rasesh" wrote: >=20 > > Hi Jianfeng and Ferruh, > > > > > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > > > Sent: Thursday, October 26, 2017 5:50 PM > > > > > > On 10/26/2017 2:28 AM, Tan, Jianfeng wrote: > > > > Hi Rasesh, > > > > > > > > > > > > On 10/26/2017 7:43 AM, Mody, Rasesh wrote: > > > >> Hi Ferruh, > > > >> > > > >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh > > > >>> Yigit > > > >>> Sent: Friday, October 20, 2017 9:58 AM > > > >>> > > > >>> On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > > > >>>> Remove device reset during application start, the reset for > > > >>>> application exit still there. > > > >>>> > > > >>>> Reset in open removed because of following comments: > > > >>>> 1- Device reset not completed when VF driver loaded, which > > > >>>> cause VF > > > PMD > > > >>>> initialization error. > > > >>>> Adding delay can solve the issue but will increase driver lo= ad time. > > > >>>> > > > >>>> 2- Reset will be issues all devices unconditionally, not very ef= ficient > > > >>>> way. > > > >>>> > > > >>>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and > > > >>>> release of device file") > > > >>>> Cc: stable@dpdk.org > > > >>>> > > > >>>> Signed-off-by: Ferruh Yigit > > > >>> Hi Jingjing, Shijith, Gregory, Harish, > > > >>> > > > >>> Can you please test this on top of current master (which has > > > >>> already Jingjin's > > > >>> fix) ? > > > >> The original FLR change during igb_uio open()/release() in > > > >> DPDK17.08 also > > > impacts BNX2X PMD and it exhibits the issues with bare metal testing. > > > >> > > > >> Now, we tested this change for BNX2X PMD using latest dpdk, which > > > >> has > > > this fix where FLR is invoked only in the release(). > > > > > > Good to hear this fixed the problem. > > > > Yes, it fixed the issue caused by pci reset during application start. > > > > > > > > >> However, we ran into an issue when trying to reload the testpmd > > > application in quick succession. The pci reset, called during the > > > igb_uio > > > release() operation, is taking longer time and adapter is still > > > doing the FLR when we relaunch the application. We see this behavior > > > with bare metal testing. > > > > > > > > If we don't reset that device, it will continue working which is a > > > > more serious issue IMO. > > > > > > +1 > > > > I think, it would better for the individual PMDs to take care of the re= set > during the application exit. >=20 > That will never be possible. Poll Mode Drivers are userspace entities and= part > of the application. If application crashes, there is no way for PMD to do > cleanup, it must be handled by kernel. The pci reset in release is breaking the BNX2X PMD. Could we revert this re= set and get it included with a solution that works for all in the next rele= ase? Thanks! -Rasesh