From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5055FA0350; Tue, 23 Jun 2020 23:31:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B72AF1D6E3; Tue, 23 Jun 2020 23:31:45 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id EA9961D6E2 for ; Tue, 23 Jun 2020 23:31:43 +0200 (CEST) IronPort-SDR: gNflgesGTnD8iQDOz4gZiFljnZs3vEROntR4bw8CmcGrAXzY2jup2GfysjEcjmrkLo/yzzW2nB rWTVXqgzhfIw== X-IronPort-AV: E=McAfee;i="6000,8403,9661"; a="228922964" X-IronPort-AV: E=Sophos;i="5.75,272,1589266800"; d="scan'208";a="228922964" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2020 14:31:33 -0700 IronPort-SDR: Emh7l4eirKUr473SbM2kVX9CX5WrUMhCzPDs3G5V8xro1WT0k8yDrG78tN0lveWci8fYR6QkHb nfHA+tS3gJRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,272,1589266800"; d="scan'208";a="423156745" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 23 Jun 2020 14:31:33 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jun 2020 14:31:33 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jun 2020 14:31:32 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.58) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jun 2020 14:31:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=msyvJXQ+OGXBDtJN30JsHhnC83PK0jg3Sui9VVmMvo+WG/cWre1S3Y7kd8JB2Cxo9kikyxE5nI3PcWYMlV3alIcwExLSLyQYT1kQsFnTudvf55AgFzCDzFkQPEZYx7aumVIiYk3kFV9Msjs1e2sM0mIlybl0Ejsg7zz4b9MZsDq7E7qSZY2ZF7HjpCGSy6Ld5ojVPipb+p7ddVZiMbXvpn3a6/iE5CzYLxtyqVNIwhOjhvd9D0qok9d4A11ofPz9MIokDRKgbhWeA73VPgi/6B6pLOHNtJn+wzM2m1V+cTj0e8QPFI6kQCCBexyOoMHyjsko4n3Rs8Idwze/pLX69w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tcO3XfyGK2I/llCMm16/nghVz8Nyan6TzJA1dgbTS+U=; b=ftPQligtV0jS9IjdAxwRM8ZkAhJeinv5hrf+vKkuHh2BhyQBPsTzSnofRV1LEs7qu+J1hz2rrfZtvZXAykjXF4HmOGDg2qDUpt9/48EzkAhm9vLAIzkT4mw/PwNofM65ZArrhPtNuudIgF3ZB23gsOBSxYGqYd2tLcoGo/3+fxfmGBcCqOiUmkicHmgBN6Tvm4aSUjGtlPwffRHSOwPhrhEYN5dq46CTyc8Ni8NABEW/BxSLVhiAORSytpjemJqc7vsGUl0JtXqYcK44Zkoc93YkFbk6MustxU7EToZn14mO+GkIW6SIsDjIyR50ZW/f1gyZT8iMt0gZUUrd37om0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tcO3XfyGK2I/llCMm16/nghVz8Nyan6TzJA1dgbTS+U=; b=aMW2M/W3xWDJVtXu9c0thMeZsMphqII6BW8jfER5UpkehFfb6U10Xdpz+ej4E7tDBhxjvObwr/Rc0BVpj+GUSif2tNma6h6maWUpSYJcbltgJw1Mqd7+ySXFafAnJMmt2EeztGhUBfmHckWqvdGZpf30EA3v+4XsFpJR0fJ/qSo= Received: from CY4PR1101MB2118.namprd11.prod.outlook.com (2603:10b6:910:1f::10) by CY4PR11MB1366.namprd11.prod.outlook.com (2603:10b6:903:2b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Tue, 23 Jun 2020 21:31:31 +0000 Received: from CY4PR1101MB2118.namprd11.prod.outlook.com ([fe80::410b:7807:181:1620]) by CY4PR1101MB2118.namprd11.prod.outlook.com ([fe80::410b:7807:181:1620%4]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 21:31:31 +0000 From: "Carrillo, Erik G" To: Stephen Hemminger , Phil Yang CC: "dev@dpdk.org" , "drc@linux.vnet.ibm.com" , "honnappa.nagarahalli@arm.com" , "ruifeng.wang@arm.com" , "dharmik.thakkar@arm.com" , "nd@arm.com" Thread-Topic: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag Thread-Index: AQHWQKuE7f35LvPXW06J888vxz8FdKjmxsUAgAAA0uA= Date: Tue, 23 Jun 2020 21:31:31 +0000 Message-ID: References: <1591960798-24024-1-git-send-email-phil.yang@arm.com> <1591960798-24024-2-git-send-email-phil.yang@arm.com> <20200623142002.6b997568@hermes.lan> In-Reply-To: <20200623142002.6b997568@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.216] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8a5f6666-b695-4aad-7317-08d817bccbce x-ms-traffictypediagnostic: CY4PR11MB1366: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 04433051BF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qRzCoLbOgS3/NFZfYlFFec/5VXNfRNKevZBHB5mL2n4gs8QILVyngfAObB/25ZmZ0JUiOO81Q3ZZYUbjhYws32Us7zg/5VsBbISHl2JDapiPYPVxeScpxqx8HxzoTs3YH0qk0bDCqC1Mrvp8/UywTFwmH3T9mo17ZaQjWv7dEss6LVUsgTyAwPxNw6pg83tDfe4FpNHhcSso62XvSB2rrMvVPNiwLRXUhUHyqoToGRgk6WHaBc2kTXMVB9ij2QfvO1dRXolKGG7o0fkm0l4uNuw5ujtlLfY9w7BV718ks9v6cveaMKjsH1z8sc0WrytrsFV8Y3CSOL6i0hyl7kO6Fw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2118.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(55016002)(54906003)(110136005)(7696005)(478600001)(9686003)(186003)(53546011)(6506007)(33656002)(316002)(26005)(2906002)(4744005)(86362001)(64756008)(66476007)(66446008)(66946007)(83380400001)(5660300002)(52536014)(4326008)(8936002)(8676002)(76116006)(66556008)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: w7guAfkV1qWZ8yZGiXYkDvFUBL+YltdtbHho4ACfnpOhnoGeqAjKn0OAN4mthfxcM3WgFOknEq1SDO1MYv7iFsqRNa+TnmIfiN/p9CVZkTcMtpt0bJdD3w1L2PPBq4QCxkE1SMjJvVqoo7+ef4itbdzs+BL1FAp0wUDGe4TrALnVuAWVekZUg75fCojbMaXIOIPMAHEpgWWHmpqFIl3W5DJ6nEQq4SzoWz6D3cE0pfLhbjpYPOsLBpyv/1hxGlBsulzDt3A82zaJHxoPfkwh1zvfzZBc1ZlP97xSiRN/ZIeKe2ZxB2SMtyiDaP8sQToSFCC+c0Qz46+539nh96hlH1ALFctDZuTUmgx67D/3oVJ546v0XxuvvSKHyqfH5SeaFPeH6q0habacVqW6U/gkf5AqqtqzJVRZ2Yodq2p1bdzLJteIZB6fckM1rM08kmK/iVubkCEhxO+kJLYeguayfVCg655omBNIjOIFYnYX9JhhSo7UMnxnADir6I1cceCj x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8a5f6666-b695-4aad-7317-08d817bccbce X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2020 21:31:31.2260 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XWywjFUe1cw/3JBEO0z4HLgPWfhtrzh24oEnnjRK6NnSP3K8pLCRoswFH0xUCQ0971GxwQWHVoU8vcic1dOC3jNJnlVZ8J4ctN07l3es9qY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1366 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, June 23, 2020 4:20 PM > To: Phil Yang > Cc: dev@dpdk.org; Carrillo, Erik G ; > drc@linux.vnet.ibm.com; honnappa.nagarahalli@arm.com; > ruifeng.wang@arm.com; dharmik.thakkar@arm.com; nd@arm.com > Subject: Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore > timer armed flag >=20 > On Fri, 12 Jun 2020 19:19:57 +0800 > Phil Yang wrote: >=20 > > /* Track which cores have actually armed a timer */ > > struct { > > - rte_atomic16_t v; > > + int16_t v; > > } __rte_cache_aligned in_use[RTE_MAX_LCORE]; >=20 > Do you really need this to be cache aligned (ie one per line)? I believe I did this originally to keep a cache line from bouncing when two= different cores are arming timers, so it's not strictly necessary. > Why have a signed value for a reference count? Shouldn't it be unsigned?