From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest
Date: Wed, 7 Oct 2020 10:13:38 +0000 [thread overview]
Message-ID: <CY4PR1101MB22969F6E2619E7B07A99971E9C0A0@CY4PR1101MB2296.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201003090541.32449-1-jay.jayatheerthan@intel.com>
> -----Original Message-----
> From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Sent: Saturday, October 3, 2020 2:36 PM
> To: jerinj@marvell.com; thomas@monjalon.net; Rao, Nikhil
> <nikhil.rao@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com>
> Subject: [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest
>
> From: "Jay Jayatheerthan" <jay.jayatheerthan@intel.com>
>
> adapter_multi_eth_add_del() does vdev init but doesn't uninit them.
> This causes issues when running event_eth_rx_adapter_autotest multiple
> times.
>
> The fix does vdev uninit before exiting the test.
>
> Signed-off-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
> ---
> app/test/test_event_eth_rx_adapter.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_event_eth_rx_adapter.c
> b/app/test/test_event_eth_rx_adapter.c
> index dd3bce71b..71c946164 100644
> --- a/app/test/test_event_eth_rx_adapter.c
> +++ b/app/test/test_event_eth_rx_adapter.c
> @@ -464,7 +464,7 @@ adapter_multi_eth_add_del(void)
> int err;
> struct rte_event ev;
>
> - uint16_t port_index, drv_id = 0;
> + uint16_t port_index, port_index_base, drv_id = 0;
> char driver_name[50];
>
> struct rte_event_eth_rx_adapter_queue_conf queue_config; @@ -
> 484,6 +484,7 @@ adapter_multi_eth_add_del(void)
>
> /* add the max port for rx_adapter */
> port_index = rte_eth_dev_count_total();
> + port_index_base = port_index;
> for (; port_index < RTE_MAX_ETHPORTS; port_index += 1) {
> snprintf(driver_name, sizeof(driver_name), "%s%u",
> "net_null",
> drv_id);
> @@ -513,6 +514,17 @@ adapter_multi_eth_add_del(void)
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> }
>
> + /* delete vdev ports */
> + for (drv_id = 0, port_index = port_index_base;
> + port_index < RTE_MAX_ETHPORTS;
> + drv_id += 1, port_index += 1) {
> + snprintf(driver_name, sizeof(driver_name), "%s%u",
> "net_null",
> + drv_id);
> + err = rte_vdev_uninit(driver_name);
> + TEST_ASSERT(err == 0, "Failed driver %s got %d",
> + driver_name, err);
> + }
> +
> return TEST_SUCCESS;
> }
>
> --
> 2.17.1
Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>
next prev parent reply other threads:[~2020-10-07 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 9:05 Jayatheerthan, Jay
2020-10-03 9:05 ` [dpdk-dev] [PATCH 2/2] app/test: add net null dev creation in " Jayatheerthan, Jay
2020-10-06 17:47 ` Jayatheerthan, Jay
2020-10-07 10:15 ` Rao, Nikhil
2020-10-06 17:47 ` [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth " Jayatheerthan, Jay
2020-10-07 10:13 ` Rao, Nikhil [this message]
2020-10-08 9:32 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1101MB22969F6E2619E7B07A99971E9C0A0@CY4PR1101MB2296.namprd11.prod.outlook.com \
--to=nikhil.rao@intel.com \
--cc=dev@dpdk.org \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).