From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5B81A0562; Fri, 3 Apr 2020 12:21:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B1CCF1C0D4; Fri, 3 Apr 2020 12:21:35 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4DEC11C0B8 for ; Fri, 3 Apr 2020 12:21:33 +0200 (CEST) IronPort-SDR: 9qVJvvGLxjNf8rsVH7Lov3RhK0ji5fQJJri0ot9BgVq8Ooxj9lumLcUWahGKbQAPqkWueQ6ZlE vPRznuTDhbEw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2020 03:21:32 -0700 IronPort-SDR: 0jLZ43rfWh4pImsSxs7fjAzK7Wqg3F45sj8L6juAOdlK/KtYds7tlC2WYDe5nh8EI7mdQu0nb4 N5GcE5thZpVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,339,1580803200"; d="scan'208";a="396689687" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga004.jf.intel.com with ESMTP; 03 Apr 2020 03:21:32 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Apr 2020 03:21:32 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 3 Apr 2020 03:21:31 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 3 Apr 2020 03:21:31 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Apr 2020 03:21:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jGuh4KJDEeCqCK7nBEYkAEa1NED19VNVwcaN1yD/TAmgyazYgKxCz+BR6oAdQL39NiEGCmr72ud94k8V2p97PRGHhI74QO6M+KAoOTKezGW0mCLjTghzTEb4WosQuYjJL4EPyuwWvP6uI53zWvlb5kDwDGkZmolAPwhs8ORplvBbY1LNVWWZapjcG0oMbesZImn1z1x4wrsftjlQFAPLsi64c71v+Q96xWZf5Y7o+mjQLnRwNUa13LLL7XFJBjBeYRDNqOtOlyxe3i3YqCxGebx121KPu83FXRrKAI941DwYU2qdyavb6Xlh89r9HyktWJEa9qTD1uaAan+uacIyTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7n6cv0a0z7WB7w+1ET1HGvTw0hlu77LTi6RoArN7RNY=; b=egp5nZdzEpDAodLiVja8+6F9PCnj6wq5jt0WakspND6VnYZ65/yHNP5YNvXu0lriw8UIlvioR7YqztdeqPXv6KFRUBu+CKIYQ3sy1NdZ+cCJMtZvD9zGFutsRcbdjSQEeFDDIrdDwBbcaKhLJ+bpVVC8YwRMIgpIEeN7S/iDHtPWcM746y2hSaplgea8E9cZ0w3AYR17my1z3N6SZY9DrgD39bkCIh7BfNiK+mbF9X0Jzv62KpSk9aM0qoCc3ZcMNKQi3dHnw7JiOVRQOKr/SsWHbJtsKGChvjnaXYOWcTqnIRMmlJxMHWgnJWnttBv4hZOggbn3S9VKHgFDWtTLQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7n6cv0a0z7WB7w+1ET1HGvTw0hlu77LTi6RoArN7RNY=; b=JIhvtMDk6mdzReZVp8LUwt1XGbpQ10tYDTPjjYqiXpMIEe7tOqBLJC2M6oN75aExetdyi21VMKLkwGHWmIRp6FCyi91R3xn+EX74G1yhaluo10uOK/Z2B7fiy63fo70WnybHs7/t5c+afzaefQEaSy7PRwhAbT2yAThQKVHwUXM= Received: from CY4PR1101MB2326.namprd11.prod.outlook.com (2603:10b6:903:b3::23) by CY4PR1101MB2104.namprd11.prod.outlook.com (2603:10b6:910:1b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Fri, 3 Apr 2020 10:21:28 +0000 Received: from CY4PR1101MB2326.namprd11.prod.outlook.com ([fe80::58c7:7df:1b11:9c56]) by CY4PR1101MB2326.namprd11.prod.outlook.com ([fe80::58c7:7df:1b11:9c56%4]) with mapi id 15.20.2878.016; Fri, 3 Apr 2020 10:21:28 +0000 From: "Shetty, Praveen" To: Akhil Goyal , Anoob Joseph , "dev@dpdk.org" , "Doherty, Declan" CC: "Iremonger, Bernard" , "Ananyev, Konstantin" Thread-Topic: [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature Thread-Index: AQHWCPQpLqUoUgdSfEq3yQYJ22MHy6hmGf0wgADBegCAAAqngIAASIGQ Date: Fri, 3 Apr 2020 10:21:28 +0000 Message-ID: References: <20200319162145.28906-1-praveen.shetty@intel.com> <20200331130211.24761-1-praveen.shetty@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2I3MTUyMWQtZGRmOC00MDJjLThkYjgtMDdlNjc5M2Y4MTc0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYUs1TkpkZHYwOHVldERWTGs0dFgzNXhjcHZaMG1HOHdPSHpBVmNMbXQ4Y2FNMXBVVFcrakV6aE51WWtSbWY0SCJ9 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=praveen.shetty@intel.com; x-originating-ip: [192.55.79.108] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ede8b747-0075-4f50-6dbf-08d7d7b8c5b9 x-ms-traffictypediagnostic: CY4PR1101MB2104: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0362BF9FDB x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2326.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(376002)(396003)(366004)(136003)(39860400002)(346002)(7696005)(316002)(107886003)(55016002)(9686003)(186003)(6636002)(76116006)(71200400001)(86362001)(81166006)(66556008)(66476007)(4326008)(110136005)(54906003)(478600001)(33656002)(8936002)(66446008)(6506007)(64756008)(66946007)(2906002)(5660300002)(81156014)(53546011)(8676002)(26005)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dFcENJoIx/IeYCqvlWQleeWziywqd09X7IyIc4v3keh11RuN8AgMs5rLrQNsrdz97iZm4xWOjRDB7/UTStSIxeIxu4X5P8fqkBvZIeR05SMehHtXWBX77TErX2Pk9QdJjMl5zy8jMaX9Z/TsX1UHviv7AvBvN/sPlkP7jAUgHpxQrR0wQk5S6vHHlH2CxD8Z/FF4wMysnioWFtysJraXTuH8rzJ4rrXcXtiK9gSPGgDKL9/pWR+WdSSVT2o/+tLjbCO/Ct4mDz0KEpPU6ZQk7AeNE4SGaa/gcIJHLTRr99eZzwUjJCgREG4ofoORoaGkGMCaoPPCm6jH4jX0exbWSJCcklw5YtWRBVdb94Qy/Cx+LE2Ypo4+pgB7+C5Ghww331SOrqUf8nOWanskg0uOzZQEaHOTfAeBL8n+RfdVHB0R5XvUjLVgqByJFUzwtwBe x-ms-exchange-antispam-messagedata: eU8IwhyfCWGLYOB2P6OPGg/ldkKjQpWbHoNAS0LceMapgYCtFm3Zcqe0mol0W+bXhwywp1u9yf4wbF66Aoi6PpnabgiPFDOMMOAs5QM+K93PXKcwG3lPUKk575guZBTuKdwtqEGbvpGWSXF1N9888A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ede8b747-0075-4f50-6dbf-08d7d7b8c5b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2020 10:21:28.5303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6wr3TsNvOTron13g1G5rUF1SlwmmRYPqtjjIPwzbX/jGPKd6jcT44tyAj+Kd0Ug5oFzZM7vSG9Pughpge7Ut8l/b9SzuBj7u2uKgBYbYhxM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2104 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- From: Akhil Goyal =20 Sent: Friday, April 3, 2020 11:22 AM To: Anoob Joseph ; Shetty, Praveen ; dev@dpdk.org; Doherty, Declan Cc: Iremonger, Bernard ; Ananyev, Konstantin <= konstantin.ananyev@intel.com> Subject: RE: [EXT] [PATCH v3] examples/ipsec-secgw: support flow director f= eature > > > diff --git a/examples/ipsec-secgw/ipsec.c=20 > > > b/examples/ipsec-secgw/ipsec.c index d40657102..76ee9dbcf 100644 > > > --- a/examples/ipsec-secgw/ipsec.c > > > +++ b/examples/ipsec-secgw/ipsec.c > > > @@ -418,6 +418,73 @@ create_inline_session(struct socket_ctx=20 > > > *skt_ctx, struct ipsec_sa *sa, > > > return 0; > > > } > > > > > > +int > > > +create_ipsec_esp_flow(struct ipsec_sa *sa) { > > > + int ret =3D 0; > > > + struct rte_flow_error err; > > > + if (sa->direction =3D=3D RTE_SECURITY_IPSEC_SA_DIR_EGRESS) > > > + return 0; /* No Flow director rules for Egress traffic */ > > > > [Anoob] Any reason why this is not relevant for Egress. > > > > [Praveen] we don't see an use case for load distribution across=20 > > ingress queues for outbound IPsec traffic therefore we have limited=20 > > this configuration to inbound IPsec processing, as this is the only use= case we can verify. >=20 > [Anoob] Why do you say load distribution for ingress queues is not=20 > required but is required for egress? I would say the use case is the same= in either direction. >=20 > Said that, adding just egress should be fine. I leave this to Akhil's jud= gement. >=20 I believe it does not matter for EGRESS in most hardwares, INGRESS flows sh= ould have distribution. I think your comments are just reverse but The code= is inline with my understanding. [Praveen]=20 Current implementation is only for ingress traffic load distribution theref= ore it is applicable only for inbound IPsec traffic.