From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98205A04A3; Tue, 16 Jun 2020 13:52:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 932151BF74; Tue, 16 Jun 2020 13:52:41 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 93B111BF70 for ; Tue, 16 Jun 2020 13:52:39 +0200 (CEST) IronPort-SDR: Mv0aTKXXQhqw06BIb+hukrcENw8fq5wPcbhitYjqGCQdc4XZgp+RuOHo4u7aWgE8/cGRHBXOcA ylwajQtzGY8Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2020 04:52:38 -0700 IronPort-SDR: v+2J6Dbv4oKXsPm4hbwN9KhHpUZstLNcRefTPORCsqiJDWnHYst95hZ6dZHTiVfX6MnPSkkNpC 31SMevckMomw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,518,1583222400"; d="scan'208";a="261403955" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 16 Jun 2020 04:52:38 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 04:52:38 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 16 Jun 2020 04:52:37 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 16 Jun 2020 04:52:37 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.57) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 04:52:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KVMLnvvV1Ls+fvlOxq/m1dFBwLqalObOzdJDZDLnYNWvXn6VXefd5BqtgbH84IYgHR1Z4EpdBgJd0gUGX+9nfW1UPnnGiAbxBO/K2D6KOMe2YJq1DuXP7QDryM2rBJlIQ/bP6WTQJoCwXQ2+HzVWV88hFL4BV6mDrbqZ20c02ktgAVnr2ZRqinNP1/V8kiHNTY0MwLVKQWwPMf++ZpwL59IPZjsuZekDGCPRIfj5yLT30wWfcq3XJxC9DEk1Gy1HoqVgzAGJGs7XAOSsqPzsoHI7p6b0yCkB3HcUxWXbxTKBC4nstfQpciNRrE7TZ1ugLtWb6TadGHf5gjU4JzBUEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JKaBeiDoO/Q1XT6NJ0eFNlgwZ2Jf7NBVQ1/+2S1NNfY=; b=NStvK9mEQFkiIpbN6qGwOry+vQ+3wFmGs5pPDxhHr4GZo692NH5RqAV6ypaOhRdezYKpYgLjzIs0K2Mw5OgC82E97IAL9IKzttmAOckeLSWqmoOhSAqucvyNfGHIJbopxjV0V9TnagHWA37+ExY6a9rHH7vzPgXtdmK7TW+UnTQ+oN5oCZ8CjO0po/oXavkzrO9RU5IFWLgliAdWqZUmQZUUgQc1h1G/srmhrlhOK7XXdk1JyMNcOhclUMtgA47SHguxA0DqtsKEjdQK2SJAPTiiMa/MynHY6yf7F5HBXBCEyKOMllW/Hcf69qNvRGH6fXysVDJTFh+VeTwKjXQqbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JKaBeiDoO/Q1XT6NJ0eFNlgwZ2Jf7NBVQ1/+2S1NNfY=; b=FTXrd6S9EhyAYzDkuWdQSG9RG/GLNAquC1wDZZZxqmKYQTMLjuvJ2J9mZ7ck779qLXyCYUwlzdWLdHwMWNMNQsvm5LdERWDHrOgIBeKyYFiqoyhyAgbcDjcoVFoHC727HzbCI5s3p4D49Hu/i2r0BCyogY/JYpbuNTvbYTdNmoo= Received: from CY4PR11MB0072.namprd11.prod.outlook.com (2603:10b6:910:76::27) by CY4PR11MB1544.namprd11.prod.outlook.com (2603:10b6:910:d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.25; Tue, 16 Jun 2020 11:52:35 +0000 Received: from CY4PR11MB0072.namprd11.prod.outlook.com ([fe80::e979:a537:4a97:afd5]) by CY4PR11MB0072.namprd11.prod.outlook.com ([fe80::e979:a537:4a97:afd5%5]) with mapi id 15.20.3088.029; Tue, 16 Jun 2020 11:52:35 +0000 From: "Singh, Jasvinder" To: Hrvoje Habjanic , "Dumitrescu, Cristian" CC: "dev@dpdk.org" Thread-Topic: [PATCH] rte_sched: fix 64-bit support in rate functions Thread-Index: AQHWQzkliKPZx3rkc0Ge9lwVKHBSdajbHGDg Date: Tue, 16 Jun 2020 11:52:34 +0000 Message-ID: References: <20200615171905.5377-1-hrvoje.habjanic@zg.ht.hr> In-Reply-To: <20200615171905.5377-1-hrvoje.habjanic@zg.ht.hr> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: zg.ht.hr; dkim=none (message not signed) header.d=none;zg.ht.hr; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.77.88.168] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 506e8b8f-e19f-4708-8d78-08d811ebc289 x-ms-traffictypediagnostic: CY4PR11MB1544: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 04362AC73B x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p/djLfnkhpu737+BsQHFlaETE/YB7xpRjWmDNoBRYl01aksSG5++4Z9mW8jtovCdmINrt1zxG9jTQ6g86RZK6ExqeVKQ8yRl1cKyChqnSz4pQod9O0kBbBVl0Txg5gJd9NNYW+oJOq+iQxrTcybmTXapnctDYgEzNkBgjVU23O4SLmqArsXp2Zp1jQUgGeI4RuHeQPok2DrTbh/tejjIekfkL1VQ3xfWnvyynAIdDY6fuMbVreKw+5dlsnJjsn5GFr345UmXGjO4tiiMds+2uM4XP0nEAj6WZtpacDWa3gwraTIw27YzvN32b47tz0yAQJ1jN3WTuUPPYpzveqpJ8qOtrF8mm7Go/gF92F3S0PeXAe6d975kIsV0gvzFM+x8KHhH2bW+OWCv9q7PwqE6Gw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB0072.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(346002)(396003)(39860400002)(376002)(76116006)(6506007)(316002)(9686003)(8676002)(55016002)(86362001)(26005)(53546011)(66476007)(7696005)(66946007)(66556008)(33656002)(83380400001)(8936002)(71200400001)(64756008)(66446008)(966005)(52536014)(2906002)(478600001)(5660300002)(110136005)(186003)(4326008)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: MaKGLn4wmRz2eq46Es30DNLAC6mwBqs/blCz+lmyHNMAQ0aQmTOFbir0G/MtRw7Wsk8iAlReCJ4jl+8sCItBZSuwfagkU93SavwxBNh4M6sydhSQp8DJwKBHqGc6nIGpe+FMMv8ekk5hgQKh9N5Dap0VRBsFVXIAHrq8Z+m/C41JYfh+tO6gANWFS782Y1KP8Bz3ZgcWILbUdA0OIce/ySSrWbnWfx4wVAvkfhBqlZbzQYVC7820nEqWMkJiDps1kwMXd2be+o5jC1TOv3MzcwBpOmWL29l71GMYpOqecrV7/zv6o/kPqOelEdZPDxuDOzS7d1WZDrpo2n4ihRxB/0sZRpch57S282FIb94kL74oRqXr1PbPhve0p+MUl0He+hMZEVN6ktX2lT8N/xPkWJRxEhAJgbDqSsrOSxuL8A56POkdIJX9lw8Jyx3mpAzB3CJXg6zeHVUetxVVgOXGeAf+7OaFViphIlcVQdzpFh8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 506e8b8f-e19f-4708-8d78-08d811ebc289 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2020 11:52:35.1336 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1RGeCcbrOrDo7xwOPtvOOPGoTRnsgiT2CQFMp0qxC3o3C67Wivsfx5LL/Uwo3RjuD933+mw3+bt1GaY1TJAz807DECpDecDCTTmhnYx7qZ0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1544 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] rte_sched: fix 64-bit support in rate functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Hrvoje Habjanic > Sent: Monday, June 15, 2020 6:19 PM > To: Dumitrescu, Cristian ; Singh, Jasvinde= r > > Cc: dev@dpdk.org > Subject: [PATCH] rte_sched: fix 64-bit support in rate functions >=20 > Functions rte_sched_subport_config_pipe_profile_table and > pipe_profile_check should also have increased rate arguments. >=20 > Fixes: 68c1f26d4236 (\"sched: support 64-bit values\") > Cc: jasvinder.singh@intel.com >=20 > Signed-off-by: Hrvoje Habjanic > --- > lib/librte_sched/rte_sched.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c = index > c0983ddda..be822057b 100644 > --- a/lib/librte_sched/rte_sched.c > +++ b/lib/librte_sched/rte_sched.c > @@ -304,7 +304,7 @@ rte_sched_port_tc_queue(struct rte_sched_port > *port, uint32_t qindex) >=20 > static int > pipe_profile_check(struct rte_sched_pipe_params *params, > - uint32_t rate, uint16_t *qsize) > + uint64_t rate, uint16_t *qsize) > { > uint32_t i; >=20 > @@ -624,7 +624,7 @@ rte_sched_pipe_profile_convert(struct > rte_sched_subport *subport, >=20 > static void > rte_sched_subport_config_pipe_profile_table(struct rte_sched_subport > *subport, > - struct rte_sched_subport_params *params, uint32_t rate) > + struct rte_sched_subport_params *params, uint64_t rate) > { > uint32_t i; >=20 Hi Hrvoje, Thanks for sending the patch. Few days ago, similar fix was proposed https:= //www.mail-archive.com/dev@dpdk.org/msg168579.html=20 which I acked. I think that patch is not applied on DPDK yet but will happe= n soon.=20 Regards, Jasvinder