From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 185E6A0543; Tue, 21 Jun 2022 10:18:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A4AB4069C; Tue, 21 Jun 2022 10:18:08 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id BF33340151 for ; Tue, 21 Jun 2022 10:18:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655799485; x=1687335485; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yeqWj9liVudqBKXZb0cy0w5eljVvsgegxUhN5qCgHmQ=; b=HDszTph4B3V75qIe+JY4lUBTRz2CzTJWHfBLi70vRhxwFeJ9MXWxsIUX hqkfqsp1DEzCGNDbXTVjusL9JnDPNdSQRjohWE5+L3gDGXXktr64gG2I+ NXRkoaa3KThojjILwFrzcPT7WZT8f5u0Q0M9Rf5DgFQgGRriV83bx9FdN i/+vQ6ldM+4Iis9fFIZSmS9EyF+tSTAVlJ7VEiqTt3Ag0nLB0OChKaQIz qd9j97KeG/D6rNZ/bNSnU0BeFjY3y1yr5rRpy7/z4CiGl5IpPAC2MvxAb cOqJu643f9d0fUQhf9IVxP8TdKt5cVCBISkdqgQiY7YoyFFYubXte0We8 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="259882030" X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="259882030" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 01:18:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="676894672" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jun 2022 01:18:04 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 01:18:04 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 01:18:03 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 21 Jun 2022 01:18:03 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 21 Jun 2022 01:18:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kHcx9P7fJVetJQyKEa2Fe8FkcP+6j5TxT9PD84WEGuIvP31AceVLHGOlrWtatTueJrokmGjQ6o8Zq6CCNc41tPQXtpe/5uljKkc3bB6ISGVjnLT0XnhYJ9XrxOF3jhk3sxXNrtonEYW9lZIJwoQGHoq3n1Wo+IvHrkUWknHa/nPITmh3xPSWu3rTqQF/VYNkFRwsdVnX0r70N3oErjET1afxEGrmBT6rM9gytVIV8YBq4PD3zG/r6XtFpXXEVJS/bRudqP0o7TUozHtMMzfot31yCOL3ABIIv+wF6YohJJTE+R6CCz42VlP6QVUkY8CF9TXkHRWL8opG23hLefZVqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kcj/kPE5S71Vj51ZDqoE02tzRkvOYLLXpE2cIImBv2E=; b=dCzsJ4xAgDS0OS7eSZJtT1ka9c2LDHuHFBq1b2qM4PY9dlsPJbzGxwhDaX+98d4SQ4XWI5wVFuep4XwmDrscyxS9+r4of881W604IW0g/PeESxXl4ytnH+IqXEkcvLdRXEuLLQ3OxpFegKmGWJMAfdDxn3tSlW/tDb6zRjsaF1XJGnD2xY6mfZS03WUdEVr7kafBwfu1vh2egmmIQB6DbyRwR6nlLW5lt2WdgIUTw0XRIx+T4ZqueaYEK5A9EnpVNlU4DE6Lpc8kd0y/dnzDE6gCLyJdLM0WdJc2rL2Xgi8hy33AdejvgAiPyYDpPdX3XMJ+2I63rspZMHWpptKCDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR11MB1589.namprd11.prod.outlook.com (2603:10b6:910:e::13) by DM4PR11MB6358.namprd11.prod.outlook.com (2603:10b6:8:b7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Tue, 21 Jun 2022 08:18:02 +0000 Received: from CY4PR11MB1589.namprd11.prod.outlook.com ([fe80::957b:7559:687e:bcb3]) by CY4PR11MB1589.namprd11.prod.outlook.com ([fe80::957b:7559:687e:bcb3%12]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 08:18:02 +0000 From: "Singh, Jasvinder" To: Stephen Hemminger , "dev@dpdk.org" CC: "Dumitrescu, Cristian" , "Wojciech Liguzinski" Subject: RE: [PATCH v5 2/3] rte_pie: remove unnecessary floating point Thread-Topic: [PATCH v5 2/3] rte_pie: remove unnecessary floating point Thread-Index: AQHYcT7/AfSTNxzbWk20Q1t3gz3ZOK1ZrBzA Date: Tue, 21 Jun 2022 08:18:01 +0000 Message-ID: References: <20220524184623.480646-1-stephen@networkplumber.org> <20220526202653.99796-1-stephen@networkplumber.org> <20220526202653.99796-3-stephen@networkplumber.org> In-Reply-To: <20220526202653.99796-3-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dcb6ebab-81f2-494c-f29b-08da535e8efd x-ms-traffictypediagnostic: DM4PR11MB6358:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M8kimaPsY3eiwg9dLiwQm2hyxptSAJ2E7gXYDWzjmx2ok1A70yjEkd03EGW5rig+YPssN8RYDbgn4tuPRaQ6Eq4inCGEwKGRwFJVodods7mTv4MWZ2lWsq6dZJzjrv5mzpKMhj6XYUVTPndyYBA+3TlGmYx6Kc6ayPh512EtEYQN3ml7Po4PpanMus7l2hxCZnw8AgqHIOxCBNIkL4brTD1o+W3i9X4F1+19w60T+ZXgfRSMMCKD7FZ8jNv3BktagcOW10Ww8LKdPSvF1CASGxUUbR9aMFAHcz4oDXrwUGtcEDn4gDhhKXW84u4PTDOvkSI3wswX4Fv+w3nRMsNHsJI3z4abJ+7qTI3h4TIilRoL+UmcsbqKBePxcspdU5Fd4AZthFB8e9Px0ORPqNJ4mlDWpgdc9daW9JYTt09iJtDLPXBNcED2MqCQFuuO/Myx7PN3lRl7Dg4xL36lZihUTWou/8uaewxz+LrJ1iz70n4U8Z1BeCY+e2XgOvgi6/AOy6zMsGG7jFb4JMUNtpan04kHFr1/7/lDdyWCx3I2gaOpmUzh62Lnry9kh+IPPGh5ipYsgBEfE9MR84eYB15dbZAUls2PWd5jHJX2xe2v7H3a3PVGVLYdmSN5TFps6qxWvI/69PXi0vMaxoYb5gos9ZE3zQzGjVl4DUq9xnDCLZfzVDdhDoLPq+x6kaQmcNIZwAMJXe/27oip7s+jKrW1wg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1589.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(136003)(346002)(39860400002)(396003)(376002)(38100700002)(55016003)(5660300002)(186003)(83380400001)(122000001)(33656002)(110136005)(71200400001)(8936002)(52536014)(9686003)(8676002)(107886003)(53546011)(41300700001)(26005)(2906002)(6506007)(82960400001)(7696005)(316002)(66446008)(76116006)(64756008)(66556008)(66946007)(4326008)(54906003)(478600001)(66476007)(38070700005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Sk64JnH6KMTBb7bnpKYxeHe5dOWpUVaZvSljCKu5a/1SGu6kI8slBNBF6ABL?= =?us-ascii?Q?3UEMsS4tb6JVmrSxcMG+nwYwEvOulkbgxe5MCXZrpJ3btUaiV/COnP5WekO0?= =?us-ascii?Q?P0/BAsbxEnARvypiGynx2uyahBHJny93Ze0LUzQoeMJakOOOZnABpzBggN2g?= =?us-ascii?Q?Oudfd1HJtkBsudYyVcy1wPZvuUcJlb95QdI9/vgWojDgfU1mZvGOtgyRUQbW?= =?us-ascii?Q?ODwHdfUgCm4wHrNPD3oK2dvTD0TjMqrO3n26s6SPCA/fDYFy3SKQJKVHfFEb?= =?us-ascii?Q?X7KUOaGKAHBhwC2xxUD0qLej/dUfwp/ERUMQo+NbRLFrs2lhcbcwZddedaB4?= =?us-ascii?Q?XeumeYBpMFKl31wxFmnvC4cpuc0YknVDYoZsjSvnXdHpCPQTrzfT5wPiXa9I?= =?us-ascii?Q?6dlBJGGy2aUZBD3mJHPBt4s+IPvpMnZeU/MZgHliWZbUjmKaxMcQYXWEr4ds?= =?us-ascii?Q?pVKF1PLoDeGSTX7t7osAYAyPGTeJ8LzemEzxhSGFMG31O/XMXRw/gwlEuh/J?= =?us-ascii?Q?SmE9JEpiMoTpauZGdL3tf0ZUKi+SEhJcoCs0Uqpa6nFbDmeAvnsvicSOA1eP?= =?us-ascii?Q?9ltl6G29BG8TnKD65ubG15P4WXdnAJEVMN+kWbBC8BeblqorkSzsp8pZlNF0?= =?us-ascii?Q?GdLHklWCoeBy27TjCzf2YWmdzIEmdKe5EdNwwYFv/IwqK5GoFdU5Pq3WNxB5?= =?us-ascii?Q?lsRyEr2fI2l3Mt4smqUIEVFBa96aTuITXReLvSKQwzfEPHPcd5BglqpFvVEG?= =?us-ascii?Q?mbkZuyK4SDteCSWTPqCrYyZJjscZ59+MhNmNnArjwnPzwn3ZCLNmbIl8T2Z7?= =?us-ascii?Q?nLUG6CIAKS0JQZ6372KbcFJO2TswJXtMyQKiIJzVtxsmSYz37ksLOL8FREB3?= =?us-ascii?Q?zjIReTup6ptANeauTQglQQXzMo7GZEvh2Is0GNHlzRRK1m/a/fdE5GiZ6ygI?= =?us-ascii?Q?gcVfR+JJz/9TQ2rz9yfsKNa5SZf4B1uh/9XQjqMeA6DXyuaZsmi1aZWeUyVQ?= =?us-ascii?Q?dOylUldVPalVBKMuVbH7FUavptblfc3SRz7z+tbXxY28/EbGRtSH6OosyByh?= =?us-ascii?Q?nj0VF6d5DLceXSzWKSafEW7xWRN3z1WpZ6GH0isusAeR+WMmgUQawCPV+yJQ?= =?us-ascii?Q?FWHM9I4gjua+OqxN2wqsr6kcu4NxehSJimjVRWFiZA3/lcvV/K5c54Y70O0e?= =?us-ascii?Q?22Ex9GgnN3/zU1LnZzF6Ggfx8BGJcksnYQzbema94/9lQ8o3+1RYTtEhA82k?= =?us-ascii?Q?2pzM4RieBrMDeiKMAYq9XuAgQZkShYdLSpwxxKtw97lu8Ds+YvOcN9o9ED7H?= =?us-ascii?Q?xO6qTFLjC+P5RteK/KoMlrXFdz8xAWPHvvt4SNlPKqsqoAIN7Ap9YLmVxpU1?= =?us-ascii?Q?Rfqbr/y4Y7S0gkkWvBfd6M7Mvn0TMhj7W32olCsIzWFfRI6Ie49yr0FtqycE?= =?us-ascii?Q?Esf1zXDhi/O43dbZVB30qlj/g31T2ZoUN66gAyVNyMrm3FgEwe6Y8EBGsHLj?= =?us-ascii?Q?Ql+c0FK/Pl4rRmw5BPaKiN5FTQiuWNxaIZRbGK/7+PhqnSWt8aUnC5Tl+iOj?= =?us-ascii?Q?0arA7fxCg2etDsc/QtjI68OHvMljdtV4RQ5QPhibSCIeZsO/IMGu1fitANB9?= =?us-ascii?Q?/aE9E6WiRruT3Vryp8F0X04iLJOnewHXMgIoNqkWZ0wESeJVm2nzxFm2NcN2?= =?us-ascii?Q?6nBymeywy7AXARCCh2lvio8t/3CQTWVTanHylWdAd/iBs+xbipx4dnzis2aU?= =?us-ascii?Q?Oc2JMjv+zLtV8DyQkH8D/fB7oE2Y8wQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1589.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcb6ebab-81f2-494c-f29b-08da535e8efd X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 08:18:01.6760 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KELr8RqzdOicSfqpfuh4RUjVuxeWFNmKAUAtd3p4WdD/Av/74CNcGJuGmaJXaobofKryWGjSoY5+owbEeTFVfZPXFO7lbj+8pqYf1hM5TwQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6358 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, May 26, 2022 9:27 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > ; Wojciech Liguzinski > > Subject: [PATCH v5 2/3] rte_pie: remove unnecessary floating point >=20 > The qdelay variable is derived from and compared to 64 bit value so it do= esn't > have to be floating point. >=20 > Fixes: 44c730b0e379 ("sched: add PIE based congestion management") > Signed-off-by: Stephen Hemminger > --- > lib/sched/rte_pie.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h index > 02a987f54ad1..3e2c1ef46721 100644 > --- a/lib/sched/rte_pie.h > +++ b/lib/sched/rte_pie.h > @@ -218,7 +218,7 @@ _rte_pie_drop(const struct rte_pie_config *pie_cfg, > struct rte_pie *pie) > { > uint64_t rand_value; > - double qdelay =3D pie_cfg->qdelay_ref * 0.5; > + uint64_t qdelay =3D pie_cfg->qdelay_ref / 2; >=20 > /* PIE is active but the queue is not congested: return 0 */ > if (((pie->qdelay_old < qdelay) && (pie->drop_prob < 0.2)) || > -- > 2.35.1 Acked-by: Jasvinder Singh