From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dharton@cisco.com> Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by dpdk.org (Postfix) with ESMTP id 3257A4CAF for <dev@dpdk.org>; Thu, 7 Mar 2019 15:02:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2444; q=dns/txt; s=iport; t=1551967322; x=1553176922; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=mN0OO74RH3sqe/hb1tI+6DptIiIXfDgra81dIkrSlds=; b=mCguAtSHHGMwZYN0yg+VEbj/ZPjeOgtbf7BMK1ohNWnPlJaaewzTNVUa e3HB8k0i6cT0eW12NWh7PisfIusotQ2CXVJ4Gixqtjcs18PfBthWohSf1 fS8/1NcFPAzi+wJ+vs2OFp8V9OIA+IU6SMEXgCisw3q/wmcV84EQLQmEf E=; IronPort-PHdr: =?us-ascii?q?9a23=3AwueTnRQvDZqAQu837uxEXCXNMNpsv++ubAcI9p?= =?us-ascii?q?oqja5Pea2//pPkeVbS/uhpkESXBdfA8/wRje3QvuigQmEG7Zub+FE6OJ1XH1?= =?us-ascii?q?5g640NmhA4RsuMCEn1NvnvOiA6Fd5eU1lN9HCgOk8TE8H7NBXf?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AMAABtI4Fc/5RdJa1kGwEBAQEDAQE?= =?us-ascii?q?BBwMBAQGBUQYBAQELAYE8UAOBXAQLJ4dQA4RQil9Kgg2YIxSBEANUCwEBLIR?= =?us-ascii?q?AAoQ1IjQJDQEBAwEBBwEDAm0cDIVKAQEBAQMnEwYBATgLBAIBCBEEAQEfCQc?= =?us-ascii?q?yFAkIAgQBEgiEeAMVAZ9TAooUgW0zgngBAQWFAhiCCwiBLwGLKxeBQD+BV4J?= =?us-ascii?q?MhGkagzmCJqQXCQKPA4QZgiGRFIpxkjgCBAIEBQINAQEFgUc4KIEucBWDJ4I?= =?us-ascii?q?Kg26Da4ZocgGBJ4xpAQE?= X-IronPort-AV: E=Sophos;i="5.58,451,1544486400"; d="scan'208";a="534358361" Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 14:02:01 +0000 Received: from XCH-ALN-019.cisco.com (xch-aln-019.cisco.com [173.36.7.29]) by rcdn-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id x27E20X9016557 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 7 Mar 2019 14:02:01 GMT Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-ALN-019.cisco.com (173.36.7.29) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 7 Mar 2019 08:02:00 -0600 Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 7 Mar 2019 09:01:59 -0500 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 7 Mar 2019 09:01:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYj/QRXcnQIIV8B7/5YLJxefnwlAoJAlXs8Na0P28Y4=; b=Aq/Cd/tzG/MDLdX0KAd73If8ANpGzbbDKo4EJV8JKRpuCC5D+kh0i2Am/L9ocmfzX3DTo1W7JJ37MRUIQ5sMDEIZFmm2kmkoBH2Pgj4+OErF+kNeVIyTiG+ryvssNCxqlMQlbzTN/yX9ZshydD6YvYk3tSQBbkvMJ3y9ADyzhyg= Received: from CY4PR11MB1701.namprd11.prod.outlook.com (10.169.250.142) by CY4PR11MB1990.namprd11.prod.outlook.com (10.169.252.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.20; Thu, 7 Mar 2019 14:01:58 +0000 Received: from CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5]) by CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5%3]) with mapi id 15.20.1686.018; Thu, 7 Mar 2019 14:01:58 +0000 From: "David Harton (dharton)" <dharton@cisco.com> To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef Thread-Index: AQHU1DCqntbUNjHtWEesvaYVpO9puaYAJiEAgAANrHA= Date: Thu, 7 Mar 2019 14:01:58 +0000 Message-ID: <CY4PR11MB170162D6FA06FADBCD87E41EAA4C0@CY4PR11MB1701.namprd11.prod.outlook.com> References: <20190306152355.1697-1-dharton@cisco.com> <039ED4275CED7440929022BC67E70611533490C5@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611533490C5@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dharton@cisco.com; x-originating-ip: [2001:420:2170:1264:9e:c249:dc23:778] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 80056c86-d59f-43a0-5bcb-08d6a30576ec x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:CY4PR11MB1990; x-ms-traffictypediagnostic: CY4PR11MB1990: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; CY4PR11MB1990; 23:Beztdb1LQZBTlaVmWnKd3dM0v6an7wCQyUk9A0a3l?= =?us-ascii?Q?BXy6QXTWeVY8vzyTKUePmEf21yQXQK+Z4YREZEowNB8QrOyK61VxKAjA0o2s?= =?us-ascii?Q?q6WsG5DF1s2C87VyAolo5E3U3DEsVlP20qryUm8ngLILq5AWcY52qc50I+6j?= =?us-ascii?Q?AgaJ/De4Uu63GoKXJG1HCUSLD2YUviQyvlkLN5MBh9LY5+g7m44VFpYz+ur+?= =?us-ascii?Q?/K7gtbHHZhWrGjASnZ+w+AmISvkk0eJyttfZctgOUxIlL23bGwoLdx13yQfW?= =?us-ascii?Q?Ghyz00C8YoCtvpEfSUF2t0LmLOjsxqZ8FunqSO49PbCa9CJjO3Xmmzi41EvO?= =?us-ascii?Q?t+LbiXsYN/XeF7+60EFtqa53GRAeJf2OflwSGOecXKATi+t0+IVjQonXSle4?= =?us-ascii?Q?wuYA1LsR2I5xU323P/+il0FyCW9ApRILR9/EBdp/O+ESo+3VOkEB2VolVCBG?= =?us-ascii?Q?2J0k6tnJTk6IHknI7KD15VgTauBuJC4N4q/24ghWNqLM+XRGkktIJ3gr3WFM?= =?us-ascii?Q?I2K9OvMvzAaRJ6qmkXbMHTpOV1QH4vTLkc50w8JJQofClp5DuK3zOGGvNRKz?= =?us-ascii?Q?4Yr3NeEuu8ofSxGGcC97I53vk6isdaOEsox7blxHG1F7v5hlmRYai4TnlCww?= =?us-ascii?Q?oSRRD6v67hy1vT09KIB5EbkFUIbqM0sFnJ27r0+xi3dHYKc4dvw0A0VA2kY4?= =?us-ascii?Q?baubEPgG8AygkbJgsNymK0Ize7PYHpPuU0BiKZLLXSpCjjK6KbCuuEQx47OA?= =?us-ascii?Q?BdAjPb8Dm+vLQUV+Ka2Xf0mktZbZD1Va50j3RtVi9SVvjIr62n7idkbRYIjf?= =?us-ascii?Q?ost50xzxMafnAQHcGnLZoQy8XEjXB8lugvFEihExe8i/e5Y96G6cMESVlzAh?= =?us-ascii?Q?bly+joegyqfZQc4KI/UCg7GwVMnI5D7ADAExTY1C7Wof6V4CTy3gf0+OReLa?= =?us-ascii?Q?SKoMWdV4uu+/addrLJAwHnj7LJTSSGQww7E2ghxmXLbscu7sVCYvMI+3F+4b?= =?us-ascii?Q?S4/ob94BiepI6RnTVr5Y0OdZVKt+Y9fE8Uy4MWpt6ZObzhTA8yOx1UPpiPG1?= =?us-ascii?Q?/Fwo8YJVF7QC3m83v7BQsY6j9H4u9jtw99ecJlTucmXb6hFRwkQrJ5gm/K6e?= =?us-ascii?Q?dlhDovbzKu53DqTd5vYIPMHCIW8PcZrc89vGFlkbp7USI2ssAkMVFveYTHB9?= =?us-ascii?Q?w4Ocx1YLgLO0XVx9f7bQQ/ZuBvRtKT87DmO?= x-microsoft-antispam-prvs: <CY4PR11MB1990FD123673BF97EDCD19C5AA4C0@CY4PR11MB1990.namprd11.prod.outlook.com> x-forefront-prvs: 096943F07A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(136003)(396003)(39860400002)(346002)(189003)(199004)(13464003)(99286004)(53546011)(76176011)(110136005)(14444005)(256004)(9686003)(5660300002)(486006)(33656002)(476003)(2501003)(53936002)(71200400001)(316002)(71190400001)(81166006)(8676002)(81156014)(7736002)(11346002)(478600001)(8936002)(7696005)(2906002)(105586002)(106356001)(305945005)(55016002)(186003)(6116002)(52536013)(86362001)(14454004)(446003)(68736007)(6246003)(46003)(102836004)(6436002)(97736004)(6506007)(74316002)(229853002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR11MB1990; H:CY4PR11MB1701.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dymvdZifDEqxBQjkzS6gZsBPMiQsaHSAOPW+nZLCNRw+xr/4KYPBHBuss08ku9KGoAz3leyESehZJtc5AHlyIKzhnbsYu5HjWNS80VM45h0NUiP5GsxQBKhY6E4mimVp54gUaPpRhojWN+z5OuEnn9wniNOl9gMO4LpCZz5L+5WZl8S6Mzj0B9RNhBo+tfYJm2HrixCjEw8fRRWtAfQHpH5zHRCgeb7mcqbBroq4AfqZWeq3BF5Hs3AUdrV1WRFmFQYkgqqVGJ11gaV2IQrWaSnpxbUycqo+FyOQPbHH7yv2VUr+6aBaEW+a29d0MhPMDUHNneo17X80zxkdkznvB3XBCs7Bib6phrceopc+8jPaa7kQplGcVRhveu2UwgkAuXZuUe7DqLuKZRSoh+855djiIk58N3fokWgk176NbVE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 80056c86-d59f-43a0-5bcb-08d6a30576ec X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2019 14:01:58.2597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1990 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.36.7.29, xch-aln-019.cisco.com X-Outbound-Node: rcdn-core-12.cisco.com Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 07 Mar 2019 14:02:02 -0000 Hi, > -----Original Message----- > From: Zhang, Qi Z <qi.z.zhang@intel.com> > Sent: Thursday, March 07, 2019 8:11 AM > To: David Harton (dharton) <dharton@cisco.com>; dev@dpdk.org; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com= > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > ixgbvef >=20 > Hi >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton > > Sent: Wednesday, March 6, 2019 11:24 PM > > To: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, > > Konstantin <konstantin.ananyev@intel.com> > > Cc: David Harton <dharton@cisco.com> > > Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > > ixgbvef > > > > ixgevf vlan strip and extend capabilities were removed when migrating > > to the bit flags implementation. > > > > Restoring the capbility to enable these offloads at configuration time. > > > > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > > Signed-off-by: David Harton <dharton@cisco.com> > > --- > > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..95c32257c 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev > > *dev) > > DEV_RX_OFFLOAD_TCP_CKSUM | > > DEV_RX_OFFLOAD_KEEP_CRC | > > DEV_RX_OFFLOAD_JUMBO_FRAME | > > + DEV_RX_OFFLOAD_VLAN_FILTER | > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > DEV_RX_OFFLOAD_SCATTER; > > > > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; > > > > - if (ixgbe_is_vf(dev) =3D=3D 0) >=20 > Patchwork shows "build patch error" for ci/Performance-Testing. > Seems this is the only place ixgbe_is_vf is used, so it can also be > removed Yes, I didn't notice that. Assuming people are good with the fundamental c= hange I'll post a new patch with ixgbe_is_vf removed. Thanks, Dave >=20 > > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > > - DEV_RX_OFFLOAD_VLAN_EXTEND); > > - > > /* > > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > IOV > > * mode. > > -- > > 2.19.1