From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F891A04B5; Wed, 9 Sep 2020 21:52:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 445FA1BE0C; Wed, 9 Sep 2020 21:52:44 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 75ABA1DB8 for ; Wed, 9 Sep 2020 21:52:42 +0200 (CEST) IronPort-SDR: ZMv1wIiMM5bkPsztgb/najCzj24SiN+akCfh0PyRfYQnxIkYV2A+44OLaqSnoFqUQ9JmrPPOYB Tf/UAVF722nA== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="219965647" X-IronPort-AV: E=Sophos;i="5.76,409,1592895600"; d="scan'208";a="219965647" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2020 12:52:41 -0700 IronPort-SDR: jcxEpFK+PToZpti3LiSpyBwBrE7Z+ci7uAmfU27CrSJZBv1oNIaqhuM8J0PeBm47ykd4W984l8 4FbnYYPqVj5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,409,1592895600"; d="scan'208";a="317657156" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 09 Sep 2020 12:52:41 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Sep 2020 12:52:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Sep 2020 12:52:41 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.50) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Sep 2020 12:52:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YEb23QTo32VW15hJydEy48bGcswSyggSKDi6AnSEPw1ToReJt7mWL1f2Jhk9317ypuNhy4qJ9IB2ptHo6SujS0ByqWLktdOi9P4MLl3jDY7D8DYJp8M29I1vkBz32zzmzeg+f6+4SatMtkte/1bKmoP8NDii2H2XrNxWrjcnpT168bpuYkj6ZlVlCUQXWVAjLvE91Uwp0K/w6rQb3neBfYGPrPXqoG9ufoowIGzPomXgmNG0DBiI2OjTAVW1v+2dQIvNvbsSxWJdE+NrIQGVt7JfQRUYiyydkIrFOht3gd+VsHH7fk93Q2u0n2fgkK1seC4gVsZDwlz+YymJ8cBwqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XsSHp+AH3R+i/6e4PVxCp26jvwBPVBt56P0OGNn6aAU=; b=gm3TxHbk1fdOWJK6alacknKCNuQw2cw4WE86XB6PCfw761CCTGNkIpJPpMGPkai7H1mnqjp8ZhnIg+onkX5BjuYds9VNrpltsclAnKDw1MwJPykxFbskb+rFASuIfNdt83b2gm/rCrWnNE8yNl8ujlDuIMf2qBfg8+Fji6yMDvIj/xU5v9TUe7sTR7FR8/Gv5long8x0HZdh08VuUH2P+FxC24vAdq5yU1D/3DBlQTRKzkQCa/98nVyN8bw6wzC1Wb9RKFw78i23cmyys9PPfZgjJOVDauWEoxWFKFkkNBjNVFVzHaVgp4QVueEvjG3Rk8t0TOmBQ5vo+705LjF8pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XsSHp+AH3R+i/6e4PVxCp26jvwBPVBt56P0OGNn6aAU=; b=uYkwCx1aFiQCZ7YkQ00vGI/EYmAjcRkn/xKvO37TYPPNqix7pnOVgDun+j9EVv8pnh5JaEnjqqK4XkwLu1MP53UCkbHsMro/O8i52v68wmr9bJMMyH4vwzRx1Shk/+AV3JQw5QmNav0qgxQkjhyjG4oZZLvokNvDuL4SfCzon7Y= Received: from CY4PR11MB1702.namprd11.prod.outlook.com (2603:10b6:903:2e::8) by CY4PR11MB2024.namprd11.prod.outlook.com (2603:10b6:903:29::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Wed, 9 Sep 2020 19:52:40 +0000 Received: from CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390]) by CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390%4]) with mapi id 15.20.3348.019; Wed, 9 Sep 2020 19:52:40 +0000 From: "Dumitrescu, Cristian" To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline type Thread-Index: AQHWhh1qGCAtpA7LF0WsFSebE8ktd6lgrCmAgAAKySA= Date: Wed, 9 Sep 2020 19:52:39 +0000 Message-ID: References: <20200907214032.95052-2-cristian.dumitrescu@intel.com> <20200908201830.74206-1-cristian.dumitrescu@intel.com> <20200908201830.74206-2-cristian.dumitrescu@intel.com> <20200909120535.6d32242b@hermes.lan> In-Reply-To: <20200909120535.6d32242b@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.29.187] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b859823-ed35-4bd5-0c6f-08d854f9e8cc x-ms-traffictypediagnostic: CY4PR11MB2024: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q0utQlMumoBvL5RxyBcLorT1gBwmeh+3yir42PHePFU9cUMOo712HB0m7vZ9jxA/wB+T2oC8JEPBklLhzwFhEGXiUhu8Xa/JDLq8306lmWFr//166iYsmd7ZjDl5PKugAkz2DGzn2Fhlkc7YwpgcZeplXGHLYG2gwHG1vEbA2pj+hTItipFw4YZNPJg7e7vmpzgPMLyXelwtXk3Y4NeTe/0cOB5Z5bvyiKxyYdIJ2ftwLcbYj/IlP2j9UqZqQmH0ASSmJ1CHyhvlitMkX3pWGDIF/KKOzr0PCggGkF6ZfVx1RwtOMvbqYuQmCvJNUZ/qz0rYkKJDdIKc2tTciXjsGQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1702.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(33656002)(6506007)(6916009)(8936002)(83380400001)(9686003)(2906002)(7696005)(4326008)(86362001)(478600001)(55016002)(52536014)(71200400001)(53546011)(316002)(5660300002)(66476007)(26005)(76116006)(66556008)(64756008)(8676002)(4744005)(186003)(66946007)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: /iQYtGUtX622KUuABeleiuGjaSkLElYlGVajJf9i3OcgNu5XwCx4kVXTz6uSxwJIzChCXkCNUXeWLqOvSqz3tjCY0+s2b1KyiamJse2+9imho6XFh4pmpwAMoZFwPt5yAWeprDQ0Z/TClpUQcV4snvZBuNlZnV4lZoyIkWdqsvTsB4j+/Nhj+ugk5L81NBYwvp0SVkLCiz2mNLVCEhLYLNXIeO2koPCPPS7o4kAh53hl+uSStBCipkDKA9SBVu3MTOp7KhRvZ3DZ41e1pMfZs5AtdI2jeUppuvg7+qdVPaz6betdGYP+N6M4Vs/281Ym0HCVkJQjsCtdQA1k9XC2JY4vPdiqY30L79GG5mWo0kEyVztICl9GMKKbw5E993oDLF56pfFFJLNIdvlcaa3WGMV6W6NxewxZzuZEAoqGZ8U0llabFGegdvIRuZeySLU/J0J8/m4TgSpgSsNlZVjd+GeizI9mgeSRdU5IOOrDjQ9GctKCRFNGnuw9vpnKbhcSFnoyigd8fZ+eW91GuPsTV7bxVB+ZllvU4X3CYtMzXJz2G/tcx6TE4PLMcRQqMxwlbXCJh/fZkxjGhrCPDLp5LwhAObHuOV42LLPLgUF9ZVSjxGWHaGjNEdh8gsgeGWIf7NlN9ToXoX5Svg1l9U0KHw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1702.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b859823-ed35-4bd5-0c6f-08d854f9e8cc X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2020 19:52:40.1032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t0AQV5JNqSXcl8iZQLgBkzOKzhIW9p1qSLx5nPGo3yz3SDH1skhVGHuplIgt5xCYiz4RwHggE8ONUwHDUdX/1hKSfxGxmP1VZvXqhdHIO1o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2024 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, September 9, 2020 8:06 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline > type >=20 > On Tue, 8 Sep 2020 21:17:50 +0100 > Cristian Dumitrescu wrote: >=20 > > +/* > > + * Pipeline. > > + */ > > +struct rte_swx_pipeline { > > + int build_done; > > + int numa_node; > > +}; > > + > > + >=20 > Is int the right type for these. > build_done seems like a Boolean Isn't the difference between int and bool mostly cosmetic? AFAIK we don't have a hard rule in DPDK about bool vs. int. > and numa_node should be unsigned? All the functions in libnuma use int as the numa_node type, please see: man= 3 numa. Regards, Cristian