From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 958DFA04B1; Wed, 23 Sep 2020 20:37:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3626F1D926; Wed, 23 Sep 2020 20:37:24 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id BA9391D71E for ; Wed, 23 Sep 2020 20:37:22 +0200 (CEST) IronPort-SDR: pOM1gA1TF0aWWbBQudp6h4y+4LwVJPLQL+yVe2D0m/7b7zA2FFe0C4lscwvSeYt2ag31If0ped AqlnJ2BFSD/g== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="141001386" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="141001386" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 11:37:21 -0700 IronPort-SDR: Mr5Gd9ADztbFK2/xOPCGVlDOx6ScPq1KPANfvif/PgvZLuJIkY50rA3EeRjTs/M3LHedB+XJbj FmDAiTuER6Sw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="511098408" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 23 Sep 2020 11:37:21 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Sep 2020 11:37:21 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 23 Sep 2020 11:37:21 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.58) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 23 Sep 2020 11:37:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oeF7Ti2mLxg/+hawOFUjtiyGFj5tCgS3Q8BLhtZvwuQyY2Qu2brVzijlORjRvl6Mi6p3oR6lUOcFun8PWTF5OqFhyp/llwnrJNJ1Rvkmt92H3C713wQjibWboP69GmSp+o/B0t8tB+Ob/XQI+wc7gWlCcLrGJGHPOAtXM/lAlTE4bood4pQMfMq8lEAfLhldY1Acq5fqDPfu8Ig0ud7Z/KROB7ErjRSZ7D69th1lQThnHeCG8QDuN2hIX5HzYcfsmm4UiZ/6sMTr4DZNp/85j5ujV0PcGTTnFyN3rALbjzeFgrTOgMaUz9hgNAO8MBb5z8ZIUgvZ25SL3kLWVobI2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M0GG/nwSWnSavSVVSREF8UYeKoJX1HwGZRNckC5d/Ew=; b=nw4reRHUzEiPOKvN5kbMGtIU6+o/uvoCSwVeMWbO6PiJ4s19fSymHct4B76yt6G0UmA/0bLSIagGVe4bp8HIwpw3lSj9+tqwnFj/EuSYfmdncYe9SfVKhB+vCEQ1WCpPbmwcJSs/8qLCz5NZ40ykdZbgYl6jxjixuso5d9Xh2g46CNS4BRns9sFN7p9Q3im9MbAZptt+iNyHPj+jEZGIfvONvOA7+djaBDvoe75f9ZQLRphFpNkjBrUy6t2ToRk1SnTTLj/QhIjf/BsqoQyB9SrzIjZlRhvqA60lKh1Pwpsk73/wWVONYsH6Kq4ytwT+fKh0ZCEnbafJSYRxmFOsmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M0GG/nwSWnSavSVVSREF8UYeKoJX1HwGZRNckC5d/Ew=; b=Fzxb7tv5SqsRNj7j3+WdpZRSSCaoYe8BKo16BUpuW5aU+YVK27Th9Sbs/gGx8tTKzT4wewSLxTiByu6FINAXbjOKMkfYUvif9GE+jzGUJLgGJn7yr2Hs0tzo5bLZlOr7TgMTQWc+jSWawdPbtb1MLZvmnSj3w1Q/YRh29xFy2IA= Received: from CY4PR11MB1702.namprd11.prod.outlook.com (2603:10b6:903:2e::8) by CY4PR1101MB2198.namprd11.prod.outlook.com (2603:10b6:910:1d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13; Wed, 23 Sep 2020 18:37:19 +0000 Received: from CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390]) by CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390%4]) with mapi id 15.20.3391.026; Wed, 23 Sep 2020 18:37:19 +0000 From: "Dumitrescu, Cristian" To: Stephen Hemminger CC: "dev@dpdk.org" , "thomas@monjalon.net" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v5 01/41] pipeline: add new SWX pipeline type Thread-Index: AQHWkdRq4zt88MmAUkuUYrZacxFag6l2ie4AgAAB9iA= Date: Wed, 23 Sep 2020 18:37:19 +0000 Message-ID: References: <20200910152645.9342-2-cristian.dumitrescu@intel.com> <20200923180645.55852-1-cristian.dumitrescu@intel.com> <20200923180645.55852-2-cristian.dumitrescu@intel.com> <20200923112438.4b3e1328@hermes.lan> In-Reply-To: <20200923112438.4b3e1328@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.78.180.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 13c9258e-42a2-4649-8e76-08d85fefb3f5 x-ms-traffictypediagnostic: CY4PR1101MB2198: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wsc25KUk7hTsCHa8IbdRl74rz1E7irgKLPj7ja1B5gwyQPe79Qogb2x77TjXo0tALuNBmHrNtyBE2NW7L0rQSAwC6d5Hncv8p8DirFOZz2Rk5GsOA+F8HlmbTUPGavDpNIJt+h8PSewIBN/cz+5Wd3ptlB8UinzDwInazqtzFiqmZMWCV4y9PaiArQwPSnWTOPg6WuaU0Q5uSvKFdysoP8neE6eCnyjpAQGQzj90YFQAjGTZThl5qCXLLxGXN3bHSupP2blu2Ly3GCmqoHJPqwYeyZ4G9FnrUktTrsrgFkwMUEIJ20APY19aKeMnD7yb x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1702.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(39860400002)(396003)(376002)(346002)(66946007)(53546011)(4326008)(83380400001)(64756008)(76116006)(71200400001)(9686003)(5660300002)(316002)(86362001)(55016002)(6916009)(33656002)(8936002)(26005)(478600001)(54906003)(66556008)(66476007)(6506007)(52536014)(66446008)(7696005)(8676002)(2906002)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 2e2IIsmW9WkyZ05ZN88ZqPS+5oGA6IBu9VFQueHRfcXZplCLo7OnvvpW+rOWLbCMpxKPuirtOhzZVgSdB781KxBY5M5AwWdb5H2N4bws1cfOLiF1udAolx+fMgX3jaw7YYI2rKV/VkYe6Af8+EnQWR4/ui/m4tA61xs60jqATIt2LJYrtCF/JaD/vHE9E1eZrulkKvzMB6C8D3jV0qbWA/6NBOi6Uey1u5g8ejncFNW5xxlx8Fh1ZYNGc6SEYwO2gj4+esH+x8+Pts0qrnrQfXTtbHMYjJ87lr2T45Sy22UmXCvR0pG2bEDM+LXSy939Va1eebmD+dSPdSYwJeB3Srf3shgulC8m2eSJM1WhvBTXLWC967/5pGXaAoTWN2uJ+wPwV2OPDodve5lAIgs7T8JjBC5m79gaLZgeF1vOkR0XlEUEWGiYiV5wVqrw+Xyp8NxICWVSxUA75TDbADgHXBUuXHH2i3nVQNgNPu1m1GnzWz5FsarqXEhYhf81dI+yAyRTg3ETbxd+pdrV6A9KlDWxn7J0PHFl2c03b381+VPIWJH+39MkVEakQYVpVkqV4gmmXMgvfWjVpX3oux+5LpAgIeMioYZBcBvbx3GwguYPtqJ3W25XooeHCkOfTgUHrVjlG1H9MX2VIqrKi/rGWQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1702.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13c9258e-42a2-4649-8e76-08d85fefb3f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2020 18:37:19.1982 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NfvV/yUrGywx8Wx2Yg14lfgEOXGWhEB2q4fIEQIhsixn/dBuDfKQ6JwOz+2Hq5K6kIL+9NO0iqBcvvJrX3J5+AtWrEHBxxJlRdXFBcjFGnQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2198 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 01/41] pipeline: add new SWX pipeline type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, September 23, 2020 7:25 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; thomas@monjalon.net; david.marchand@redhat.com > Subject: Re: [dpdk-dev] [PATCH v5 01/41] pipeline: add new SWX pipeline > type >=20 > On Wed, 23 Sep 2020 19:06:05 +0100 > Cristian Dumitrescu wrote: >=20 > > +/* > > + * Pipeline. > > + */ > > +struct rte_swx_pipeline { > > + int build_done; > > + int numa_node; > > +}; > > + >=20 > Nit, could build_done be a bool type? >=20 As we discussed this in an earlier version of this patch set: Isn't the difference between int and bool mostly cosmetic? AFAIK we don't have a hard rule in DPDK about bool vs. int. IMO doing this change now it likely not going to add any value. > +void > +rte_swx_pipeline_free(struct rte_swx_pipeline *p) > +{ > + if (!p) > + return; > + > + free(p); > +} >=20 > The free() function in libc is defined to accept NULL as ok. > Please remove the if() This is just the early function wrapper in patch 1 out of 41, mode code is = added in this function by later patches that need the if statement. IMO thi= s change will not add any value at all here. Thanks, Cristian