From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C7DCA0C4B; Mon, 4 Oct 2021 09:44:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DDA4412C4; Mon, 4 Oct 2021 09:44:24 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id E6FCD412B6 for ; Mon, 4 Oct 2021 09:44:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10126"; a="222773531" X-IronPort-AV: E=Sophos;i="5.85,345,1624345200"; d="scan'208,217";a="222773531" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 00:44:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,345,1624345200"; d="scan'208,217";a="621748155" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga001.fm.intel.com with ESMTP; 04 Oct 2021 00:44:02 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 4 Oct 2021 00:44:02 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 4 Oct 2021 00:44:00 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 4 Oct 2021 00:44:00 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 4 Oct 2021 00:44:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKGISt+cBrQRUYy+7daZeCpbvhgc+hu0/2eQzkc3mUrRadB86HDQpHt6elGab63R/di24fspukCspnoHzgargHvCgrckzhvQg7Wh/MhrM+3C91H0zJEsytwQTJ5xTbmVwMKBcri1S6/wge9mGEq+9cghnJeOEp3msrXYA2pMdCWStzvqOq2Tw7xd9e+pFPfi7zHVFDICzx1vJBEtvuDXcX0Q2oOTHoXNh0573knM1vcwaN3KZL/gDP0QPmNsa0PYsYsYWoVqTOKKsqguB01dYh0XFs5nMLqN+Np3qPTRzmoX/X/MDuw/CIiyRsFhAyx3sB8Unv97B7m0FmzXpJKOnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fxtu50lQSbZWWjqc+ClqUWHjiSy1Q74fNkTd7xskmfo=; b=FbbATQy2k8U1d1v8Mql2Rw4rTGMQ2J3zkeV+5CTKboxq+tuRkuBKUvwNhMSvaWL8RtssQnkkQKCkgJr5SR3gviQpdAS5nyf2f6SUsrQs9N4wWVl1R2nPaoX4MQiJLMB8EP1ydx2RlCphYEe+7cj7X3cV5dpYCAey5uvQr0uSjGCC9MI32OkDOMuKWd1fez5k8IwsqCkWRAb9QapEoBAYxRTlwMht+jjdoOuR3NA0Og/t4D2GlaTz3zEys4eJwnwaxR/4xwAozW8Hf2W7WTpWSnZfZw49u+eHBlGjT/jUbg6iUWFd0RLWxOlQgCzTEcey/Qqp0zw7iu8dLMhYQuYBkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fxtu50lQSbZWWjqc+ClqUWHjiSy1Q74fNkTd7xskmfo=; b=LqMsFS7tvi+XfIGJYyMNtxIwAt51D+UJwUL37z8snPo54PzlSCcXFjp2jlLaW1jQ0Vq5P/sQWBiclcoxM9tQABdhnfvxvzU8aTqJhsrEDJqiYMYldroVHOqP8uhNFoaNeoJvAwbyPekGvcMVQMkSzeDSBA19C5uWvgXz7gfoGak= Received: from CY4PR11MB1718.namprd11.prod.outlook.com (2603:10b6:903:2c::23) by CY4PR11MB1637.namprd11.prod.outlook.com (2603:10b6:910:d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13; Mon, 4 Oct 2021 07:43:58 +0000 Received: from CY4PR11MB1718.namprd11.prod.outlook.com ([fe80::d46b:339a:9056:1122]) by CY4PR11MB1718.namprd11.prod.outlook.com ([fe80::d46b:339a:9056:1122%5]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 07:43:58 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "Luse, Paul E" , "dev@dpdk.org" CC: "matan@nvidia.com" , "hemant.agrawal@nxp.com" Thread-Topic: Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality Thread-Index: AQHXtJGSITZW7noKIU2lsGWVggeKQ6vAQ7DHgAInpCCAAA/LQA== Date: Mon, 4 Oct 2021 07:43:58 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5c8d78c7-69aa-469f-7fba-08d9870ab9a8 x-ms-traffictypediagnostic: CY4PR11MB1637: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9A4Ye6sfKGk/qeEPN6/1V3Kn0wp43UWaEwYkk1BGmXypQCZ7eDT21SInzDKxvpHQiLwZJIx77QXa6Hb5ejeEStyGmwpGoDv0t1nStgjxrQPMTZfErhcwwGwLx5QGfQEmfi9WqyjvAk7OzA5v09LW+9sUf73GUSnN2Ivk287YA6CQNm4bd8e+/gvR+zs0taQPvvGAnH6Wvgulyf/MuqVTNebi3XpZzeqG+G/a4UUqEY7wxpwHWuWtn7XG4T7/v1kaCfXF707qBcj4W7YeHN6YtOK5G36tf6rV3lB/uXT4DwCMpOQCVuK8E42S6VAjumGvcpWFbeSAFWiEuMZSUJ4etiP0i/vf9iW7fcNYuMhgSVpQYh2/R/QP5EUo4GJNE3ECTPjpNk3AYvV/+nx691SCob1v49yMbJfP+VQow2y+oS8ZiHbz9AYw7/z0FWV9iVBm58jKFUV0OIIKxHoUOXroXP0p47pJRHynne6FEduJnuPTPWvWTdv/q0BXq6rvWUZFcM9DFDCb9dKzJP4Or03VnXu0Top3v+g3XoYRCmFQ9EKc0ChLG4njb/1rs49R8qPK/SYT5Dm4knvJO+ajg1ueXwLVAzR7mSJ3H0LUdp/ouN7PyfA6PJnvSW8w4eWEHqevujlWrXTSVoejhVA5r30R2nAlyy1GgnX7dM1AFSQ2Spvkr8RK0lH+cXCe7EtTfYXOkvZb4MIUsum7TVCAVgR1RPsCZyEpDf0GcNxhVXScinX0F/hx6viFyw3fAPwWVuuwVrgzp8sHNRcXzK+Tr8k3bulTCaBbLIKYKC6gMgnx3B7Ff+nCRWEUpuB5Ib2THiSynlxbeTL5PNyQ/3MVetWYsA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1718.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(966005)(38100700002)(122000001)(66476007)(110136005)(66556008)(21615005)(66946007)(55016002)(64756008)(66446008)(316002)(76116006)(54906003)(5660300002)(83380400001)(2906002)(9326002)(71200400001)(508600001)(186003)(8936002)(86362001)(52536014)(26005)(7696005)(38070700005)(33656002)(9686003)(6506007)(53546011)(8676002)(4326008)(166002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?kfscrf0zV8yTcc6iyoM/L9XSEPr9puVwUMpz1shNPAjMLfE1QH8YBXf7?= =?Windows-1252?Q?TidWVzL8AFVzWTHWGs0mU5hvrfRhYEvncN3srTImsVayNpzYxBONPPOy?= =?Windows-1252?Q?k2THnc7IBCMEjyY0lkAzyP3Srwn2rUrhVOvaG0AnqWZCPev7Pb5Rjpwy?= =?Windows-1252?Q?U8ix6ey6nO9VMX9TzUSQWMwyAoQfAQBb4uWcW7qeeSDV+LwIDH4528qH?= =?Windows-1252?Q?1FIXyCNptdAAayZNhs7CRVZUwTT1qQZT95pufIyidh6B24duvrI0xJdt?= =?Windows-1252?Q?ArqTdVsJ0ynd4Nx6WF1Gf1epzjKyEvRaMscJUJPHG+LmwNP6+qy9tIy/?= =?Windows-1252?Q?zcX5/vXEk1aHGKeG7xJ63qMYosEnuc24U0OKqKg/qkWViQFt1A5pIOfu?= =?Windows-1252?Q?xQHvQ2YJ1RJa87W6hqNwNDDP3AV4IY+PfuTU0suMiRKQttwZQCArNSBQ?= =?Windows-1252?Q?BaB9vnU9BKTo3jvCD8p8Fiaip3s381ME4h3/LrxxoYAJAlL/UVNJv/po?= =?Windows-1252?Q?h+tgmYI3vP1b81MGAdUnCedWSUWrgUV6E6dLq//4dehdzGnYyFgH4Fu0?= =?Windows-1252?Q?MIEiNW1gJRmlHxZ2a0a7eJyPO1KD/gW7a1ndFpkwSTRiT1QGsW2tFzTC?= =?Windows-1252?Q?c5cmZxJ62bTaRtXCSVDio0SaqmPKObAAbsrlfGsI0tSGjTWzRVnqEs+P?= =?Windows-1252?Q?8RJZUhLx489Rvua/+35sEt29zv1SWldNQV8fGXVNo5GTQui4jM32uumV?= =?Windows-1252?Q?I4Fy1NI9xbAmsx2EdgeKvZ5ibT+wAe3Hp5PZ86h6JgqygIQdYWqBa9to?= =?Windows-1252?Q?T1ULlGqjnBJ7bdva3V3KSKlGW3+c0osNCsWkwTFfKRJqxZ1SbL9pP/6k?= =?Windows-1252?Q?pIbKRkS1cqhcoOlbNX5BbblRQnS76ltVBxVHPgYaGL1j5AxOupw9jjT/?= =?Windows-1252?Q?Hgdm2qSOPxAHY45E7D1u5MQxNajlYmyPq6TuBHdKu0nT6Cmx+JBG2CqU?= =?Windows-1252?Q?QDycijRrBjXJxPltfEkz3wi/NV/pWKrV/5mBcmZqBx7rY2GUWGWtAEXC?= =?Windows-1252?Q?2TL0wopqKnq0bv2+HD2RzyF/B7FDMHgzuLBn/F1JhGjXDFHHJAxab7pc?= =?Windows-1252?Q?nQLDYnhHVbRqNl865q0kJhCcHla8BxYxsqpWQLumFnSZ6/l6ZiDlflkV?= =?Windows-1252?Q?/2jdwuuqpE5Nlo/uC+HPbN9In9AzQJnqbi1IY/Wn6114+406hH0F9UWv?= =?Windows-1252?Q?FSI4em8R8u2nTeJ0mbfVOVReEEjcNgvfupY5OEglReRKOP8rxoxii5v2?= =?Windows-1252?Q?+39bt61cJnFpQ2jhjnHLPv6hHGwxtciUJeWMbyVsx9JakTFQLhwlEHhP?= =?Windows-1252?Q?k1F4nm68ZNc7jOG06wvLwgBJa6bWfi6ytP5mJdNfP+zjsZwBc2GC0Wjk?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c8d78c7-69aa-469f-7fba-08d9870ab9a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 07:43:58.3116 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mHD85QSIu4Dee4KiLFaHvYWTsncpOnnNxw46c0ilTSXq23wdP9MrcWn1RUuKw0QqJIYUI6XEAAZkA0hMLMtnkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1637 X-OriginatorOrg: intel.com Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, This isn=92t what our concern was =96 our concern was rte_cryptodev_close()= may not remove the memory complete as rte_cryptodev_pmd_destroy() did. Our research result towards this was if the PMD could act more throughout t= o make rte_cryptodev_close() working same as rte_cryptodev_pmd_destroy(). What Paul=92s concern is valid: We DO NOT have a way to release a queue pai= r manually anymore, and releasing queue pair to me should not be blocked fr= om public API access. To resolve this problem we should have a public queue_pair_release() functi= on in the cryptodev. If you are ok I can send a patch for 21.11 right away. Regards, Fan From: Akhil Goyal Sent: Monday, October 4, 2021 7:45 AM To: Luse, Paul E ; dev@dpdk.org; Zhang, Roy Fan Cc: matan@nvidia.com; hemant.agrawal@nxp.com Subject: RE: Recent change to make rte_cryptodev_pmd.h internal prevents so= me important functionality Hi Paul, Similar comment was discussed in ML for fips_validation app. https://mails.dpdk.org/archives/dev/2021-August/217781.html I believe Fan is working on it to fix the issue. Fan, Could you please share the update. Regards, Akhil Note: Please CC maintainers for a prompt response, or else mails can be ski= pped. From: Luse, Paul E > Sent: Sunday, October 3, 2021 3:14 AM To: dev@dpdk.org Cc: Akhil Goyal >; matan@nvid= ia.com; Zhang, Roy Fan >; hemant.agrawal@nxp.com Subject: [EXT] Recent change to make rte_cryptodev_pmd.h internal prevents = some important functionality External Email ________________________________ Hi Everyone, I sent this last week and haven=92t heard back =96 apologize if I missed th= e response but if not here it is again=85 We use cryptodev in SPDK and included rte_cryptodev_pmd.h so that we may re= lease qpair memory that was allocated when we called rte_cryptodev_queue_pa= ir_setup(). We=92d do so by calling the function pointer queue_pair_releas= e() which I believe is the prescribed way to do this. The DPDK change in question is here: https://github.com/DPDK/dpdk/commit/af= 668035f7f492424b2e199f155690815944a8ca Question: Is there another way for us to release this memory? I=92ve looked= through the public API and nothing stands out. Thanks Paul