From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 243E3A0561; Fri, 5 Mar 2021 04:21:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6E7922A341; Fri, 5 Mar 2021 04:21:46 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 93C244069F for ; Fri, 5 Mar 2021 04:21:43 +0100 (CET) IronPort-SDR: Jll5IOk51OGR3G4Y1s1iNaOh7BafKeVgzwLXD8CqUs//XlT8z8Oh4Oph7pw+BZPU34aHyFtEPG 2yzUCcnxIEHQ== X-IronPort-AV: E=McAfee;i="6000,8403,9913"; a="207282859" X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="207282859" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 19:21:43 -0800 IronPort-SDR: jAlU+DpPW2ElXni1xDy1hoCIU2Nz4Wz8yPkT0xryB6PXVdRbcTxuOl0uImf94TPAno+yxG9k/C SadSHPf10xNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="408111493" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 04 Mar 2021 19:21:42 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Mar 2021 19:21:42 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Mar 2021 19:21:42 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 4 Mar 2021 19:21:42 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 4 Mar 2021 19:21:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZFkgo6oFF0Mvjr3ilrdSp/4lLO/3iEZc+2LOaOPeC8540ZzJRQtLLYJT1SjGcypwzaOkxz3k0zesS8N0nYdtI83Kx1aaedOnoq2XmxS3od9QP9hH0i3FTQ9bfAlhTp8C3c/v+Js0NY9oYYdyyXuvv/d0FyoWBDYmiHGi2oxYAO2FPv57rS5BO68v1kSb2W4BFYkjG11ao44k1M22LdLrOjnPYwcL4KWxmgBly3SdGgtFTsCjZpgM54qKXGQtwYnSHCm2P1NTMBl+pUia87h7HA4wtN48UGe49xutsbngH+lsu3CQ3ZPtFPczaGf9wrjA8uWjYvlXpIoKBb01VkFWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N8BJEWrMPXeK+p4FUIOAl2qHnI9IXgHdsR58dBvfoqI=; b=QBmKq7PnJqWXZD1sBB7uVOjdREd/ROM1xjmZ5NB2v6ifo2kG8Y0yp5i2h3VzwWDwQFgwiIYWGyW/1COGzKSgX36iS+0Z+YvOgdfB0FexjTqVyVExvwWUY8DChwhcx2bG8B28jm+fzJ1ARODPa/Rze04oM8xRtc31AlCSQspNrwrRJXLQALdlnjb/N7udQad10Pmb3+Vxw91/Xh2SUFprjeBlCM7YkEqMx1iePKsV2151wue6TsO4qs80JJXsShm4Br1rJq0YfTK530qMXKOPJtkVvDS/woFZPb3KgvG3HE9OErSTCxp1PxnvqqetWfIUi4cz0vZXk6UpcCskwcei4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N8BJEWrMPXeK+p4FUIOAl2qHnI9IXgHdsR58dBvfoqI=; b=cyCuTqynwPhdeGklHcyTg9zIQed+uDhZSQafxkRbwiuHVKu8aXuKtlUJ6CRVybzV8nRkpb+w/2StH3IEiSJpyS9XyjeDOkeN9sRDAWAqAVFGAjllEBziAcnnYxy4SJErCeKViNwrP7NGaQUaX5/dgFB0t1m7BQbDaJ5Pj0u3shY= Received: from CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) by CY4PR11MB1240.namprd11.prod.outlook.com (2603:10b6:903:23::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Fri, 5 Mar 2021 03:21:38 +0000 Received: from CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae]) by CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae%12]) with mapi id 15.20.3912.022; Fri, 5 Mar 2021 03:21:38 +0000 From: "Li, Xiaoyun" To: Lijun Ou , "Yigit, Ferruh" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx Thread-Index: AQHXEVpLggWbOXg6NkexY5bGg4o/Jap0ucJQ Date: Fri, 5 Mar 2021 03:21:38 +0000 Message-ID: References: <1614905757-33791-1-git-send-email-oulijun@huawei.com> <1614905757-33791-3-git-send-email-oulijun@huawei.com> In-Reply-To: <1614905757-33791-3-git-send-email-oulijun@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37b95e80-5f91-437d-bfef-08d8df85c9e8 x-ms-traffictypediagnostic: CY4PR11MB1240: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:820; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0WblCCVS8ezW0AkmsMTz4um+/nBEDW/fB+e6cG2jvYrqqPr2zUqIRKgcPjYxMkYQhFnJfiZwi/nyKFH3jLLLS1sIzaMS38vEtrvVMYMhEYc0/hqxiYNgyLJlvfkJQwCE0tAyt6kquP4b6JJO3AnRwaXzAu31m7AgofTVB51CiACjmqoJ9phFDG/P0ukDOyXM2IIrx50Dgv+P6xc832AsDkeZpvVssWsAzHXfMR7Po81hUDUo0ZpoJE3rbv+zN7OROkRU0aOl59yzziXn0d/1NeOu+vPHP+6tSzPXduty7PtuNZAa5Sb1Nw7iAPhrJPVYImrDZ933dJL4RhFu3fwyZH2zQ7SBC+msrM7YvqDgd/g7EU5J/VFiz/eTnX39JKi3R6ACKiO18SFHAzgkAofN+JhiV7CNiBQcEBmt5eGMSNATFOT9DG3Dbi06hJqlMWFG7CTrwTt/rHZz5K22mYexSaClVsvEbzZ68Xj89vBroRKfT635cmkJkcUUNYKrzSwYZ4w/nG6DAlNspz/E3Rh/bQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1750.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(346002)(396003)(39860400002)(366004)(55016002)(186003)(7696005)(8676002)(6506007)(6636002)(478600001)(26005)(9686003)(53546011)(71200400001)(83380400001)(110136005)(54906003)(5660300002)(2906002)(64756008)(66446008)(86362001)(76116006)(8936002)(66556008)(4326008)(66476007)(66946007)(33656002)(316002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1ImiecWBpZwetKRtJjw8bHngetsXDiKmsmLmIeMZc4tP6V4YRGvVulD+tvqE?= =?us-ascii?Q?Hwzrf+SOlcweowc1QlM2qxs4A6fGT0pJznlWinlvr1ZLa5ngK4yaLYMLpKMU?= =?us-ascii?Q?2w8AmzTRX3DvflLvZGXXFyt3jlhsJ9RxnL2rCitLR7cF8m7kfF+A1ikCgBEf?= =?us-ascii?Q?DE31APrXleFhyDx4FLuoC1szowD20qCp0S/+ckS5ov0fRAQcKCKx7he9ST3q?= =?us-ascii?Q?+YRL1/xxtB+Ntk8cxJKHdNP2TrVtUxZvGip32ABvQOvaQciG1o5vSENxB7xH?= =?us-ascii?Q?mTzMAxi0hkKdUs19SRaMnRwZmUtqJ5ch8rT4Go4fzVyFDNVjwcKX4+cKip5l?= =?us-ascii?Q?5DWjNUmjYycNITb41aQb6VCoHpXrV4xYFVxMPOcNg3V+llAkG6WN5FrRQDjb?= =?us-ascii?Q?nJv8PTDxddCqDT9nQqMWfTH4RYe450PSwIt54l3/sfla99VsoUxKIt/jPsKi?= =?us-ascii?Q?3uePK8cbPl1LYV7OLligOvnod17k2FwLv7xeFQ6mkr1t4CLBGCfUDXWDpNwU?= =?us-ascii?Q?Y1SJXv23g3qwCEX11+segRCaBZawkhDEs5LzuD9K/ADitPo0QwPpKkGrN2un?= =?us-ascii?Q?EDlUCGHhc5XlyxoQoakDMZ/I3nbsIj37U8lMwmxVKwE9rsqAk/WJiKXWgedd?= =?us-ascii?Q?BzmWCbdSmfyBfbUy6I9lGzIymjYOlfdY2ZGdXr1suU4m2dn8XI555zu85X4d?= =?us-ascii?Q?7UlhI9ZK+Rf7WDhH8qGBtcbP008lduXAPsWmZNJmH0v9fNGFdigOFn3tYo+9?= =?us-ascii?Q?CPXEJbKhXdLfaupmdylvDk0kvZSI2kKyvC1P1OvUHv+JXf0d6i6q0LX2xQJS?= =?us-ascii?Q?g7i2Lnr+7dcfUBDS2YJfXIDFHsDeRq0uK/u0YERAkI/VIFA2z9UYvrED9GoK?= =?us-ascii?Q?3f1PU6axCCoaHEGB5tiMDC285NW2TGFwZdD7gfGdX2KTnYw7PIHHMlUQy+Jc?= =?us-ascii?Q?t0gKR5HAGGtM7T/kRu61GDs9gKJ7h2JWgyDtLZR4GKxwaB6F/gvWI9FN+iYL?= =?us-ascii?Q?votF/odafvbgWmGP2nFDm3kvLg1cy8JU/BnVa/SgVXS0t1Bq1neB6tXDKqa3?= =?us-ascii?Q?txlF32diT7U1wru2Sk/ZRsqzjQi6iHphciJPsOqxWJ1uhLhcX0OBgXn2UGQK?= =?us-ascii?Q?RGTD3Pk2Pc1ah4l+o3mEX1HD+sN3qlm552LYNvH5gwd5SI5gXpukQPbZzE/i?= =?us-ascii?Q?/EM++bA1gOR7orp9pBKdNKYa00tS1XqpQ54OagWR81Fg/W+nIPUV4mY0KIcV?= =?us-ascii?Q?IcnRHAlTLDmh1NoyvRd66oOOF9gwXbiixc7P+3SndCmDlUXG+6mZjce96sgV?= =?us-ascii?Q?EY5A1JZPgRbsL8lBjeyHXWjK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1750.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37b95e80-5f91-437d-bfef-08d8df85c9e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2021 03:21:38.2694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mBz3pTHQr3o0ulvRVWb2TsS70oRIfw11HLaNSC5tp0Wfx/GhY5ef9qFGSeCcMAyaqKGkRLCPgpQHWsQFZV3hig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1240 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: dev On Behalf Of Lijun Ou > Sent: Friday, March 5, 2021 08:56 > To: Yigit, Ferruh > Cc: dev@dpdk.org; linuxarm@openeuler.org > Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config fro= m > parsing Rx and Tx >=20 > From: Huisong Li >=20 > The "fwd_config_setup()" function does release and apply for memory of > forwarding flows, and re-establish these flows when rxq/txq or rxd/txd is > changed. The function is also called by "start_packet_forwarding()" when = user > executes "start" cmd. > All changes for rxq/txq or rxd/txd can be updated uniformly when this com= mand > is executed. Therefore, it is a little redundant in the "cmd_config_rx_tx= _parsed" > function. >=20 > In addition, the forwarding flows under one TC is configured based on num= ber > of queues allocated to TC. And number of queues allocated to TC is update= d > after calling "rte_eth_dev_configure" > again. If the number of queues is reduced after configuring the DCB, and = then, > release and apply for flow memory, and reinitialize the forwarding flows = under > the DCB mode based on the old TC information. As a result, null pointer m= ay be > accessed. The patch looks good to me. But in commit log, you mean forwarding streams,= right? Flows will confuse to mean rte_flow. >=20 > Like: > set nbcore 4 > port stop all > port config 0 dcb vt off 4 pfc on > port start all > port stop all > port config all rxq 8 > port config all txq 8 >=20 > At the moment, a segmentation fault occurs. >=20 > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > Cc: stable@dpdk.org >=20 > Signed-off-by: Huisong Li > Signed-off-by: Lijun Ou > --- > app/test-pmd/cmdline.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 832ae70..8b0f7d5 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -1837,8 +1837,6 @@ cmd_config_rx_tx_parsed(void *parsed_result, > return; > } >=20 > - fwd_config_setup(); > - > init_port_config(); >=20 > cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1); > -- > 2.7.4