From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B767AA0547; Sun, 7 Feb 2021 02:47:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3524F16067A; Sun, 7 Feb 2021 02:47:55 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 739A840147 for ; Sun, 7 Feb 2021 02:47:52 +0100 (CET) IronPort-SDR: gV6a+x7focFiqYOde8xAE5dHTXfsVG4YLlTKFSx8Y9HsCJqXgzMyRG6C4VD0ifglskOtBBVPru pzzc8e/qNBlQ== X-IronPort-AV: E=McAfee;i="6000,8403,9887"; a="181723267" X-IronPort-AV: E=Sophos;i="5.81,158,1610438400"; d="scan'208";a="181723267" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2021 17:47:51 -0800 IronPort-SDR: gj8Qg95Scuaol5NMvVEm1EFUlRJ36WiNGqWjJ1cl64aiso9zZJPeOOH+XHTVrAb8ZZ2W+58Scz ba/XrQeGzMWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,158,1610438400"; d="scan'208";a="374809724" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 06 Feb 2021 17:47:50 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sat, 6 Feb 2021 17:47:50 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sat, 6 Feb 2021 17:47:50 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sat, 6 Feb 2021 17:47:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bZArt4OmONVZafg7Rcbv2UGGRrOYF0oxoldJ+fE5Po4Yd1UVavSUJIAKpCpWiYmx+aTbmmhw/JcE0EciVF2dBDv69f9OR1CVeAs6qcHq5Bu1nQgDgAWN1nd2sKM7BD6qZPtowJqPE6MdtzNOOYQ0cTMPZG3FJColZR8SlNgBfrVB2U5hvDCZ4kiH8ejDycAEgKWjrTQuhDDD0a9doUBQeiwPoOhhz85dr874RaIfVw9bX3nJ/uWyDTpixi2yirac72Me8TpUR4nTpZL5rqH+U5yEomwjeqFwzwvV6SRuYuYYjCeosZt+NgetKNqZ/yU6xiuDB8XTS9MQZFEVM5dEpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AhZyB7CArLrYucHWP3lywQ/zFw8HcuGYiQhbXgNVbHA=; b=Iu76VUibnpdmNhWGBMhkYEdrvbVFXp2knDDtBJQnBOYUSyxiwMrAISDOlRNLJO/xAUXRt7b3OWsaJAFfqKw4ceMCA4B+W0FGIw8cEVmWqRNPjujhlX2EkQ113eMsS/5HdP9OWBzD2Sbs173Z6eYLI60v1DuVPdzrO0nst9jABo+xEwa4VAaknAiePqGj61WJgMmxg44PzjpTU+WK56vKt0m9wShX5ybpsSkvNWcDM7/Gte8gaaHTHU/9Mj3HZVCdKbVg8t48e58NHwziJsl5P+FuqIVYfNBKCk5Q/2AhamSNgHQweks4Eb3/ZBlNvlGSJtSpw3k/PF4WUaT3fDvwZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AhZyB7CArLrYucHWP3lywQ/zFw8HcuGYiQhbXgNVbHA=; b=QOiElZcJKtEeM7+GV2znIF1e0LsG52V2CYmVspOLpNR2gCBszwpV3wL9PiQDak7MO37feMTp/x9zDGZpDslTvWdyGNefIgo+gg4fdWrhAc3aK97ZuuVCNezLm+2HXq8zIdRKg1yPh2Kp+/3znyPeIH2gctj2MthG7JUkmWqib/I= Received: from CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) by CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17; Sun, 7 Feb 2021 01:47:43 +0000 Received: from CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae]) by CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae%12]) with mapi id 15.20.3825.021; Sun, 7 Feb 2021 01:47:43 +0000 From: "Li, Xiaoyun" To: "Yigit, Ferruh" , "Lu, Wenzhuo" , "Iremonger, Bernard" CC: "dev@dpdk.org" Thread-Topic: [PATCH] app/testpmd: remove duplicated offload display Thread-Index: AQHW+8sPRSeeJGJtcU6L90BBQFPZxKpL7niA Date: Sun, 7 Feb 2021 01:47:42 +0000 Message-ID: References: <20210205142650.1106807-1-ferruh.yigit@intel.com> In-Reply-To: <20210205142650.1106807-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7bef2a18-2f94-42fa-cd49-08d8cb0a5c62 x-ms-traffictypediagnostic: CY4PR11MB1750: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gWX7r+Qnxyv5sOnqsEwIeX4vhpAtaBBCDAHOvC4EsvwLYiWUVFsZ373DkeEYY+obg0td1GiIn5PVazXOV5A7KUGKCXvo2IbQ4lj+WLwoC13/d/n/Oot4tfsdOehaj5ikEy25MCFnEt+eV/qic356VubUNSliHu/ho/nl64ZWk9n86rElTSq2QkZgS1dx1rmbE4NpLCAHSN+pf/8vNaAmoWzT1R9U6JOXRjE8JauZoQPhr8qc4kZjg25c6LU3xk/vfcbA96yQ9COqsE1EcG0Q9FYV7X5p+GwjfNH97RbGL29fPDZmeWAF6oYmvGW3GiFRCm+dEQSxEG8f19cTjdPRiIQ2smDPvKu48WCIvnHSF8WAHLUbBPl206u347BaVvXKi0Z2NXEJwcOtFKeNXA325EFi6/AAEfiDuLrQI9hgsXTO4hDXAgivTrciiOPmLdq4702LU7zD3jdORC+60S5VqV85B4lnfkj9csjLkJqn2dpNLy9SYJ2NdJ79q1cNxrQter1hmhb+Na15S6QDSRYeoQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1750.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(39860400002)(346002)(396003)(366004)(66476007)(8676002)(186003)(86362001)(33656002)(4326008)(6636002)(478600001)(64756008)(9686003)(66556008)(55016002)(66446008)(66946007)(76116006)(52536014)(5660300002)(2906002)(83380400001)(8936002)(316002)(110136005)(26005)(53546011)(7696005)(71200400001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?0Y6xAVsokn+EhnIT42++edMPYHswpBXv8R58vtRgpOp+WybNe6RJMku9Oid6?= =?us-ascii?Q?D0r4BxN0fIrbZRudXIxFkcpmhygxiQZ+Dy5TSlDUxx5Gd8S3iFvtk2K2rK26?= =?us-ascii?Q?0qCGv7ZunvibhIm3xYtHde8hdTq8vcFHY/muWkJu04hGGO8KnUmXQhjchHt7?= =?us-ascii?Q?ANwYD9yn9eImyIi/Nf3hy5q2oBI0VhAZ7zkFyR0TS14hvpQxtkiK1FHQVCY+?= =?us-ascii?Q?CkpzdFEyws/YpSk5xoO+sjjmF/8bOoi2Qabh1ze7z8SBu/vPVqe90jiXbgu1?= =?us-ascii?Q?8Ci1hw6cwygvGbWi+6r0dHDYjizo7DZcXiYzqebdrjN1zfz0MiwtFPto3UHn?= =?us-ascii?Q?x0h04fik9EzYzFREKEAQna+mE3xMVM/vB2FOLYndlqzLq5UVEp5pg6gDgkZY?= =?us-ascii?Q?0bsIgkVhdrB+EPyXnT1YxcixW9RQfBOZZFHL+s+r383yD8qLPPDYc8j28Ie0?= =?us-ascii?Q?LFmd4V72+ArMxIuG1o8j+QP3No+ImkYmVaAEyFtieFx4YYdyAOp+zYEWzUtV?= =?us-ascii?Q?nNB0MHp5DlI53oMdhivnndcUbGolYqxz9Yup4Fv31HTvrVCKt0aFxyw/E5cQ?= =?us-ascii?Q?sb4E1Jz3oUCjQH5EJYYL60kbnQMBlCvBPkyVHHbPg2GRvNr3ZyorIplSJAcP?= =?us-ascii?Q?9objpPGQ3pMuOr5twRf6MDE03J+WvWXkcrshwhNlqJYBz6g3dPjIQebfyGWA?= =?us-ascii?Q?Cvt5AT1ImPUj3/5Vjdj9Q9y1rhZVexHlKv23i46dxSAVkpxRqtMXPAWTri5D?= =?us-ascii?Q?J8nqvnaFLY+id1pb4U5s+xnLFO1+og9KQMhFRtd5E5/6ie/4S30PHZa8cjG8?= =?us-ascii?Q?lmpZxu/F/bFMUxhiKkYlmTaN0WkHg5iOp5FsrUgdnufHQ9Oea39JxMsfuJnz?= =?us-ascii?Q?pl9AKqB+QZEbie3jVfun+povvwU7pMkuVRcG78Qnxl7n/NWPm7OSrbVyPcmT?= =?us-ascii?Q?BdCCBbwxw8QHdRRfy0GO6+DtBM7wX3ci46jGp7OyN5iZ0nGoZMCMG00wGqAi?= =?us-ascii?Q?HmC+OppmKhAasZqZo5nj2SQkfZjG2t6/ZdSL4lpM+djY7iWovepF5KPiYV3s?= =?us-ascii?Q?rMMBUJWIz7VhbUkm0IQjlT3UOLUi+6jmQLAUpf33aJ9h2XLqk1mYU0m/xW9r?= =?us-ascii?Q?qXTBNq5b5G4S9FIo0+9O6xsgR5mAn9SvNiXBwlx1mPfRtfgA9WZ/pxdkQ93a?= =?us-ascii?Q?b5IycGQezOmPxGm91rwhWDByZv0Gf6uN42/21cdM6nOswkg7Y27Vnq7NK4eS?= =?us-ascii?Q?0BveKPzpz3Y0DPRGDP+DHuhffKT1Zng5IWUguOrhdvcdlmCZgpIgFpUkyNpz?= =?us-ascii?Q?sgxazeDMOSVqQLNb61BK0BbL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1750.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bef2a18-2f94-42fa-cd49-08d8cb0a5c62 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2021 01:47:42.9976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Kdbnf8oQoLh89DsW4CDY7K9HHLj1axd+wv9dstkj+n7rWv6xbW+HSGn9O/CLOI1HCG+AYeAL/Sra5Eo3RjKLUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1750 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: remove duplicated offload display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, February 5, 2021 22:27 > To: Lu, Wenzhuo ; Li, Xiaoyun ; > Iremonger, Bernard > Cc: Yigit, Ferruh ; dev@dpdk.org > Subject: [PATCH] app/testpmd: remove duplicated offload display >=20 > "show port cap all|" was to display offload configuration of por= t(s). >=20 > But later two other commands added to show same information in more > accurate way: > show port (port_id) rx_offload configuration show port (port_id) tx_off= load > configuration >=20 > These new commands can both show port and queue level configuration, also > with their capabilities counterparts easier to see offload capability and > configuration of the port in similar syntax. >=20 > So the functionality is duplicated and removing this version, to favor th= e new > commands. >=20 > Another problem with this command is it requires each new offload to be a= dded > into the function to display them, and there were missing offloads that a= re not > displayed, this requirement for sure will create gaps by time as new offl= oads > added. >=20 > Signed-off-by: Ferruh Yigit > --- Acked-by Xiaoyun Li