From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF79CA0547; Sun, 7 Feb 2021 02:59:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49EEA1606BA; Sun, 7 Feb 2021 02:59:03 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id BEE2440147 for ; Sun, 7 Feb 2021 02:59:01 +0100 (CET) IronPort-SDR: HP8fIgvnb7amIoLs3uE8ydNHXFx0E3syqAb9M6ka2FtEV/87qaRi503ePvRvbETQmTqRTWMHOa M6cB/QodlxDg== X-IronPort-AV: E=McAfee;i="6000,8403,9887"; a="168699945" X-IronPort-AV: E=Sophos;i="5.81,158,1610438400"; d="scan'208";a="168699945" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2021 17:59:00 -0800 IronPort-SDR: yYlFz5drCAl4sePoD2DRFxFRIW7iWOUM4PzmYykmiI9EkQJheslepeCa/O/Jt7KwE7Eu+J/0bV H0NKlkDlLa3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,158,1610438400"; d="scan'208";a="358983704" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 06 Feb 2021 17:59:00 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sat, 6 Feb 2021 17:58:59 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sat, 6 Feb 2021 17:58:59 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sat, 6 Feb 2021 17:58:59 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.59) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sat, 6 Feb 2021 17:58:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/mHm0q+d2rxsQ+jdP9ze5NskQE9RT01rFxkJ9MjgdsxPDda47VexeKfZ5fTwxbiCB81uf4jiRdEhhBvre/A5EC3OeQhcmpZkI9SySZHU1JXKAWFzAgr/d19BjPEm9/TDm+XlZ6T7GvyyBUZ/fweAFMWAdoOcZxU8T4keRR/kEj+6dlJbzYecVZV2gYdw5HgYmOebCp9s97LoitT3GY7SA4Pp07TB/hk8Ck1Ph2i0+hU4OdQuz07i88OYzCNW7lyGh2AgNyzUcIiIy5fZE5xUnEhBSGugC8HHtCySzon/FQFK9RhmyOKLhKc7P95YKJD1qGsuVTGPgaG+LdLzZnxvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ATdGNiPE/PKcuYIBI7UN71zhjlfFz4TXfPI8N8dvDrw=; b=eeq5U+Wuq2gCU8oQpBaEJIk9mpsLDNT3BAJ1NY7laH3VnaT79zjZEasfouJu1yI09/+iwOxAP/ZE292SLE89FoOF3dD4z0V/uU7MClSE3b6Ygh77U5OopXdpFBQTWfL5qjPOLU9qUEotiTFeqrJDl4kOuXH3auImTK/J0DqxC1OtwZqPGCFE+FOaRD8IQ//ZMDoMZ2ktITWNd/ATpLS179kQFdygpB7BLmmiprH38kDS/jF48YAx3JOEK8a9DJeos7iJWWkpaTQoKjVIaxfWoA2aTad4gwBkUbpnAdvhnMtsNFz9JuWBYTqYEEVTa2Qxwol0jTyHCh/IFMgzllQKOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ATdGNiPE/PKcuYIBI7UN71zhjlfFz4TXfPI8N8dvDrw=; b=PYjNeRRIhUCT5+FZ0Au72OrboO5MBwCikbLLTx+hJTIGm7IyCvclFxmUOWuTkJtoWyFukoULex2313fGmJ7aNkMAdZYf3uvoa5cMYbsiar0fl8/SteOLryDrbLv1NaNySPaQoAmXRxmBwAm6Qwbc2P7fpBorZRg5cRbd/k4PN8M= Received: from CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) by CY4PR1101MB2133.namprd11.prod.outlook.com (2603:10b6:910:17::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17; Sun, 7 Feb 2021 01:58:55 +0000 Received: from CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae]) by CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae%12]) with mapi id 15.20.3825.021; Sun, 7 Feb 2021 01:58:55 +0000 From: "Li, Xiaoyun" To: "Yigit, Ferruh" , "Lu, Wenzhuo" , "Iremonger, Bernard" CC: "dev@dpdk.org" Thread-Topic: [PATCH] app/testpmd: remove duplicated offload display Thread-Index: AQHW+8sPRSeeJGJtcU6L90BBQFPZxKpL8ccA Date: Sun, 7 Feb 2021 01:58:55 +0000 Message-ID: References: <20210205142650.1106807-1-ferruh.yigit@intel.com> In-Reply-To: <20210205142650.1106807-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8e3ec618-5e29-4229-3992-08d8cb0bed1c x-ms-traffictypediagnostic: CY4PR1101MB2133: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: srAvzKB0sPsZbJy/Acr1vUdB8McCwBxm19NtcvMZKlA8G3G0fgxKt2NXiABntFEIw91jemf7ClE3e/iLgW4kwd99lgbSpXmqtFZt7wDlZXJUDAXXT7VOOEE5YbXHR7P8KSu7y/4/63fGbFHbMgskEIS9f/r5KEG9IIjoUn9BAkQdId37IxcGbYAGK10LPM9wBKG33NShHl0gWmJlBdOryfjRdhjWPq+kskod5y6jafZCGt0voY1ZIOHmfka+8QztbuZtyxpeJTTS4Nu8rqCcnjD93V8ykns4uNwAk4SSp88/SfS33+udC9yp81JsXLvuCIJnq3uihxwkJ/YA2UR7SOc7RtTzCuGk+e6x62B8qv7NvKGySrehUJptoFAjulmSHi6VACkSA5LX7BFQzfa+yFXXhD/texm40B2uK8zQupTmu3BBP36dGw4p459X9Y211kBeAYLts4YTW+GO2rIw8hFLbJZUpmTLOYneqNMJCJKU4f/R73qsSzqSLTfeOX7vMc3k1VwzkkhqZGnb33/yog== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1750.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(39860400002)(366004)(396003)(136003)(52536014)(5660300002)(55016002)(33656002)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006)(4326008)(9686003)(316002)(110136005)(2906002)(8936002)(6636002)(478600001)(8676002)(7696005)(71200400001)(186003)(26005)(6506007)(53546011)(86362001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?huEoAG9+FZEkw6mvuK+QSGNnKRMjVKmzhJVbnQEr2cjZ4i+OJkAL9PICChu0?= =?us-ascii?Q?duM4ayVbcX6zwBoEqAdrwyTrFYyXKprNwGwCsSvqMkGuysT5gvGUZC3odXi9?= =?us-ascii?Q?svz6mR5wdPVw0poZTHO0tGC6bcOrvKaMX2x9pCDBN+B26t9hl/Wljkhn8QyY?= =?us-ascii?Q?URYo29hKhmIT9nwJupbN6EYlAeyBSkQE9QMmKkBXHWAMr2wIILWNASLS57Zz?= =?us-ascii?Q?6A7I8LT4e6OTxN2rLyahZ05h7QCdnpX3dixKrNQv2eHHiZIn+CMGGcbUvSnt?= =?us-ascii?Q?KvlwXU2eFE0JUo9Ow2qePspYJ9ixE52QUO+beHCYZntznhlYEFVtBauJ3PP2?= =?us-ascii?Q?OSgC/Hp7bTOjN+bq83uEwuiDZgyVf3BJyM1+yjJUsPs6pV3Q+aem8WvukyM7?= =?us-ascii?Q?jO1xbc7jG078wKaSqRWPNGkPo8EUitVqCC/HzA6gwv8KiyrKswqZsy1YsyHY?= =?us-ascii?Q?HL+YggU0NUuyaovGMTqU/9V+ascDLUx/tpECkN1l+EJhQnFBoM2spu3qFcmL?= =?us-ascii?Q?yDjWTwkb93z5hF5F8SPozichY+SWNCTkh3ugM553DW05GvrB5r4Cx4BKG4IJ?= =?us-ascii?Q?XPK5zH+bVFrq8Bf6cQUjA7CPnKghb7TaIajNqTppZrQwvnfoEMFPTMSPHI2C?= =?us-ascii?Q?RXKtKQhOpRvoQXJYxUhqgooQHdgNg2Heuyr52qHiE3tofdwkCO41fdXApYTJ?= =?us-ascii?Q?9V63pZaSfS/hPuZBbhJQc6CNrfcTdo6w+T49B4HcPYNkQr7ii5Qe90RfXnLc?= =?us-ascii?Q?09zrrsydVkaPDTKqDHTutEB4VtgkJAJESnNYU7YEfRXS1K7Gu0wX1OyINIVl?= =?us-ascii?Q?QmifvQA7Rp15dZLvzQO/XuhllPahUFlWzVVMrF3wcQuXzsSuJ9sW4hXh+Xn6?= =?us-ascii?Q?2JQIlSA+x8mYw91rzrl7bAY6iZidjYP0+nHwG/YjnEJkC8Qhv8NrSyhaVRa3?= =?us-ascii?Q?w9iEcnn3iAK5mPlCID9Ukt9DUjGDfCCJJrTZ8slG/TYuE27XFQW0jlIrOv5L?= =?us-ascii?Q?YWhcSpNVwXAa84J7Ss8pRhrIyBsgc6bBFm7Ms2m1rNfI/f8YX4AbKnkn4JrE?= =?us-ascii?Q?iciVAPpOb+7tv35TtkwLXs7a620iFf5/iqui/cO6/ugMqYS23G5nWegLyrEG?= =?us-ascii?Q?CpOuWqKLa5zeXV0TXmREjLnwxKjfHugwBPx2O4HIq3sq1+VjCBDB3S88sr5N?= =?us-ascii?Q?MOlNgP3wjeTeFn6P6efIkiKLaFJUUvp8PFopRazEYHSD3Oft26lOFYbHO86E?= =?us-ascii?Q?73PyEhXa3r586hKO7v/sfDmF+MNeLseAZAOTRdZ8br6sCP0ohVKtTRZafFg1?= =?us-ascii?Q?fTJ3bimjz0C1YHCRHEAhvlRH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1750.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e3ec618-5e29-4229-3992-08d8cb0bed1c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2021 01:58:55.5064 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X8jjyjCblVOofXvgYiCG4ofhgAwcVk2LB1fXaeBrlZKXYgVUZCxv376YnFH9Wx6prgeZhdTxJWLQ9XnMNIdquw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2133 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: remove duplicated offload display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, February 5, 2021 22:27 > To: Lu, Wenzhuo ; Li, Xiaoyun ; > Iremonger, Bernard > Cc: Yigit, Ferruh ; dev@dpdk.org > Subject: [PATCH] app/testpmd: remove duplicated offload display >=20 > "show port cap all|" was to display offload configuration of por= t(s). >=20 > But later two other commands added to show same information in more > accurate way: > show port (port_id) rx_offload configuration show port (port_id) tx_off= load > configuration >=20 > These new commands can both show port and queue level configuration, also > with their capabilities counterparts easier to see offload capability and > configuration of the port in similar syntax. >=20 > So the functionality is duplicated and removing this version, to favor th= e new > commands. >=20 > Another problem with this command is it requires each new offload to be a= dded > into the function to display them, and there were missing offloads that a= re not > displayed, this requirement for sure will create gaps by time as new offl= oads > added. >=20 > Signed-off-by: Ferruh Yigit Acked-by: Xiaoyun Li