* [v1] examples/fips_validation: fix test output for AES GMAC decrypt
@ 2022-10-17 8:15 Gowrishankar Muthukrishnan
2022-10-18 13:48 ` Dooley, Brian
0 siblings, 1 reply; 2+ messages in thread
From: Gowrishankar Muthukrishnan @ 2022-10-17 8:15 UTC (permalink / raw)
To: dev
Cc: Anoob Joseph, Brian Dooley, Akhil Goyal, jerinj,
Gowrishankar Muthukrishnan
AES GMAC decrypt test should output only whether test passed or
failed.
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
examples/fips_validation/fips_validation_gcm.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c
index 1b141501f0..a80d8b3e4d 100644
--- a/examples/fips_validation/fips_validation_gcm.c
+++ b/examples/fips_validation/fips_validation_gcm.c
@@ -330,11 +330,16 @@ parse_test_gcm_json_writeback(struct fips_val *val)
json_object_set_new(json_info.json_write_case, PT_JSON_STR,
json_string(info.one_line_text));
} else {
- json_object_set_new(json_info.json_write_case, PT_JSON_STR,
- json_string(""));
+ json_object_set_new(json_info.json_write_case, "testPassed",
+ json_true());
}
} else {
- json_object_set_new(json_info.json_write_case, "testPassed", json_false());
+ if (!info.interim_info.gcm_data.is_gmac)
+ json_object_set_new(json_info.json_write_case, PT_JSON_STR,
+ json_string(""));
+ else
+ json_object_set_new(json_info.json_write_case, "testPassed",
+ json_false());
}
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [v1] examples/fips_validation: fix test output for AES GMAC decrypt
2022-10-17 8:15 [v1] examples/fips_validation: fix test output for AES GMAC decrypt Gowrishankar Muthukrishnan
@ 2022-10-18 13:48 ` Dooley, Brian
0 siblings, 0 replies; 2+ messages in thread
From: Dooley, Brian @ 2022-10-18 13:48 UTC (permalink / raw)
To: Gowrishankar Muthukrishnan, dev; +Cc: Anoob Joseph, Akhil Goyal, jerinj
Hi Gowrishankar,
> -----Original Message-----
> From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Sent: Monday, October 17, 2022 9:16 AM
> To: dev@dpdk.org
> Cc: Anoob Joseph <anoobj@marvell.com>; Dooley, Brian
> <brian.dooley@intel.com>; Akhil Goyal <gakhil@marvell.com>;
> jerinj@marvell.com; Gowrishankar Muthukrishnan
> <gmuthukrishn@marvell.com>
> Subject: [v1] examples/fips_validation: fix test output for AES GMAC decrypt
>
> AES GMAC decrypt test should output only whether test passed or failed.
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
> examples/fips_validation/fips_validation_gcm.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
<snip>
Reviewed-by: Brian Dooley <brian.dooley@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-18 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 8:15 [v1] examples/fips_validation: fix test output for AES GMAC decrypt Gowrishankar Muthukrishnan
2022-10-18 13:48 ` Dooley, Brian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).