DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Somalapuram, Amaranath" <Amaranath.Somalapuram@amd.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used
Date: Tue, 22 Oct 2019 05:18:50 +0000	[thread overview]
Message-ID: <CY4PR1201MB2471A19C464071D458A018D1F8680@CY4PR1201MB2471.namprd12.prod.outlook.com> (raw)
In-Reply-To: <VE1PR04MB66392045E0CCE853BBB82E83E6930@VE1PR04MB6639.eurprd04.prod.outlook.com>

Hi Akhil,

Not sure about how to use fix line if I don't have bug number.

If I run ./devtools/check-git-log.sh it expect bug number. 
Do you recommend to log a bug for my patches ??

Please let me know.

Regards,
S.Amarnath

-----Original Message-----
From: Akhil Goyal <akhil.goyal@nxp.com> 
Sent: Tuesday, October 15, 2019 4:31 PM
To: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>; dev@dpdk.org
Cc: stable@dpdk.org
Subject: RE: [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used

[CAUTION: External Email]

Title: crypto/ccp: fix CPU authentication crash
>
> From: Amaranath Somalapuram <asomalap@amd.com>
>
> when ccp_auth_opt=1 is set and
> if authentication error occurred ccp driver crash.
> proble is enqueue count and dequeue count miss match if we continue.
Please rephrase this description.

Fixes line??

> Cc: stable@dpdk.org
>
> Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> ---
>  drivers/crypto/ccp/ccp_crypto.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp_crypto.c 
> b/drivers/crypto/ccp/ccp_crypto.c index 19ae9153d..1837c8543 100644
> --- a/drivers/crypto/ccp/ccp_crypto.c
> +++ b/drivers/crypto/ccp/ccp_crypto.c
> @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp,
>                                                        session, auth_ctx);
>                               if (op[i]->status !=
>                                   RTE_CRYPTO_OP_STATUS_SUCCESS)
> -                                     continue;
> +
>       CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED");
>                       } else
>                               result = ccp_crypto_auth(op[i], cmd_q, 
> b_info);
>
> --
> 2.17.1


  reply	other threads:[~2019-10-22  5:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15  7:01 asomalap
2019-10-15 11:00 ` Akhil Goyal
2019-10-22  5:18   ` Somalapuram, Amaranath [this message]
2019-10-22  6:03     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1201MB2471A19C464071D458A018D1F8680@CY4PR1201MB2471.namprd12.prod.outlook.com \
    --to=amaranath.somalapuram@amd.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).