From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96F3BA04DC; Sun, 22 Nov 2020 08:27:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7ADBA2AB; Sun, 22 Nov 2020 08:27:35 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 5568723D for ; Sun, 22 Nov 2020 08:27:33 +0100 (CET) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 22 Nov 2020 15:27:30 +0800 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 22 Nov 2020 07:27:24 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 22 Nov 2020 07:27:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+PLbpH1utFt0WvdteGmGV7w3Cm2SZjmGZZoz/3lG3QqnW+AQPnFdkcNTtBA0D2hkH8QX8LS6Ru92qwD70GQRHZf9ys3c7BTVKpN9AWmd23yRKVjAKL6pZyHDh/S5I3HLlLXODx7SghJg0xI4SH7bSq0Nynh+CSphkRjHKxYw3U1xfv0CH92egJ9++Sa966Zj3Veq6c7mcIYmCS8SA5jGgiiPsn/SHdMhYRfCrFbFBe9VAa0rxxoGuOb9TPpgBotR2sj6owoPjowjSD/KP/i18XU/ck6yzlb5hvIK7uaVsrsZogML3kBhPaiUsYUpxeIM2veH2rZUFw+iN1qrbemAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=95Y10JewP81MNpdVDiNhIrmb17nyEHmi0c4UnLFm4sU=; b=XYZ7h+6sW8rRSiTXqmGCX8sB7CaTpJjfjMMuTNL3sQWss3tHZU656TEXblFtxaZ4eJAKrjPW47j1l7ZOdnUdaxSKFrfyavBAOOrP0197nRgvorZNOHGdjeL0nC6rh1wH9YcxScjeyDD7LtS90/TCyWgOb5uJwwgMknIxp2Shiojtbe/heibTiQr4gOmXSZXC73tXnu36zrngdssN7ZAVyJBzPjk7wY67JhXYzgapr+exBGKYv1grRnaAOs3UpoBHDVAjldJ5OH27K/ZxJeXzK6e0IUZsYrQ3IQ0kRU73FiwoG3lZUynxep3fFSF/OvEFLKO9FtNNmQVcvi8/KGD/MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from CY4PR1201MB2548.namprd12.prod.outlook.com (2603:10b6:903:d8::18) by CY4PR12MB1752.namprd12.prod.outlook.com (2603:10b6:903:120::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Sun, 22 Nov 2020 07:27:21 +0000 Received: from CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42]) by CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42%8]) with mapi id 15.20.3589.021; Sun, 22 Nov 2020 07:27:21 +0000 From: Tal Shnaiderman To: Nick Connolly , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Tal Shnaiderman CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] eal/windows: fix link error with MinGW Thread-Index: AQHWwFlMCbpVqUAEjE6KP/t7yMicqqnTv+sw Date: Sun, 22 Nov 2020 07:27:21 +0000 Message-ID: References: <20201120211255.24803-1-nick.connolly@mayadata.io> <20201121225415.25609-1-nick.connolly@mayadata.io> In-Reply-To: <20201121225415.25609-1-nick.connolly@mayadata.io> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mayadata.io; dkim=none (message not signed) header.d=none;mayadata.io; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.141.17] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cbb1b32e-94a6-4abd-c7a5-08d88eb80cfa x-ms-traffictypediagnostic: CY4PR12MB1752: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:651; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6c+FyzH0b36X1X67fLf4zSpb28ZA/x2nQfFkn5tRdKkJx+jufcQp0hMNfSQsqZUSbBDkhM/B5aJkqWQPb4cCb1zN+IRhWJE1NelCG0Fh8trEynyugZwAw3bssIk9xRfSfIxJlwe7uxYZ5qo2fJoKMBdBuyUa3/CT+7dXhZRrJtyG9KYThgiUOLn1tbnQPhxs3t7cUnbwPOW3wCNo6B7qDmWggv8FgzWyN/tJEI34c3C5npW5q1Ezkp5V0f9cksLQDjDnS/Sr+QC1d69JfF31gaJq+qNA/wkh+Ke/AKq48tJFL7pSQbDPeb20vd0jeyiOH5Rz4k8hfHEl0UTuLJRrmHuVp17lf8QZGeBTzhnjDG1jQyipmMkBvtzW5tttILvpksDKF+TVIw+J3pArSHcuaA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1201MB2548.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(366004)(376002)(396003)(39850400004)(76116006)(6506007)(83380400001)(86362001)(110136005)(7696005)(316002)(71200400001)(186003)(2906002)(4326008)(26005)(478600001)(8936002)(55016002)(5660300002)(966005)(8676002)(64756008)(66446008)(66946007)(66556008)(66476007)(52536014)(33656002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: d8nGEWxyummmOGq7MshbGePfM3PtfFFzjuESMYqkHx+4PtaC0IkI+HC4e2lefKL1IX6BRhvhB1cVdd0aC6nGNb5RDSaLPWoyR61tlpM5o1STDPhmHkHlfPaghcB5AEiPNnmCxFZSTWULVufGHw8VXGZarzKWThk/30eWrfIZuMeoz+04+2w41G77HT9sl+Yu/qaWRTz1nlhn63/L9aLVlkQBqu2BdjCfk6rZYDW7dNZADWxt5zCv5qUIHooDd3OlDNyQd+DV+0rEgv3qVacEeUOJgnlJwv+PcI2Qt8eL/p7+7NqPX9I/r4iQjBiji/ZSLY/dxnYlOD/5TgnExPIbYt82CKbIicntqmJimyIXv7rQsEfXWNQk3Pccn2hmEKvTA3xLYllnRSYMtRj7rld3izdj6CPxmG1spwHjJkXNXH3bdtB1ZhAUAls42+/nZEbq27A4+snB7R5NFr26tUiD8IDMUMCt4gBfWnronyUwpORj7YQzoJ9ntfa9lqxrNp55ryskGptUNGkPGFZwY/m+i+3NVuVEP9IzsVnzteCb/4KqyEoLzHd2ECYz4WAhU5Ve05UyujDpAp+3/TaZTQItrOdz8LebdUBAycVHNUwFPtXkNGh3Uruj47D2OGmpn8BVCOfjzEO6K8o5U/39aiYWzEk0yFhrFl/juIxHbsU5t6pNnmGOolEN/Hs/lKpsjdzgA3G7CGHYp5LZQy2/ag/6u5qu1dDNv5gX74aDkRuYzvT5ae9yROHkdcLX1FC40L11aWEuWas8bTwp53YcUl182IglNwQK5v3Ey/+mN265pWAMZSSHbNjI9fnEfSq7zcj/ApGm6QFROS+xxezu5NLzGPQG44f3dENF4o4CERFMOLsuKwQ/wnIxkrhiElAWrbwg077aCRhHBgEIAWYqebm6sA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB2548.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbb1b32e-94a6-4abd-c7a5-08d88eb80cfa X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2020 07:27:21.4983 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JHed6oo1pv5DoIV/0xhKJEBu+ACp9LpMPs/N7ZGBc/y3QM/51Gh/o5R+E2LlnioucgMBuJgCCAZ0+c/ppDbzEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1752 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606030050; bh=95Y10JewP81MNpdVDiNhIrmb17nyEHmi0c4UnLFm4sU=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-ms-exchange-transport-forked:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=GdKOlAdMkjpDFLoqGmxw4y8uJMe2I93lwayUYvpVY8qKYkuhyzW1mBfC3Qieww4Th WpbN55v+3jCgdcsWF96+qkZa1xxtPANJh843Us/v8PCYW3532lINtzG/cRhO9p/s81 82xvz/TZHq80XWwjE6tODEEPpDkBe+RI685q1kAwsxNzHJun+W9oPNndiL2iOlb0LU 8sCJ/VxSPwzGHSTl5wJQ43n20TlO5Kd82o4AWAtREZoLCS7fG4SFZ4eQJNob38/rSU jOrZksogKlasIMQfYFLb6vCFAUVFWWl8iKfP+bKJGhurK26q+CUTFNBtDUKrAeb+Y/ ObGJzjGczAN6Q== Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: fix link error with MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH v2] eal/windows: fix link error with MinGW >=20 > Linking with the 'pci' driver when building with MinGW on Windows fails w= ith > undefined symbol 'GUID_DEVCLASS_NET'. > This occurs because devguid.h is included in rte_windows.h before INITGUI= D > is defined. >=20 > Move the include of devguid.h after the definition of INITGUID. >=20 > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") > Cc: talshn@mellanox.com Cc: should be stable@dpdk.org so fix can be backported, see more info at: https://doc.dpdk.org/guides-20.08/contributing/stable.html#what-changes-sho= uld-be-backported >=20 > Signed-off-by: Nick Connolly > --- > v2 > * Fix commit message - add blank line, use present tense >=20 > lib/librte_eal/windows/include/rte_windows.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eal/windows/include/rte_windows.h > b/lib/librte_eal/windows/include/rte_windows.h > index 0a5e71a05..b82af34f6 100644 > --- a/lib/librte_eal/windows/include/rte_windows.h > +++ b/lib/librte_eal/windows/include/rte_windows.h > @@ -25,13 +25,13 @@ > #include > #include > #include > -#include >=20 > /* Have GUIDs defined. */ > #ifndef INITGUID > #define INITGUID > #endif > #include > +#include > #include >=20 > /** > -- > 2.25.1