From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AF48A04DD; Thu, 19 Nov 2020 16:27:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9DDBBF3E; Thu, 19 Nov 2020 16:27:36 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id EADAD23D for ; Thu, 19 Nov 2020 16:27:33 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 19 Nov 2020 07:27:22 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 19 Nov 2020 15:27:23 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 19 Nov 2020 15:27:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bwpDGFMkX+sAGbDJ4zvfvO85taA9P2Qy2QDpkk6/sO7MEJ+L7PKJXtKbfZWihDKrpwZTZEdth91bqlcYtbK8aEUSK0GA1K58kWY2U/3E51i+zX4e1GNwKAMFZWFPypBbQK8sx7kbyr6S0TwkI8keptuVsFounnS5hgv7nHHKY9I3KQgP9t7UXdNZpidbzjfQnOFZXD0XWAEJcNQJ8t62HxzqCY7CHm/AaE5xKngJvN/7vAZK0pwNTMf7nk427DjNM3pGjogWPkAXDSbRld4pzzT6gKMIM37KY6e1pbSHVfoUp1VSL54zRCR1N3NTN2GMI05L5WT4fYvuRVg2u2+rMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CX8DA7yKHy4uekm7Hn6WyJVzAANl8QrGAb3C9d3DnyI=; b=Nsz7Uzx5YNCZEv/K2AqvQDUqVXtUNUQjTzEtuAFNrNfyYE80s959ceKQqc4q3z1Apvt7A9tHuu14Hln6REJBRAtczDbetGu/AvsEfQZOvHxO27dg2Nnfir7dlsi6mOpihrBIBTXyJMVRp5osmM1auv6mg1kbpLxMu+GuU7xQOE4dNwYd03I1jhKP64ylHhxHtw/+SgsrwVqESewQsUY9mQoMPJRfuwWCxMzzytpYMTkB87ubaQiLyOK4StW3WrQwE/yLSI1ExkbChts3thabnO3oxVW7eU6y44M8lakKfhPR7PSYipbcGlQnthtF3kd2JGFYA/cIF4OP3LhRGedM9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from CY4PR1201MB2548.namprd12.prod.outlook.com (2603:10b6:903:d8::18) by CY4PR12MB1622.namprd12.prod.outlook.com (2603:10b6:910:f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Thu, 19 Nov 2020 15:27:22 +0000 Received: from CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42]) by CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42%8]) with mapi id 15.20.3589.021; Thu, 19 Nov 2020 15:27:22 +0000 From: Tal Shnaiderman To: NBU-Contact-Thomas Monjalon , Dmitry Kozlyuk , Nick Connolly CC: "dev@dpdk.org" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" , "pallavi.kadam@intel.com" , Andrey Vesnovaty , Asaf Penso Thread-Topic: Windows: A fundamental issue (was eal/windows: definition for ETOOMANYREFS errno) Thread-Index: AQHWvM+aar6LaG8+LE6XrtuOIBkwPKnMR54AgAMrqECAABjFgIAACnBQ Date: Thu, 19 Nov 2020 15:27:21 +0000 Message-ID: References: <20201114211156.17196-1-talshn@nvidia.com> <20201117155318.48728dac@sovereign> <2257677.iy3WzgjemN@thomas> In-Reply-To: <2257677.iy3WzgjemN@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.112.224] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62b9f062-b28f-4302-4ba5-08d88c9f9c30 x-ms-traffictypediagnostic: CY4PR12MB1622: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MziQWjzVIHQ60TTZDFhmv6RYulOtj3LpmComuTHwiyP+f9AgU2lZ4EeXpz4l7Erqi+6IW0JL02Sqz+wxxbWBZZWtGkt5fDuHeQP8lBG2aNWzlJzZSKGbp+8BVo3hUJkoEN03DK8wRViGx4H1Yxd7tUE5hutT4GfKIuydHpHwUdO0eMVW6tEkHVfitunwOFZfy0HJqALyITxbqMFNdFBrJdrye5GBsLarYweBedTkF1H3Lzs9ulI6/eul2TAekGEN039rOHNkNmlfbfLLPHNJUG17kF0ulVs1Sz46AA8AWHG+t0S8o0HP6dceVoEgxV52MkswA00qlpO/nmdOJnwOawp1cI/sdCUaYI55XVMjCWoToDiKzkFGJkw3Ycywgmck x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1201MB2548.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(26005)(33656002)(186003)(55016002)(8676002)(66556008)(2906002)(71200400001)(110136005)(107886003)(9686003)(66476007)(7696005)(86362001)(4326008)(64756008)(66946007)(76116006)(478600001)(6506007)(316002)(52536014)(54906003)(8936002)(83380400001)(66446008)(5660300002)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Xp/e+KfaneWd2kjqPpqxCXdcqgpyUGAs3HTGTapwHrk1O61C0cm2RTRMqoZ32nCIIhQ/ouv0Jo5Pb+aRbadM8wVnbBz3hHH03sp58hfvjy21EubKE0sWDGEVMTQ14BfrLNP+1lrxnPjuE64/6FK3bu1ePa83UiTu72P6F/xUHc/8lVeFfQW4GsjuBg3liUtc5lRjFawXDmU6mqK7J1sEnPz1d6eHxs/FAkR1+XKgLaknmSojLCmwnhBXb6PR3o0wxgQYkWU1itGa/zfTYVEoAC7Q8ucHwsaWzOsaMUqX5tTVGHd4icn9uBEFTWJKA6/JkBuN3LYV79Gk/25M4SxGID81WnhUsDijpkl1o6cEugJUV2sGrOnte65f3Yzh5Cm/Pph10mW9uycCDvZUPDOfwfbj7KkPb2S42+0cv8jqlevKmThdtAqKa7Mj507WTlaT3tWfK1yieIeVwnMu63DLUZA40AjbB0eA0g5CNf1tiRQPf2ObQnRvL1UoWjwNMI3HRb2TLTyC+q4fBSisdlcTZOOoJ9hFvjaIXuxxbXNE0Jynii6fsuaM4oPYh/sCA3qwTerQ9WylaOGsuy9wDVZn9wELosa74qTSmKFze998UKSz2i4bXi9hdGqldAiNbhdKBzN7LnUJPGmMrNru3GM1jR/ACCIWBbCsX9bdCUViED/sbnIRGaC3LLFaAgDy6dx+TG48wM2Upu1uR7/VkC/iK2zkEmDt+Na/ThfHTIEpso3VW8KLJKC9tGXawW+o/BQXxmgzuBb6gZ+Moun+28CpAylCSxAY8DjLvJgoI3361F3+swt5z4rYvmuy8CFGTVngoy6/m4m7XlnA+YWjVyOK5oZiNwNIx1CLkPwQiQn5+hrcPKNMlVjXhtEPsjGr1X0p/zz31gTimwSj5ijxu0FB6g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB2548.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62b9f062-b28f-4302-4ba5-08d88c9f9c30 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2020 15:27:21.9905 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HipWA/oyh0HxupK2RuB6Rw+jjhMn///4nBdspX12DmQhwtTxxJSEuor/OQGrQo1HgOdRpVgDuonLed4jrjl4Ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1622 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605799642; bh=CX8DA7yKHy4uekm7Hn6WyJVzAANl8QrGAb3C9d3DnyI=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=GS8/sKfHxYbVHGoVdQ0Q4upCn9Bla4PYp10K1no/4JMiDmBFUeZuWHZRBncT0SZfF wdS/IqEjxWkV3iPz8RMliSoSPRyhk55E/3FdCZOuHE70xd4YFNku/PnmvKUcLggD+R lMBLCcQid/BQGnUHsc9vxcZz2tl6rhFKiRvdhzbjunpyR1qlmQ2PmspjJJ+5K7gLkY rtswH6uYmWMtj6/M22V+jYGMIzzwPvtXc0XgxEnt3KqYgILJnUvByN1DLFCKVGHng+ 8nHw69APizqgOqkbfpYN4iW6/pDIkIMeT+sH3ZRrk+dnNz0m4eKy/2rS7wteSziX2l RnaXkwEGyCiOw== Subject: Re: [dpdk-dev] Windows: A fundamental issue (was eal/windows: definition for ETOOMANYREFS errno) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: Windows: A fundamental issue (was eal/windows: definition fo= r > ETOOMANYREFS errno) >=20 > External email: Use caution opening links or attachments >=20 >=20 > 19/11/2020 14:21, Tal Shnaiderman: > > > Subject: Re: Windows: A fundamental issue (was eal/windows: > > > definition for ETOOMANYREFS errno) > > > > > > External email: Use caution opening links or attachments > > > > > > > > > Hi Nick, > > > > > > > This means that rte_os.h should not include POSIX/Linux > > > > definitions to avoid clashes such as the one seen with this > > > > change. It's clearly not sustainable if applications have to be > > > > modified every time we add more Windows support to the DPDK. > > > > > > > > Note that this is not an isolated issue - most of the definitions > > > > in rte_os.h (redefining close, unlink, strdup etc) should not be > > > > present if other layers (application, other libraries, etc) are to > > > > be able to implement their own POSIX/Linux support. > > > > > > The purpose of rte_os.h must be clarified. It now says: > > > > > > /** > > > * This is header should contain any function/macro definition > > > * which are not supported natively or named differently in the > > > * ... OS. Functions will be added in future releases. > > > */ > > > > > > This doesn't specify if the file should expose wrappers or POSIX-name= d > bits. > > > Linux and FreeBSD, however, only use it for RTE_CPU_xxx() macros for > > > CPU_xxx() and don't define anything with POSIX names. So should > Windows. > > > > > > > Please can we back this change out until we have a strategy that > > > > allows us to make these definitions available for 'internal' use, > > > > but prevent them being visible outside of the DPDK tree. If we > > > > can't wrap them with > > > > rte_* yet, perhaps the short term solution could be as simple as > > > > setting RTE_DEFINE_POSIX when building DPDK code and hiding them > > > > if it is > > > not set? > > > > > > You need the same value both inside DPDK to return it and outside of > > > DPDK to match on it. Returning an unnamed, unspecified code is not an > option. > > > RTE_ prefix is a way to go. We can just rename ETOOMANYREFS. > > > > Thanks for the info Nick. > > Dmitry, If we go with RTE_ETOOMANYREFS, I assume we need to define it > for Linux and FreeBSD as well? >=20 > Or we can use a "more standard" error code? >=20 Right, Since it is used rarely and only in our PMD I'll work with the devel= oper on selecting a different errno and will revert this commit, apologies = for the inconvenience. >=20 > > > Strictly speaking, C standard defines very few errno, so using POSIX > > > values in API is incorrect anyway. It has to be deprecated and > > > removed eventually, we already had issues with MMAP_FAILED. >=20 >=20