From: Tal Shnaiderman <talshn@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: Nick Connolly <nick.connolly@mayadata.io>,
"dev@dpdk.org" <dev@dpdk.org>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
Ranjit Menon <ranjit.menon@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
"Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v2] windows: minor build fixes
Date: Sun, 15 Nov 2020 11:20:55 +0000 [thread overview]
Message-ID: <CY4PR1201MB2548C1797B369DA0E88DD98BA4E40@CY4PR1201MB2548.namprd12.prod.outlook.com> (raw)
In-Reply-To: <3636220.pJOGQ9ufTJ@thomas>
> Subject: Re: [dpdk-dev] [PATCH v2] windows: minor build fixes
>
> External email: Use caution opening links or attachments
>
>
> 12/11/2020 22:35, Tal Shnaiderman:
> > > Subject: Re: [dpdk-dev] [PATCH v2] windows: minor build fixes
> > >
> > > Missing / incorrect '--in-reply-to'. Please ignore - still learning the process!
> > >
> > > On 31/10/2020 06:43, Nick Connolly wrote:
> > > > Meson versions >= 0.54.0 include support for handling /implib with
> > > > msvc link. Specifying it explicitly causes failures when linking
> > > > against the dll. Tested using Link 14.27.29112.0 and Clang 11.0.0.
> > > >
> >
> > How can we verify this behavior change in 0.54 is intentional?
> > I cannot find it in the versions' release notes:
> >
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmes
> o
> > nbuild.com%2FRelease-notes-for-0-54-
> 0.html&data=04%7C01%7Ctalshn%4
> >
> 0nvidia.com%7C958236d4a61f4a12411808d887dcd2b7%7C43083d15727340c1
> b7db3
> >
> 9efd9ccc17a%7C0%7C0%7C637408729782053998%7CUnknown%7CTWFpbGZs
> b3d8eyJWI
> >
> joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1
> 000&a
> >
> mp;sdata=21h2QD1OJQt88icTM0kd%2FbkuFzlBq4J5tMJRsh4x9LY%3D&r
> eserved
> > =0
>
> I've found 2 commits touching implib in meson 0.54:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Fmesonbuild%2Fmeson%2Fcommit%2Fcace70c64eab4&data
> =04%7C01%7Ctalshn%40nvidia.com%7C958236d4a61f4a12411808d887dcd2b7
> %7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637408729782053998
> %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=w9k3%2FvRIWT8Jb
> Bm0HXYGZSqW2i0%2BZfq05jzloobNdyc%3D&reserved=0
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Fmesonbuild%2Fmeson%2Fcommit%2F06bbf6cf9353f6&data
> =04%7C01%7Ctalshn%40nvidia.com%7C958236d4a61f4a12411808d887dcd2b7
> %7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637408729782063987
> %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=62PcG42%2FiD3n8s
> 5%2BD7H6iYEvxS8hAGZFta1vR8suGSM%3D&reserved=0
>
Thanks Thomas, I assume it's part of their changes in that area.
>
next prev parent reply other threads:[~2020-11-15 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 6:39 Nick Connolly
2020-10-31 6:43 ` Nick Connolly
2020-10-31 7:00 ` Nick Connolly
2020-11-12 21:35 ` Tal Shnaiderman
2020-11-13 14:02 ` Thomas Monjalon
2020-11-15 11:20 ` Tal Shnaiderman [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-30 17:46 [dpdk-dev] [PATCH] Windows: " Nick Connolly
2020-10-31 6:44 ` [dpdk-dev] [PATCH v2] windows: " Nick Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1201MB2548C1797B369DA0E88DD98BA4E40@CY4PR1201MB2548.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=Harini.Ramakrishnan@microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=nick.connolly@mayadata.io \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).