From: Tal Shnaiderman <talshn@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
"dmitrym@microsoft.com" <dmitrym@microsoft.com>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: definition for ETOOMANYREFS errno
Date: Sun, 15 Nov 2020 14:23:07 +0000
Message-ID: <CY4PR1201MB2548CEA8462072FAA8554C23A4E40@CY4PR1201MB2548.namprd12.prod.outlook.com> (raw)
In-Reply-To: <10748722.TlkrfTdTIa@thomas>
> Subject: Re: [PATCH] eal/windows: definition for ETOOMANYREFS errno
>
> External email: Use caution opening links or attachments
>
>
> 14/11/2020 23:11, Tal Shnaiderman:
> > > On Sat, 14 Nov 2020 23:11:56 +0200, Tal Shnaiderman wrote:
> > > > The ETOOMANYREFS errno is missing from the Windows clang build is
> > > > it used in initialization of flow error structures.
> > >
> > > "is it" -> "it is"
> > >
> > > > The commit will define it as it is done in the minGW Windows build.
> > >
> > > "The commit will" is unnecessary.
> > >
> > > "minGW" -> "MinGW"
>
> [...]
> > Thank you for the comments Dmitry, will send a v2 promptly.
>
> Just a detail, I see you missed this comment in v2:
> "The commit will" is unnecessary.
>
Yes I missed it, Thanks for noticing Thomas.
>
next prev parent reply other threads:[~2020-11-15 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 21:11 Tal Shnaiderman
2020-11-14 22:01 ` Dmitry Kozlyuk
2020-11-14 22:11 ` Tal Shnaiderman
2020-11-15 10:51 ` Thomas Monjalon
2020-11-15 14:23 ` Tal Shnaiderman [this message]
2020-11-14 22:21 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2020-11-14 23:13 ` Dmitry Kozlyuk
2020-11-15 23:10 ` Thomas Monjalon
2020-11-17 10:51 ` [dpdk-dev] Windows: A fundamental issue (was eal/windows: definition for ETOOMANYREFS errno) Nick Connolly
2020-11-17 12:53 ` Dmitry Kozlyuk
2020-11-19 13:21 ` Tal Shnaiderman
2020-11-19 14:46 ` Thomas Monjalon
2020-11-19 15:27 ` Tal Shnaiderman
2020-11-19 15:38 ` Nick Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1201MB2548CEA8462072FAA8554C23A4E40@CY4PR1201MB2548.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
DPDK patches and discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
dev@dpdk.org
public-inbox-index dev
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.dev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git