Linux epoll mechanism is not implemented in Windows. Add stub similarly to freeBSD. Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> --- lib/librte_eal/windows/eal_interrupts.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c index 6c64a48f34..6f7a1c7acc 100644 --- a/lib/librte_eal/windows/eal_interrupts.c +++ b/lib/librte_eal/windows/eal_interrupts.c @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg) return 0; } + +void +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle) +{ + RTE_SET_USED(intr_handle); +} -- 2.16.1.windows.4
On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> Linux epoll mechanism is not implemented in Windows.
>
> Add stub similarly to freeBSD.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
> index 6c64a48f34..6f7a1c7acc 100644
> --- a/lib/librte_eal/windows/eal_interrupts.c
> +++ b/lib/librte_eal/windows/eal_interrupts.c
> @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
>
> return 0;
> }
> +
> +void
> +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
> +{
> + RTE_SET_USED(intr_handle);
> +}
This will not be of much use if you don't export it in
rte_eal_exports.def, right?
--
David Marchand
> Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for > rte_intr_free_epoll_fd > > External email: Use caution opening links or attachments > > > On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman <talshn@nvidia.com> > wrote: > > > > Linux epoll mechanism is not implemented in Windows. > > > > Add stub similarly to freeBSD. > > > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> > > --- > > lib/librte_eal/windows/eal_interrupts.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/lib/librte_eal/windows/eal_interrupts.c > > b/lib/librte_eal/windows/eal_interrupts.c > > index 6c64a48f34..6f7a1c7acc 100644 > > --- a/lib/librte_eal/windows/eal_interrupts.c > > +++ b/lib/librte_eal/windows/eal_interrupts.c > > @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), > > void *arg) > > > > return 0; > > } > > + > > +void > > +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle) { > > + RTE_SET_USED(intr_handle); > > +} > > This will not be of much use if you don't export it in rte_eal_exports.def, > right? You're absolutely right, thank you for noticing, I'll send a v2 promptly. > > -- > David Marchand
Linux epoll mechanism is not implemented in Windows. Add stub similarly to freeBSD. Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> --- v2: add missing export in def file [DavidM] --- lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/windows/eal_interrupts.c | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 6a6be1cfa6..50e6cd3d42 100644 --- a/lib/librte_eal/rte_eal_exports.def +++ b/lib/librte_eal/rte_eal_exports.def @@ -63,6 +63,7 @@ EXPORTS rte_get_tsc_hz rte_hexdump rte_hypervisor_get + rte_intr_free_epoll_fd rte_intr_rx_ctl rte_lcore_count rte_lcore_has_role diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c index 6c64a48f34..6f7a1c7acc 100644 --- a/lib/librte_eal/windows/eal_interrupts.c +++ b/lib/librte_eal/windows/eal_interrupts.c @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg) return 0; } + +void +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle) +{ + RTE_SET_USED(intr_handle); +} -- 2.16.1.windows.4
On Thu, 19 Nov 2020 17:18:11 +0200, Tal Shnaiderman wrote:
> Linux epoll mechanism is not implemented in Windows.
>
> Add stub similarly to freeBSD.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
>
> ---
> v2: add missing export in def file [DavidM]
> ---
> lib/librte_eal/rte_eal_exports.def | 1 +
> lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
> 2 files changed, 7 insertions(+)
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>