From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2317A04DC; Sun, 22 Nov 2020 10:01:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 092B06CC6; Sun, 22 Nov 2020 10:01:09 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 267AFFFA; Sun, 22 Nov 2020 10:01:07 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 22 Nov 2020 01:01:08 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 22 Nov 2020 09:00:56 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 22 Nov 2020 09:00:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dhaY0DYQIhatRE3ouQZqsTRSsQ9NGau9fmAj9d4wSLW7rnxmrSy2zGHBwWpQvxb8GwzjEm7i+LhaOQ69ntLMBaPNYWe2WD8U+LEObinBAeyM0kQeX9PiQ+hKtfGR0OFRsKlkpUnnMQVDjiJnW9iBohax3OiOu4rK7w9xuFoslmT5pG4BL05cPvmNNA7NyeEsI2ryGoIVXGsrNxm32Vu8dK9HeI1dBx6+jzqHB6pVNX2fJJaVYxcJoe3iJdXpTutAoOr7jejsBhGE6PAxev1PQvSnxQ0muMUOONvMz9gf0uuFCzmdu5XCOZA51GQ72G0KmvwfNQgvvFlcEu54CG58cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3vHWzo3fCDliUiWfOvzktrH+02Ron4ElUDbQyw7qjAw=; b=alhYjus5N1fegtjpS6JvShL2+sueA7ybG/1TuZTt1niaYgBsTh/0uDxBksiOCP3P4Aq8wCdbRPfHpcQaCdlXrrrScco2+/hsClsBWyOMd34qe1SltqOBjDZhy2frrOj47xZiuE1XvZIdJxopNLZJvXunW5EMUW+oo8UWTwbZCWj73gvxFwAFtPRHkRen/dUoNThgJfCI7r6dzEsJfmXPr0ip/yPoEiVrY78KPXMNuweq687x5uVhc6sWKJPV2hhmWG8gimjtc5u9rrGKjBWkYjHR0frYSFGZ9xoeVyHgC+OhIowjhpxp6Xh/LTIlwqiaFu4ZhJb8sckdJA/g5zGgxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from CY4PR1201MB2548.namprd12.prod.outlook.com (2603:10b6:903:d8::18) by CY4PR1201MB0040.namprd12.prod.outlook.com (2603:10b6:910:1b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Sun, 22 Nov 2020 09:00:55 +0000 Received: from CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42]) by CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42%8]) with mapi id 15.20.3589.021; Sun, 22 Nov 2020 09:00:55 +0000 From: Tal Shnaiderman To: Nick Connolly , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Tal Shnaiderman CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] eal/windows: fix link error with MinGW Thread-Index: AQHWwKvi+2+e3rWnjEmqVngHEN3I0anT14sA Date: Sun, 22 Nov 2020 09:00:55 +0000 Message-ID: References: <20201120211255.24803-1-nick.connolly@mayadata.io> <20201122084515.26348-1-nick.connolly@mayadata.io> In-Reply-To: <20201122084515.26348-1-nick.connolly@mayadata.io> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mayadata.io; dkim=none (message not signed) header.d=none;mayadata.io; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.141.17] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa35b68f-24c5-4c90-6fb6-08d88ec51f2b x-ms-traffictypediagnostic: CY4PR1201MB0040: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:393; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4ksGnfG123GKHfoYldmRzC9kwh4/vvkwf2rNgnPlga7KbXc+vcWo8LmWRh59AHP6HcYvfoHsf/vT2594/7ymYdCZ08ygBESBVyePxlYccR5WHNJQ3ae51j2TmrJAGACIX5uklo2Tm0B7tOjng7c7IL/DYnCQ2niwn5hGEEKN9Yue2/iFwE9+p92faPRAzMFm0VuREFjTAuRfv4JXu4rzuxOApaILF1pvKwWj9eoLyVWC9Dr1T0SgUv3HKA3XoRZxZX4vA+tXwn0A1A2jLEkKc8BxKtgMN6LfP+QbWuENL6C8Fq8Ghv2uNEAm2VASVYhuoI3tH6khDNBlmRfvN5dmsw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1201MB2548.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(396003)(346002)(39850400004)(9686003)(55016002)(64756008)(76116006)(66476007)(66556008)(66446008)(86362001)(2906002)(71200400001)(316002)(6506007)(110136005)(52536014)(54906003)(5660300002)(83380400001)(33656002)(8676002)(66946007)(4326008)(478600001)(186003)(26005)(7696005)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: EbDvMYRmi10z3EzsAh1VO/bgPn2Ugl0zP9HljDHz0Fe8ljS1u9MEtO7ryDlgNPuUAQjrJfqhTU48B1XUrxEGgRUm3hvYEa69Tu7C7DmPsnqimI0YKeo0MaoyY9IMI+CKBwGIFz3DZYVPQDndIBSmq1CnhfsRP4NOJFK137hnF/3lJqmmvq4ukYp92f+BBuLfosm+DCWcCYpjB9kfYXAgtwOCw6DJaye5mjlJCga2yPgVRyFhHJ8apqxb0QPrV1XQ1nsiS14diDY63659f9Wfs3Sx04GFjHfketRfP75FlR+Nn083yIxm9ZDY2ImtNPB/ABEHDyAkwBXonKh4xjzU1cGpj0QSENPDjG88sBB16uQgKa5UHGz+5e81RFUZd6RMGFx3p4eLcrbQIX47UfcaSiieLhMT4bL/6VJGAMu2TtbaWuH8bvE8lmGr2WUbYgFklHgJHkW9srpegl1xp1ilDZTPhMwMVLoUI9ffR+60D+8fh6EhLi6dwOMYcGagZ14WRlwGhUJMST2DCRWGNQlij2QNoAIINXg/06ASwEWRThibqnI2YhUUCXJQ+phP4T1Zt5FIU2PSZ/piuN6EGuGO0WxN9JHLrLNigqQpkcvyxM+LuhdU2iOB/b2FuYNsk3hiSEdz+nNEA3qJ9IMzQmRtpz05z26i0fmC9fPgCGYKr+qlIyydYNnM6QUxvKQwrB2ogCKs74UmRlXN/z3eRluZ8gSb19AkPgBQOOKDOrkTiPhvB8fFuPUPxinA15ag9N+mTEyxemedQS5M0KYA4IHecQTTXedVajw/gDkppiq7yk8jYOVA7LeoSQmoJtverkLzE8mOt778RvMQMFv7HGAwbN/03ZmGikyxk5+zcTlptLZxiEnrOMKwvQpSPMI9mKibqB9CyuCGwPVjfMa78b6aug== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB2548.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa35b68f-24c5-4c90-6fb6-08d88ec51f2b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2020 09:00:55.4487 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IWeZrVdnH0R9ifjmg68aeWdvIhqxi6liKa8Rc56aIOkuv0WZpNtlpd+YE8cmWEJUntiO1PKC+QmwY3sc76RrEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0040 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606035668; bh=3vHWzo3fCDliUiWfOvzktrH+02Ron4ElUDbQyw7qjAw=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-ms-exchange-transport-forked:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=g5tmJro+dmV78gLqwWi0W1uCWMp9hwpiZJZ7LvopoctsWeOivBlUp7HZGh7LD4yLq iBHKvVIy/fjhpn76DOZ8fwMwNGk7a45L9bz4HSDHVhDgh0hiGbymTKIi35Tht4AfJd MQ+RRkDOrsIWjXkjYJczHH2eQRI1MgeEQwgLxkcITEjPDuDZOpGU+8dBO/ksb3WtPz +d8BwPGrvT3wawf7uVYZc6egJwNRVe1b2gVHXGSs6frex4oC5EsvwoSC4GunaSenR1 p0FW66rAYDnex0PhtsG3v5JQmiKOloNNLP4BQyVPZOWe9yLpT7mD7L0S0+Iwa5+FhI iTc1HjSB4nXcg== Subject: Re: [dpdk-dev] [PATCH v3] eal/windows: fix link error with MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH v3] eal/windows: fix link error with MinGW >=20 > Linking with the 'pci' driver when building with MinGW on Windows fails w= ith > undefined symbol 'GUID_DEVCLASS_NET'. > This occurs because devguid.h is included in rte_windows.h before INITGUI= D > is defined. >=20 > Move the include of devguid.h after the definition of INITGUID. >=20 > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") > Cc: stable@dpdk.org >=20 > Signed-off-by: Nick Connolly > --- > v2 > * Change Cc to stable@dpdk.org > v2 > * Fix commit message - add blank line, use present tense >=20 > lib/librte_eal/windows/include/rte_windows.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eal/windows/include/rte_windows.h > b/lib/librte_eal/windows/include/rte_windows.h > index 0a5e71a05..b82af34f6 100644 > --- a/lib/librte_eal/windows/include/rte_windows.h > +++ b/lib/librte_eal/windows/include/rte_windows.h > @@ -25,13 +25,13 @@ > #include > #include > #include > -#include >=20 > /* Have GUIDs defined. */ > #ifndef INITGUID > #define INITGUID > #endif > #include > +#include > #include >=20 > /** > -- > 2.25.1 Reviewed-by: Tal Shnaiderman