Re: [dpdk-dev] [PATCH v2] crypto/ccp: support command line option to enable CPU based auth

["Kumar, Ravi1" <Ravi1.Kumar@amd.com>]

>Hi Ravi,
>
>> -----Original Message-----
>> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
>> Sent: Wednesday, May 9, 2018 1:46 PM
>> To: dev@dpdk.org
>> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; 
>> thomas@monjalon.net; hemant.agrawal@nxp.com
>> Subject: [PATCH v2] crypto/ccp: support command line option to enable 
>> CPU based auth
>> 
>> CCP PMD supports authentication offload to either of CCP or CPU.
>> The earlier version of patch provides this option as compile time.
>> This patch changes this option from compile time to run time.
>> User can pass "ccp_auth_opt=1" as an additional arguments to vdev 
>> parameter to enable authentication operations on CPU.
>> 
>> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
>
>...
>
>>  RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_CCP_PMD,
>> cryptodev_ccp_pmd_drv);
>>  RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_CCP_PMD,
>> -	"max_nb_queue_pairs=<int> max_nb_sessions=<int> socket_id=<int>");
>> +	"max_nb_queue_pairs=<int> "
>> +	"max_nb_sessions=<int> "
>> +	"socket_id=<int> "
>> +	"ccp_auth_opt=<int>");
>
>
>Die_num is not in this list. I was going to add it myself, but then I realized that it is not actually used anywhere.
>Am I missing something?
>
>Also, I think it is worth updating the documentation of the PMD with these parameters.
>
>Thanks,
>Pablo
>
Hi Pablo,

Die-num parameter is going to be used in future. Will remove for now and send an updated patch.

Thanks,
Ravi