From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Ravi1.Kumar@amd.com> Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0077.outbound.protection.outlook.com [104.47.32.77]) by dpdk.org (Postfix) with ESMTP id BFC8BAAD2 for <dev@dpdk.org>; Thu, 10 May 2018 10:43:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tkEH2Y6CbS349enWput1EEF2r+vdYXcsMHfPwUMSE7g=; b=eTnFnXzeXYGP2u8+hcPhbrBbVI13tCBsJkdJto9O8/xLRBW1JgachbUC9nukhYuUuBpjWHBIrPam+oRbksTP0WIr7S47OXJiA4VV9GSctyQutAQOc+dg5jtdQFnfUaqg3kiGCRYcs8/IAZQiK8Kv/puo6D+poANm/Mp1kAcqtDE= Received: from CY4PR12MB1509.namprd12.prod.outlook.com (10.172.68.22) by CY4PR12MB1365.namprd12.prod.outlook.com (10.168.169.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.19; Thu, 10 May 2018 08:43:08 +0000 Received: from CY4PR12MB1509.namprd12.prod.outlook.com ([fe80::392b:5a94:99ce:33b8]) by CY4PR12MB1509.namprd12.prod.outlook.com ([fe80::392b:5a94:99ce:33b8%17]) with mapi id 15.20.0735.019; Thu, 10 May 2018 08:43:08 +0000 From: "Kumar, Ravi1" <Ravi1.Kumar@amd.com> To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "thomas@monjalon.net" <thomas@monjalon.net>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com> Thread-Topic: [PATCH v2] crypto/ccp: support command line option to enable CPU based auth Thread-Index: AQHT56pR4+CLy5JItk2DPZ4w/3AziKQopnAw Date: Thu, 10 May 2018 08:43:08 +0000 Message-ID: <CY4PR12MB150916599449E58611747C8FAE980@CY4PR12MB1509.namprd12.prod.outlook.com> References: <1525327041-128382-1-git-send-email-Ravi1.kumar@amd.com> <1525869983-4705-1-git-send-email-Ravi1.kumar@amd.com> <E115CCD9D858EF4F90C690B0DCB4D8976CD05715@IRSMSX108.ger.corp.intel.com> In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CD05715@IRSMSX108.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ravi1.Kumar@amd.com; x-originating-ip: [202.56.249.162] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR12MB1365; 7:rbUF7yE+hxkc5LE0hRGQg5UjZ8b6szZpOYSlEmZ0cB0ew8q0Y6m/POylhdEVpI5kFsZxwZl8UXgTkfrHkXcwQj/7WR+BwqwM6ucz7PmUtzkKqtTeHfz2TpH5Csy6/jrndzIyXAoBuK0g30LdRFLo0Ahi6rj2IKIA33QTilisxMfEz1SIyuMAfzI84CcZYddzGj2zV/3g1KgVKeAc7K1iAa82VW9qMfmjrJvF4dC20LtD5i9NmMmExiyMykIrLUTX; 20:CXJsrhBwDF1z/oGkKFE4wFvqLz6fZGfMYEgsGzdf9XPhScz0YsPFlZi7aomaVteKtuV1Z+Nfvc6AO9ShKTi0OJSRAQVyYwqBq5FmbgGhZOeTKStM8INZZs27Z2IlHp8kdIizfxdsOTD0HdmIx6uXIg0KnddKKhK4M+lPVRpMTbL+yGePNAre5WLtGLK+GNBuCi91Fj8rqUTDcG80V/T8Fr3NOiMpvUvErFM31sX7sRTQy51mXSyHMMQtu0D4+/ti x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:CY4PR12MB1365; x-ms-traffictypediagnostic: CY4PR12MB1365: x-microsoft-antispam-prvs: <CY4PR12MB136520A3A0A6D397AE964C7AAE980@CY4PR12MB1365.namprd12.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(185117386973197)(767451399110)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR12MB1365; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1365; x-forefront-prvs: 066898046A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(346002)(366004)(376002)(396003)(13464003)(189003)(199004)(316002)(53546011)(110136005)(8656006)(72206003)(54906003)(66066001)(478600001)(68736007)(74316002)(102836004)(6506007)(33656002)(5660300001)(229853002)(8676002)(7696005)(305945005)(81156014)(186003)(26005)(76176011)(4326008)(8936002)(81166006)(7736002)(97736004)(6436002)(86362001)(6116002)(3660700001)(2501003)(5250100002)(3280700002)(25786009)(99286004)(2900100001)(105586002)(106356001)(6246003)(55016002)(9686003)(3846002)(2906002)(53936002)(486006)(446003)(476003)(11346002)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1365; H:CY4PR12MB1509.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: TX3yYUInEvExKNJ83Hd8+FPsywmx16a0xPv51DF4d+xIhjIXZv6NL+mOFzF0rPjgXDV+XRYrZPTRfbm1AAjXhNsRqZdmBth3DyYDWhc8SMnHHhn2iz5wKTnh0KXsIO26eMO3MlDEK/MUsp8A1zfA7ZHnFXMEMDnYwbSYoiX3INtkcZf9FXQyH0Cmq74iZ7nZ spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 1917f5cb-ddcb-4d1a-0ec9-08d5b6520e38 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1917f5cb-ddcb-4d1a-0ec9-08d5b6520e38 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2018 08:43:08.3046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1365 Subject: Re: [dpdk-dev] [PATCH v2] crypto/ccp: support command line option to enable CPU based auth X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 10 May 2018 08:43:11 -0000 >Hi Ravi, > >> -----Original Message----- >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com] >> Sent: Wednesday, May 9, 2018 1:46 PM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;=20 >> thomas@monjalon.net; hemant.agrawal@nxp.com >> Subject: [PATCH v2] crypto/ccp: support command line option to enable=20 >> CPU based auth >>=20 >> CCP PMD supports authentication offload to either of CCP or CPU. >> The earlier version of patch provides this option as compile time. >> This patch changes this option from compile time to run time. >> User can pass "ccp_auth_opt=3D1" as an additional arguments to vdev=20 >> parameter to enable authentication operations on CPU. >>=20 >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com> > >... > >> RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_CCP_PMD, >> cryptodev_ccp_pmd_drv); >> RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_CCP_PMD, >> - "max_nb_queue_pairs=3D<int> max_nb_sessions=3D<int> socket_id=3D<int>"= ); >> + "max_nb_queue_pairs=3D<int> " >> + "max_nb_sessions=3D<int> " >> + "socket_id=3D<int> " >> + "ccp_auth_opt=3D<int>"); > > >Die_num is not in this list. I was going to add it myself, but then I real= ized that it is not actually used anywhere. >Am I missing something? > >Also, I think it is worth updating the documentation of the PMD with these= parameters. > >Thanks, >Pablo > Hi Pablo, Die-num parameter is going to be used in future. Will remove for now and se= nd an updated patch. Thanks, Ravi