From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0080.outbound.protection.outlook.com [104.47.36.80]) by dpdk.org (Postfix) with ESMTP id 2CE19AAC2 for ; Tue, 17 Apr 2018 08:11:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QZMhmrrrbosHbyt3tjDMN/Hag6kr14k98KuCLVI2Y58=; b=amAzYo4kUN04tXRb60w0LW/knwkGbVdpKS5NrySXO6/Qsrlr1sXpmqfuyi8kQFgsRCQSKtTMbeDF3nskFvv09sZM6uNWncrajp0a8xaQfN2fowRiQQBsMpEiVfgrT5j+CvehvOLFO8vKemHczJqcEAE82AQL4v3zpqJv6SOLG+Q= Received: from CY4PR12MB1509.namprd12.prod.outlook.com (10.172.68.22) by CY4PR12MB1669.namprd12.prod.outlook.com (10.172.72.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Tue, 17 Apr 2018 06:11:32 +0000 Received: from CY4PR12MB1509.namprd12.prod.outlook.com ([fe80::d52f:887:8f07:7479]) by CY4PR12MB1509.namprd12.prod.outlook.com ([fe80::d52f:887:8f07:7479%18]) with mapi id 15.20.0675.015; Tue, 17 Apr 2018 06:11:32 +0000 From: "Kumar, Ravi1" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" Thread-Topic: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD Thread-Index: AQHTyHj0xpSPnWySvUK0bVfuQ8dU+aPs+/sggBaPSICAAQmbIA== Date: Tue, 17 Apr 2018 06:11:32 +0000 Message-ID: References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com> <1521462233-13590-1-git-send-email-Ravi1.kumar@amd.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [202.56.249.162] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR12MB1669; 7:IIiQOZHQI8Pzad+kHXpGpwPIq84x0fykzPZVg/Et5FHk9KcSIIIQU7R69Z4ZMOEjk31VtX0prOPLoxbrRi+JYhObP+ldEwyhpIPvxjAg9jeoOVp3mqps7af1pjhcD8s/Y0vvuvTpqayzjxsAvy5w35oobjL15P8OVBYoGlat4RuweAV4fljacC5u9+mnbGTRYsqdlrbO4jnpaGg5yANMGLDQzVm+jTEYsrS/Hfh+8LS/ErQYAbB116X1p0t2Rwbw; 20:WLbTHA3C0v64a14aRXw5EsT7CzzxMAKDWmKGeanzygTwUqwm7LPrXsszQswh2HEZhB1byPBL64pBNo2Rj9z1qln/StvyFeoBg+BBEV9b7/YYnJfOxsxyCylMtrU7+uoxAv6WaVnJ1ag3dr8SoY0i9rEbP74rB7Pzb9R+fnB6xV466D+FN/XmK1N4obFUJRHLEnyoLZGPxpwaj4Ydpf51imsz6Gw+v2F9OFHI7vWlUbmb8XIcfOG4JTcZIvgb444Q x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(2017052603328)(7153060)(7193020); SRVR:CY4PR12MB1669; x-ms-traffictypediagnostic: CY4PR12MB1669: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ravi1.Kumar@amd.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(767451399110)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231232)(944501359)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR12MB1669; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1669; x-forefront-prvs: 0645BEB7AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(366004)(376002)(346002)(396003)(199004)(189003)(51914003)(13464003)(2900100001)(53546011)(5660300001)(4326008)(25786009)(102836004)(3846002)(93886005)(2906002)(110136005)(8936002)(66066001)(6436002)(476003)(11346002)(9686003)(316002)(97736004)(2501003)(86362001)(5250100002)(14454004)(53936002)(6506007)(105586002)(446003)(486006)(81166006)(8676002)(26005)(229853002)(305945005)(186003)(99286004)(6246003)(81156014)(7696005)(68736007)(3280700002)(76176011)(74316002)(55016002)(8656006)(106356001)(33656002)(3660700001)(6116002)(7736002)(72206003)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1669; H:CY4PR12MB1509.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: OxM5MKl0qB9wAxi7Xz/kyugZeKgerfoNDph2MXRNai/0xZl0x7crT8qQFmh8NJOlst2tuE1+Xz+U7TnXtvlYmyUVAaB4xM3iOvuvXIPZBx/hmN00IsmQWOinsoQDExYqGv8rHhP9xFh1OLJz5RDAuZm0ermIjxO1vH+V+fVdDt2vVzgacwYmAabJ/o7zz7kH spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f430f1f7-cb48-4d04-fb2b-08d5a42a110a X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f430f1f7-cb48-4d04-fb2b-08d5a42a110a X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2018 06:11:32.2976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1669 Subject: Re: [dpdk-dev] [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 06:11:34 -0000 >Hi Ravi, > >> -----Original Message----- >> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com] >> Sent: Monday, April 2, 2018 6:50 AM >> To: De Lara Guarch, Pablo ;=20 >> dev@dpdk.org >> Cc: hemant.agrawal@nxp.com >> Subject: RE: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD >>=20 >> > >> > >> >> -----Original Message----- >> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com] >> >> Sent: Monday, March 19, 2018 12:24 PM >> >> To: dev@dpdk.org >> >> Cc: De Lara Guarch, Pablo ;=20 >> >> hemant.agrawal@nxp.com >> >> Subject: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD >> >> >> >> Signed-off-by: Ravi Kumar >> > >> >Patchset applied to dpdk-next-crypto, with same minor changes (title=20 >> >changes >> and driver registering modification due to an earlier patch). >> > >> >Thanks for the work! >> >Pablo >> > > >There's been a memory rework applied in DPDK at the same time I applied yo= ur PMD in next-crypto, Which means that it is broken now. Could you submit = a fix for it? >At least, compilation is broken now, but it may require more changes: > >drivers/crypto/ccp/ccp_dev.c:98:7: error: implicit declaration of function= 'rte_eal_get_physmem_layout' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > ms =3D rte_eal_get_physmem_layout(); > >This function does not exist anymore. >Commit 2d84772bf858 ("crypto/qat: use contiguous allocation for DMA memory= ") makes a similar required changed in QAT. >Take a look at it and see if it suits you. > Hi Pablo, Sure, we will send updated patch for this. Regards, Ravi >>=20 >> Thanks a lot Pablo. >>=20 >> Regards, >> Ravi >