From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Ravi1.Kumar@amd.com>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0042.outbound.protection.outlook.com [104.47.42.42])
 by dpdk.org (Postfix) with ESMTP id F0BF910BD
 for <dev@dpdk.org>; Mon, 23 Apr 2018 08:41:18 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=amdcloud.onmicrosoft.com; s=selector1-amd-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=HOxVosD9VSO5WhAMD+NhEgiLlrL7Q33/UjWqiIPbRL4=;
 b=ivm2HTHbTc/nC5vxCeVgaa+Jojie8LCxZpW5iFtbVPbTbKChAzmY/nmMP8uRQqqWMlvrrayqsAoYPphmjHlk1Go2zkbBgXe6inQFvK+DFWdUmhKzdN8x03ym25XSEjO+931wq6Yazva84LjaB7AioWzbxwwm6OtjjREO127HaVI=
Received: from CY4PR12MB1509.namprd12.prod.outlook.com (10.172.68.22) by
 CY4PR12MB1702.namprd12.prod.outlook.com (10.175.62.136) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
 15.20.696.13; Mon, 23 Apr 2018 06:41:16 +0000
Received: from CY4PR12MB1509.namprd12.prod.outlook.com
 ([fe80::d52f:887:8f07:7479]) by CY4PR12MB1509.namprd12.prod.outlook.com
 ([fe80::d52f:887:8f07:7479%18]) with mapi id 15.20.0696.015; Mon, 23 Apr 2018
 06:41:16 +0000
From: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>
To: Thomas Monjalon <thomas@monjalon.net>, "pablo.de.lara.guarch@intel.com"
 <pablo.de.lara.guarch@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "hemant.agrawal@nxp.com"
 <hemant.agrawal@nxp.com>
Thread-Topic: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5
 and sha2 family authentication algo
Thread-Index: AQHT2nXFE6JwOvL1WkCkb8yOh792paQN5uhg
Date: Mon, 23 Apr 2018 06:41:16 +0000
Message-ID: <CY4PR12MB150945F0773648FE86FF72E8AE890@CY4PR12MB1509.namprd12.prod.outlook.com>
References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com>
 <1521462233-13590-1-git-send-email-Ravi1.kumar@amd.com>
 <1521462233-13590-17-git-send-email-Ravi1.kumar@amd.com>
 <14946114.ASIPbkMQcp@xps>
In-Reply-To: <14946114.ASIPbkMQcp@xps>
Accept-Language: en-IN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: monjalon.net; dkim=none (message not signed)
 header.d=none;monjalon.net; dmarc=none action=none header.from=amd.com;
x-originating-ip: [202.56.249.162]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; CY4PR12MB1702;
 7:HFlEk7rdYZAZL/phPbMhsH7CCkSn4g/WkQnVaMJ5bh1Cg0tUSoEpGtScN+da/CDb0FjLr/jjE4QqsYC4ZmNEUmSnDIj3547yNJN+kOc1ALKQEyQ1mOzcGab3ic2Xqn1vFOhFBUgtd1VKc3/QLgPJHZkp4tJ86opDBg8HH1+a8ir4irBTSADAUW3XEJwv0jR8GrGZpNMGPRUFqjcT405TAhC4HmSr1rHCKFirrvT9TRzBtKRjsBa36suM4Fw15mly;
 20:x9SggPi7cN51yqcKIE1lcD7RAqJDLKV8Fa+EbPZ8HTraMx+o8xoorMt/Skhg1cpTmIjwV1jk3fLIAv1Rl/0W/1icumHZ5qddAn9W4/4rEIpdM+gD7KIISJVf0G4sE+ZnQbOL26F2G3wEC4W0etIIJ3JVx7/tA14GArjWnb+lL4ZASGbPRqedKc8p/ZUmnYjxJQqplI9GHtKwU0x6mbiXCa8ETI5eC5p1uJNXeP2Bv/fz1wTe0i722I3T8MCIM+wn
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);
 SRVR:CY4PR12MB1702; 
x-ms-traffictypediagnostic: CY4PR12MB1702:
x-microsoft-antispam-prvs: <CY4PR12MB170266A1F2DEB756A2A97F8CAE890@CY4PR12MB1702.namprd12.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(767451399110);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231232)(944501410)(52105095)(10201501046)(6055026)(6041310)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011);
 SRVR:CY4PR12MB1702; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1702; 
x-forefront-prvs: 06515DA04B
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(396003)(39860400002)(366004)(39380400002)(376002)(346002)(66066001)(54906003)(6506007)(110136005)(26005)(59450400001)(102836004)(33656002)(8656006)(55016002)(6436002)(53936002)(9686003)(76176011)(476003)(7696005)(93886005)(316002)(229853002)(4326008)(11346002)(6246003)(446003)(186003)(2900100001)(72206003)(5250100002)(2501003)(7736002)(25786009)(81166006)(478600001)(8676002)(8936002)(86362001)(2906002)(3280700002)(3660700001)(5660300001)(6116002)(3846002)(74316002)(305945005);
 DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1702;
 H:CY4PR12MB1509.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; 
x-microsoft-antispam-message-info: o3vosoa57CBhEmwiI24P5ElRop81OAT69jJ++tUP860DMn/TFCyxa4DnvU/ga58ejSsSiuXshwNKNLy0GRS2s6VEAk25ZhCwfR22/7EgUVyrnbU3I6NloEIXznXY2PUAxIX2Vfz/IzN9TqgMk9b7JdKs4xYNrsUP11QW2r5irPs0ZduqSEpX2NqufsGlpTvr
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 22842ab3-d266-4871-76c9-08d5a8e5370e
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22842ab3-d266-4871-76c9-08d5a8e5370e
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2018 06:41:16.6215 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1702
Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5
 and sha2 family authentication algo
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Apr 2018 06:41:19 -0000

>Hi,
>
>I am doing some late comments because I have a quick look when trying to p=
ull next-crypto in master branch.
>Unfortunately, it doesn't met the basic quality criterias.
>
>
>19/03/2018 13:23, Ravi Kumar:
>> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
>> ---
>>  config/common_base                   |   1 +
>>  drivers/crypto/ccp/ccp_crypto.c      | 282 ++++++++++++++++++++++++++++=
++++++-
>>  drivers/crypto/ccp/ccp_crypto.h      |   5 +-
>>  drivers/crypto/ccp/ccp_pmd_ops.c     |  23 +++
>>  drivers/crypto/ccp/ccp_pmd_private.h |  10 ++
>>  5 files changed, 316 insertions(+), 5 deletions(-)
>[...]
>> +CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dn
>
>Why introducing a compile-time option?
>Can it be a run-time option of the device?
>We must not add compile-time device option if not well justified.
>
>Talking about justification, there is 0 explanation in the commit messages=
.
>But there are some in next-crypto tree. Where do they come from?
>

Hi Thomas,

The detailed commit messages were missing from the earlier patches. Later a=
fter the patch were applied to dpdk-next-crypto, Pablo requested detailed c=
ommit messages for patches and just not to populate the mail-chain unnecess=
arily, the messages were later squashed in the commits offline.

Here is the explanation of the patch:

By default, all the crypto operations (cipher + auth) are offloaded to CCP =
engines. When user enables CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dy, the auth=
 operations are not offloaded to CCP and rather performed over CPU. We kept=
 this feature as a compile time option in order to let user decide whether =
to run auth operations on CCP or CPU as some of the auth operations perform=
s faster on CPU as compared to their performance on CCP.

Regards,
Ravi