From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0077.outbound.protection.outlook.com [104.47.42.77]) by dpdk.org (Postfix) with ESMTP id 48A982C55 for ; Tue, 12 Dec 2017 12:46:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rzNHOboRqM5OIxKDZyDC588MLwmJ4eQNB8Q98601cD4=; b=l+/vu57t9ZONxNcKcxo21Ta0dG1ElGf/94R3uWZVwsuugPso6E5v9lBWyAl4uBhcoUuwAN2Ci8bRv9ST/mOA5D9Zu1tF0lA2nL8St5fK1KuA76LHP4uzqj+2qiebI6GkeDofohpXFtg9YbUFCWgWbV5/bSZRWN9tfg4W7jgRMuw= Received: from CY4PR12MB1509.namprd12.prod.outlook.com (10.172.68.22) by CY4PR12MB1509.namprd12.prod.outlook.com (10.172.68.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Tue, 12 Dec 2017 11:46:21 +0000 Received: from CY4PR12MB1509.namprd12.prod.outlook.com ([10.172.68.22]) by CY4PR12MB1509.namprd12.prod.outlook.com ([10.172.68.22]) with mapi id 15.20.0302.013; Tue, 12 Dec 2017 11:46:21 +0000 From: "Kumar, Ravi1" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP crypto PMD Thread-Index: AQHTad1rzNKGj7LksU26R6n1M5raG6M+nuuAgAEK9mA= Date: Tue, 12 Dec 2017 11:46:21 +0000 Message-ID: References: <1512047553-118101-1-git-send-email-Ravi1.kumar@amd.com> <1512047553-118101-2-git-send-email-Ravi1.kumar@amd.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ravi1.Kumar@amd.com; x-originating-ip: [202.56.249.162] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR12MB1509; 20:YJNsdfYinBiTFarxsX8eCXqc1rcpWEqMEtYBuHmO8GM6HfswZ6bA8UH0m/ITe4WfA34oCfpfiwDaAXiymkNjq7lqiIvCH+336dtgptdTa66BG5PlCoZLhiG11x3EEKNDBRZ+sB/ZLrKc2DwmVd3AHc2pD3K1U3hmYHkVXuy+dY1HWYU4yshZsdSC260AuRRAezTMI6beETgb/e8Ib/fXoiHZHO0TOYtVtg6NjmmKRSFEmcb70JaAWlCpqKpNAAQF x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: cc367849-7c38-4504-a6bf-08d54155f6eb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307); SRVR:CY4PR12MB1509; x-ms-traffictypediagnostic: CY4PR12MB1509: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231023)(6055026)(6041248)(20161123564025)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011); SRVR:CY4PR12MB1509; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR12MB1509; x-forefront-prvs: 051900244E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(189003)(69224002)(13464003)(199004)(7696005)(81156014)(3846002)(8936002)(72206003)(102836003)(6116002)(14454004)(5660300001)(2950100002)(86362001)(53546010)(110136005)(7736002)(97736004)(305945005)(478600001)(99286004)(2906002)(74316002)(81166006)(316002)(76176011)(3280700002)(6246003)(53936002)(2501003)(68736007)(229853002)(33656002)(3660700001)(9686003)(25786009)(55016002)(66066001)(77096006)(6506006)(105586002)(6436002)(2900100001)(106356001)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1509; H:CY4PR12MB1509.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc367849-7c38-4504-a6bf-08d54155f6eb X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2017 11:46:21.2363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1509 Subject: Re: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 11:46:23 -0000 >Hi Ravi, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kumar >> Sent: Thursday, November 30, 2017 1:12 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP=20 >> crypto PMD >>=20 > >As I said in the another patch, you should add a commit message for comple= x patches like this one. >Another thing that would be useful for improving the readability of the pa= tchset and therefore, make a review easier, is to split a long patch in sma= ller patches. > >>From what I have seen, you have some patches where you are adding support = for CMAC and SHA3 algorithms. I suggest to do the same for the other algori= thms that this PMD supports. >So, the first patch would have the skeleton of the PMD, and then you can h= ave a separate patch per algorithm. >Well, not necessarily, a patch per algorithm, but per subset of algorithms= . >I would propose one for AES-CBC/ECB/CTR, one for 3DES-CBC, one for AES-GCM= and another one for SHA-x algorithms. > >Thanks, >Pablo > Hi Pablo, Thanks for all the comments. We are working on them. Regards, Ravi