DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Somalapuram, Amaranath" <Amaranath.Somalapuram@amd.com>
To: "Nandibasappa, Girish" <Girish.Nandibasappa@amd.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for set MTU API
Date: Thu, 4 Jun 2020 05:22:38 +0000	[thread overview]
Message-ID: <CY4PR12MB1574CDDC2C494FC5D58E5F12F8890@CY4PR12MB1574.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20200601144841.7814-1-gnandiba@amd.com>

[AMD Public Use]

Acked-by: Somalapuram Amaranath <asomalap@amd.com>

-----Original Message-----
From: Nandibasappa, Girish <Girish.Nandibasappa@amd.com>
Sent: Monday, June 1, 2020 8:19 PM
To: dev@dpdk.org
Cc: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>
Subject: [PATCH v1] net/axgbe: add support for set MTU API

From: gnandiba <gnandiba@amd.com>

This patch adds support for set_mtu API which can be used to change the Maximum Transmission unit (MTU) from application.

Signed-off-by: gnandiba <gnandiba@amd.com>
---
 drivers/net/axgbe/axgbe_ethdev.c | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
index 867058845..cdb1297f5 100644
--- a/drivers/net/axgbe/axgbe_ethdev.c
+++ b/drivers/net/axgbe/axgbe_ethdev.c
@@ -73,6 +73,7 @@ static void axgbe_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,  static void axgbe_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
 struct rte_eth_txq_info *qinfo);
 const uint32_t *axgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev);
+static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);

 struct axgbe_xstats {
 char name[RTE_ETH_XSTATS_NAME_SIZE];
@@ -214,6 +215,7 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = {
 .dev_supported_ptypes_get     = axgbe_dev_supported_ptypes_get,
 .rx_descriptor_status         = axgbe_dev_rx_descriptor_status,
 .tx_descriptor_status         = axgbe_dev_tx_descriptor_status,
+.mtu_set= axgb_mtu_set,
 };

 static int axgbe_phy_reset(struct axgbe_port *pdata) @@ -1254,7 +1256,35 @@ axgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev)
 return ptypes;
 return NULL;
 }
-
+static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) {
+struct rte_eth_dev_info dev_info;
+struct axgbe_port *pdata = dev->data->dev_private;
+uint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
+unsigned int val = 0;
+axgbe_dev_info_get(dev, &dev_info);
+/* check that mtu is within the allowed range */
+if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))
+return -EINVAL;
+/* mtu setting is forbidden if port is start */
+if (dev->data->dev_started) {
+PMD_DRV_LOG(ERR, "port %d must be stopped before configuration",
+dev->data->port_id);
+return -EBUSY;
+}
+if (frame_size > RTE_ETHER_MAX_LEN) {
+dev->data->dev_conf.rxmode.offloads |=
+DEV_RX_OFFLOAD_JUMBO_FRAME;
+val = 1;
+} else {
+dev->data->dev_conf.rxmode.offloads &=
+~DEV_RX_OFFLOAD_JUMBO_FRAME;
+val = 0;
+}
+AXGMAC_IOWRITE_BITS(pdata, MAC_RCR, JE, val);
+dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;
+return 0;
+}
 static void axgbe_get_all_hw_features(struct axgbe_port *pdata)  {
 unsigned int mac_hfr0, mac_hfr1, mac_hfr2;
--
2.17.1


  reply	other threads:[~2020-06-04  5:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 14:48 gnandiba
2020-06-04  5:22 ` Somalapuram, Amaranath [this message]
2020-06-08  9:08 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR12MB1574CDDC2C494FC5D58E5F12F8890@CY4PR12MB1574.namprd12.prod.outlook.com \
    --to=amaranath.somalapuram@amd.com \
    --cc=Girish.Nandibasappa@amd.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).